Bug 927269 - Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Summary: Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Schmidt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-25 14:24 UTC by Jérôme Glisse
Modified: 2013-08-06 22:27 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-10 16:07:11 UTC
Type: ---
Embargoed:
mschmidt: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jérôme Glisse 2013-03-25 14:24:34 UTC
Spec URL: http://people.fedoraproject.org/~glisse/glamor/xorg-x11-glamor.spec
SRPM URL: http://people.fedoraproject.org/~glisse/glamor/xorg-x11-glamor-0.5.0-0.fc19.src.rpm
Description: glamor is a library that could be use by xorg x11 ddx to implement acceleration using the OpenGL driver. Some new hardware such as AMD HD7xxx needs glamor for accelerations.
Fedora Account System Username: glisse

Comment 1 Michal Schmidt 2013-03-28 14:59:50 UTC
Just looking at the spec:
- The "Group" tag is optional. You may keep it or drop it.
- If possible, use a full URL in Source0.
- Please extend %description.
- The manual cleaning of the build root at the beginning of %install is
  redundant. So is the %clean section.
- The %check section is empty, so drop it.
- %defattr is no longer necessary.
- Please maintain a %changelog.

Comment 2 Jérôme Glisse 2013-03-28 19:47:03 UTC
Thank you for you review i have updated spec file and srpm same url.

Comment 3 Michal Schmidt 2013-03-29 13:00:53 UTC
> Version: 0.5.0
> Release: 0%{?dist}

Glamor 0.5.0 was released last year. You are packaging a more recent git snapshot, so the versioning must follow the rules for snapshots:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

> # source tarball has to be created from git (not ftp/http tar archive) at :
> # http://cgit.freedesktop.org/xorg/driver/glamor/

The instructions should be more specific to allow anyone to recreate the same tarball. See:
https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control

> %description
> glamor provide xorg-x11 acceleration using the OpenGL driver.

s/provide/provides/ ?

> find $RPM_BUILD_ROOT -type f -name '*.la' | xargs rm -f -- || :

Looks like you could simplify the command if you just used find's "-delete" action.

Comment 5 Michal Schmidt 2013-04-03 08:34:36 UTC
Thanks for adding make-git-snapshot.sh and the comment in the spec on how to use it. That's helpful.

Regarding the Release tag: A leading zero usually indicates a pre-release snapshot (see the NamingGuidelines) of the stated Version. However, your snapshot is newer than version 0.5.0, so the release should not start with a zero.

You forgot to add a %changelog entry.

Most importantly, the package does not build in mock:

...
checking for EGL... no
...
Processing files: xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.x86_64
error: File not found: /builddir/build/BUILDROOT/xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.x86_64/usr/lib64/xorg/modules/libglamoregl.so
    File not found: /builddir/build/BUILDROOT/xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.x86_64/usr/lib64/xorg/modules/libglamoregl.so
RPM build errors:
Child return code was: 1

My guess is you're missing some BuildRequires.

Comment 6 Jérôme Glisse 2013-04-03 15:21:03 UTC
Should i update the changelog even now as package is not accepted yet. It would leave a trace of all my mistake making package thought ;)

Updated spec with proper dependency and version but did not updated changelog section:
http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor.spec

SRPM:
http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-1.20130401git81aadb8.fc20.src.rpm

Comment 7 Michal Schmidt 2013-04-03 16:45:21 UTC
(In reply to comment #6)
> Should i update the changelog even now as package is not accepted yet. It
> would leave a trace of all my mistake making package thought ;)

Indeed it would and it's customary to do that.
However, I won't insist on having multiple changelog entries during this review. At the very least, please keep the version-release of your %changelog entry consistent with the actual values, OK? (In the latest spec you already do that, good!).


The SRPM now builds successfully, which allowed me to run rpmlint on it. Some issues to fix (or explain why they're not a problem):
- xorg-x11-glamor.x86_64: W: shared-lib-calls-exit
  /usr/lib64/libglamor.so.0.0.0 exit.5

  This is something to consider upstream.

- xorg-x11-glamor.x86_64: W: devel-file-in-non-devel-package
  /usr/lib64/libglamor.so

- xorg-x11-glamor.x86_64: E: library-without-ldconfig-postin
  /usr/lib64/libglamor.so.0.0.0

  See: https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

- There's a whole bunch of warnings like:
  xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/libglamor.so.0.0.0 serverClient

  If these are expected, please explain why.


Also please use %global instead of %define. See https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

Comment 8 Dan Mashal 2013-04-03 17:32:38 UTC
Sorry for the delay on a comment from me, and thanks everyone else for their helpful comments. I will try to get this review started, if not finished by this weekend.

Comment 9 Michal Schmidt 2013-04-03 17:40:24 UTC
Some more stuff I found:
- Upstream ships a COPYING file which you are not packaging as %doc. See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
  The licence text itself looks very MIT-like, which is good.

- glamor_copyarea.c, glamor_copywindow.c, glamor_fill.c, glamor_fillspans.c, glamor_window.c have different licence headers than the rest of the files. They specifically speak about Keith Packard (his name not to be used in advertising, him disclaiming warranties, etc.). I don't think it's an actual problem, though it is a little odd. It might make sense to ask Keith kindly to update the licence headers to match the usual form.

- glamor_eglmodule.c contains an additional requirement about the name of the XFree86 Project not to be used in advertising. This is perfectly acceptable, as far as I know. I'm just mentioning it for completeness.

- glamor_glyphs.c contains two almost identical licence headers. One speaks about Red Hat, the other about SuSE. Perhaps the authors could agree on changing this to the unified standard form?

- glamor_gldispatch.h, glamor_largepixmap.c have no license headers. The headers should be added by upstream.


I have just bought a small computer with a AMD E2-1800 APU, with a AMD Radeon HD 7340. Should I be able to test this package on it? How would I do that?

Comment 10 Jérôme Glisse 2013-04-03 19:05:28 UTC
Fixed devel package. Added ld-config post/unpost to silence rpmlint and added explanation on why it's not needed. Added doc.

The undefined symbol are expected. This can only be loaded by the xserver or ddx through dlopen, the undefined symbol are part of the xserver and thus know at load time.

To be thorough it's libglamor-egl which is dynamicly loaded, idea being we could have in a futur a libglamor-glx, difference would be in the glue both would use most of the same code that is in libglamor.

You don't need glamor for HD7340, it's only needed for >= HD77xx

You can still try to use it but you would need to rebuild the ddx with :
--enable-glamor

once this glamor package is accepted and available i will update the xorg-x11-drv-ati to build with glamor and add automatic use of glamor on hd7xxx

Updated spec and SRPM:
http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor.spec
http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-2.20130401git81aadb8.fc20.src.rpm

Comment 11 Michal Schmidt 2013-04-04 11:11:06 UTC
From the spec:
# No need to call to ldconfig for post installation/uninstallation as
# the libglamor libglamoregl are dynamicly load through dl open by the
# xserver or ddx driver. But to silence rpmlint just call them.

Are you sure this comment is accurate? I can see that it is valid for libglamoregl.so, which gets dlopen'd by the X server using a full path, but this .so then depends on libglamor.so.0, which gets resolved using the standard dynamic linker search order. So I'd say ldconfig is in fact needed and not just to silence rpmlint.

The -devel subpackage should require the base package using an arch-specific dependency. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

The explicit "Requires: pkgconfig" is redundant, because rpmbuild automatically added a requirement for "/usr/bin/pkg-config" for you.

The explicit "Requires: mesa-libEGL" is redundant, because the devel subpackage depends on the main package, which in turn already requires "libEGL.so.1()(64bit)"

Comment 12 Jérôme Glisse 2013-04-04 14:16:47 UTC
I am pretty sure that given how X implement stuff it's not necessary but i don't feel like diving in that code again so i removed the comment.

Fixed dependency
http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor.spec

http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-3.20130401git81aadb8.fc20.src.rpm

Comment 13 Michal Schmidt 2013-04-04 21:27:33 UTC
Let's check the ownership of directories (https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership):

> %files
> ...
> %{_libdir}/xorg/modules/libglamoregl.so
> %{_datadir}/X11/xorg.conf.d/glamor.conf

These two directories you install files into are neither owned by your package nor by any of the required packages. A possible way to prevent creating unowned directories is to Require xorg-x11-server-Xorg, which owns them.

> %files devel
> %{_includedir}/xorg/glamor.h

/usr/include/xorg is multiply owned by several packages. You can make your package own it too.

Comment 15 Michal Schmidt 2013-04-05 15:50:50 UTC
The src.rpm link points to the previous version. I see the correct link works:
http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-4.20130401git81aadb8.fc20.src.rpm

Comment 16 Michal Schmidt 2013-04-05 16:06:39 UTC
I'm pasting the result of a semi-automated, hand-edited review (using the "fedora-review" tool):


Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "MIT/X11 (BSD like)", "Unknown or generated". 2 files have unknown
     license. Detailed output of licensecheck in
     /home/michich/927269-xorg-x11-glamor/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
     NOTE: "xorg-x11-glamor" is not identical to the upstream
     project/tarball/repository name, but it matches the xorg-x11-* naming pattern
     used in Fedora.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
     NOTE: The multiple ownership of /usr/include/xorg is fine.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
     NOTE: http://koji.fedoraproject.org/koji/taskinfo?taskID=5218479
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: xorg-x11-glamor-0.5.0-4.20130401git81aadb8.fc20.x86_64.rpm
          xorg-x11-glamor-devel-0.5.0-4.20130401git81aadb8.fc20.x86_64.rpm
xorg-x11-glamor.x86_64: W: shared-lib-calls-exit /usr/lib64/libglamor.so.0.0.0 exit.5
xorg-x11-glamor-devel.x86_64: W: spelling-error Summary(en_US) renderer -> tenderer, rendered, render er
xorg-x11-glamor-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint xorg-x11-glamor-devel xorg-x11-glamor
xorg-x11-glamor-devel.x86_64: W: spelling-error Summary(en_US) renderer -> tenderer, rendered, render er
xorg-x11-glamor-devel.x86_64: W: no-documentation
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 serverClient
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionEmptyData
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 PictureScreenPrivateKeyRec
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 PixmapWidthPaddingInfo
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionEmptyBox
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miChangeGC
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCopyGC
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miDestroyGC
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miChangeClip
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miDestroyClip
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCopyClip
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyRectangle
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyArc
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miFillPolygon
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyFillArc
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyText8
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyText16
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miImageText8
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miImageText16
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionAppend
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miDoCopy
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbCopyPlane
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyGlyphBlt
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miImageGlyphBlt
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionDestroy
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbComposite
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegisterBlockAndWakeupHandlers
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 LogMessageVerb
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbGetImage
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_rasterize_trapezoid
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 ValidatePicture
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbGetSpans
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolyPoint
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbAddTraps
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 ValidateGC
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbDestroyPixmap
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 dixRegisterPrivateKey
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 XNFasprintf
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionCreate
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCompositeRects
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 GetScratchGC
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 FreeScratchGC
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbValidateGC
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_rectangles
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_contains_rectangle
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 CreatePicture
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCreatePicture
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miDestroyPicture
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_image_unref
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_init_rects
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fb24_32ReformatTile
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_extents
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPushPixels
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbCopyNtoN
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 PictureMatchFormat
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbCreatePixmap
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbCreateGC
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_union
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbTriangles
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPolyLine
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_init_with_extents
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 glamor_egl_restore_context
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbFill
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 glamor_gl_dispatch_init
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbSetSpans
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miGetImage
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 RegionValidate
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 FatalError
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPadPixmap
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_intersect
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_image_create_bits
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_f_transform_point
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 DamageRegionAppend
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miComputeCompositeRegion
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPolyFillRect
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 LogMessage
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 CompositePicture
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_transform_is_int_translate
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_f_transform_from_pixman_transform
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miRenderColorToPixel
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_copy
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_image_get_data
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 DamageRegionProcessPending
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_image_composite
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 glamor_egl_make_current
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 FreePicture
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 glamor_egl_screen_init
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miCopyRegion
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 CreateSolidPicture
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_translate
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_init
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miPolySegment
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbFillSpans
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 pixman_region_fini
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPixmapToRegion
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 fbPutImage
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 miTrapezoidBounds
xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 ErrorF
xorg-x11-glamor.x86_64: W: shared-lib-calls-exit /usr/lib64/libglamor.so.0.0.0 exit.5
2 packages and 0 specfiles checked; 0 errors, 101 warnings.
# echo 'rpmlint-done:'



Requires
--------
xorg-x11-glamor-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libglamor.so.0()(64bit)
    xorg-x11-glamor(x86-64)

xorg-x11-glamor (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libEGL.so.1()(64bit)
    libGL.so.1()(64bit)
    libc.so.6()(64bit)
    libglamor.so.0()(64bit)
    rtld(GNU_HASH)
    xorg-x11-server-Xorg



Provides
--------
xorg-x11-glamor-devel:
    pkgconfig(glamor)
    pkgconfig(glamor-egl)
    xorg-x11-glamor-devel
    xorg-x11-glamor-devel(x86-64)

xorg-x11-glamor:
    libglamor.so.0()(64bit)
    libglamoregl.so()(64bit)
    xorg-x11-glamor
    xorg-x11-glamor(x86-64)



Unversioned so-files
--------------------
xorg-x11-glamor: /usr/lib64/xorg/modules/libglamoregl.so

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 927269

Comment 17 Jérôme Glisse 2013-04-05 18:24:55 UTC
I don't see any issue left ? Is there something specific that bother you ?

Comment 18 Michal Schmidt 2013-04-05 21:24:46 UTC
No. I asked Dan on IRC if I can just reassign this review to myself, but he has not responded yet. So I'll just go ahead, because I consider this review complete.

Comment 19 Michal Schmidt 2013-04-05 21:30:27 UTC
fedora-review+ set. You may proceed with your SCM request.

I suggest you to make the dependency on xorg-x11-server-Xorg an arch-specific one and add a comment explaining why the dependency exists. I did not want to block the review on this minor issue.

Also I would be interested in any upstream activity related to the issues pointed out during this review (the missing licence headers in a couple of files, the exit() call in library code), but these are no blockers either.

Comment 20 Dan Mashal 2013-04-05 21:46:54 UTC
Thanks Michal for picking this up! Sorry I couldn't get to this sooner.

Comment 21 Jérôme Glisse 2013-04-05 21:49:01 UTC
The exit one is really a panic for case that should not happen, it's more like an assert i guess but using exit trigger Xorg trace stuff so often you end up with something usefull in the xorg log.

I am gonna talk with Keith and maybe our lawyer to simplify the header maybe.

Comment 22 Michal Schmidt 2013-04-06 08:17:18 UTC
(In reply to comment #21)
> I am gonna talk with Keith and maybe our lawyer to simplify the header maybe.

Thank you. To be clear: I don't think there would be any problem if they refused to do any simplification. The missing licence headers in glamor_gldispatch.h and glamor_largepixmap.c are slightly more important.

Comment 23 Jérôme Glisse 2013-04-08 14:19:10 UTC
New Package SCM Request
=======================
Package Name: xorg-x11-glamor
Short Description: glamor provides xorg-x11 acceleration using OpenGL
Owners: glisse airlied xgl-maint
Branches: f19 el6
InitialCC:

Comment 24 Gwyn Ciesla 2013-04-08 14:30:28 UTC
Git done (by process-git-requests).

Comment 25 Dominik 'Rathann' Mierzejewski 2013-05-21 10:17:17 UTC
Can we get this on Fedora 18, too?

Comment 26 Adam Jackson 2013-05-22 18:16:16 UTC
Package Change Request
======================
Package name: xorg-x11-glamor
Branches: f18

Comment 27 Gwyn Ciesla 2013-05-22 18:22:18 UTC
No owner specified.

Comment 28 Adam Jackson 2013-05-22 18:28:20 UTC
Package Change Request
======================
Package name: xorg-x11-glamor
Owners: glisse airlied xgl-maint
Branches: f18

Comment 29 Gwyn Ciesla 2013-05-22 18:37:08 UTC
Package Change Request
======================
Package Name: xorg-x11-glamor
Owners: glisse airlied xgl-maint
Branches: f18

Comment 30 Gwyn Ciesla 2013-05-22 18:38:17 UTC
Package Change Request
======================
Package Name: xorg-x11-glamor
Owners: glisse airlied xgl-maint
New Branches: f18

Comment 31 Gwyn Ciesla 2013-05-22 18:40:12 UTC
Git done (by process-git-requests).

Note corrected formatting.


Note You need to log in before you can comment on or make changes to this bug.