Spec URL: http://theory.physics.helsinki.fi/~jzlehtol/rpms/naga.spec SRPM URL: http://theory.physics.helsinki.fi/~jzlehtol/rpms/naga-3.0-1.82svn.fc18.src.rpm Description: Naga aims to be a very small NIO library that provides a handful of java classes to wrap the usual Socket and ServerSocket with asynchronous NIO counterparts (similar to NIO2 planned for Java 1.7). All of this is driven from a single thread, making it useful for both client (e.g. allowing I/O to be done in the AWT-thread without any need for threads) and server programming (1 thread for all connections instead of 2 threads/connection). Internally Naga is a straightforward NIO implementation without any threads or event-queues thrown in, it is "just the NIO-stuff", to let you build things on top of it. Naga contains the code needed to get NIO up and running without having to code partially read buffers and setting various selection key flags. Fedora Account System Username: jussilehtola This is necessary to update JMol to version 13.
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated {{...}} = Reviewer comments ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [-]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [-]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in naga- javadoc {{apparently not required for javadoc packages, per the specfile templates in Packaging:java}} [x]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/eric/rpmbuild/SPECS/927877-naga/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Fully versioned dependency in subpackages, if present. [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [-]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. {{not sure that this is needed for MIT/X11}} [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. {{could the test code in src/test be used for this?}} [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [x]: Package has BuildArch: noarch (if possible) [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: naga-3.0-1.82svn.fc17.noarch.rpm naga-javadoc-3.0-1.82svn.fc17.noarch.rpm naga.noarch: W: no-documentation naga-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint naga-javadoc naga naga-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados naga.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- naga-javadoc (rpmlib, GLIBC filtered): jpackage-utils naga (rpmlib, GLIBC filtered): java jpackage-utils Provides -------- naga-javadoc: naga-javadoc naga: naga Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 927877 The package is APPROVED.
Thanks for the review! New Package SCM Request ======================= Package Name: naga Short Description: Simplified Java NIO asynchronous sockets Owners: jussilehtola Branches: F-18 F-19 InitialCC:
Git done (by process-git-requests).
jmol-13.0.15-1.fc19,jspecview-2-4.1169svn.fc19,naga-3.0-1.82svn.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/jmol-13.0.15-1.fc19,jspecview-2-4.1169svn.fc19,naga-3.0-1.82svn.fc19
jmol-13.0.15-1.fc18,jspecview-2-4.1169svn.fc18,naga-3.0-1.82svn.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/jmol-13.0.15-1.fc18,jspecview-2-4.1169svn.fc18,naga-3.0-1.82svn.fc18
jmol-13.0.15-1.fc19, jspecview-2-4.1169svn.fc19, naga-3.0-1.82svn.fc19 has been pushed to the Fedora 19 testing repository.
jmol-13.0.15-1.fc18, jspecview-2-4.1169svn.fc18, naga-3.0-1.82svn.fc18 has been pushed to the Fedora 18 stable repository.
jmol-13.0.15-1.fc19, jspecview-2-4.1169svn.fc19, naga-3.0-1.82svn.fc19 has been pushed to the Fedora 19 stable repository.