Bug 927946
| Summary: | Ticket Monster does not support Forge bundled in JBDS 6.0.1 | ||
|---|---|---|---|
| Product: | [Retired] JBoss Enterprise WFK Platform 2 | Reporter: | Tomas Repel <trepel> |
| Component: | TicketMonster | Assignee: | Pete Muir <pmuir> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Matous Jobanek <mjobanek> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 2.2.0 | CC: | bsutter, kpiwko, mnovotny, myarboro |
| Target Milestone: | CR2 | ||
| Target Release: | 2.2.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | ticket-monster | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-14 14:55:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I extended the conditions for forge versions http://git.app.eng.bos.redhat.com/?p=wfk/ticket-monster.git;a=commitdiff;h=41db846148ed8a1978b1ece41f29a57cf38ae26c There are other various problems with the script. Please hold and I will supply a newer version in the upstream repo. Do not proceed with the patch linked. Tomas Repel - there should be an upstream issue filed for this. Pete Muir <pmuir.uk> updated the status of jira JDF-256 to Resolved Pete Muir <pmuir.uk> made a comment on jira JDF-256 Fixed, and backported to the 2.0.x branch. The fix is https://github.com/jboss-jdf/ticket-monster/commit/f2e982763b172470a1af52913ec547f6bac27f2a on the 2.0.x branch. I took a look at the product version. What is the last time this was rebased on upstream? The histories look quite divergent :-( (In reply to comment #7) > The fix is > https://github.com/jboss-jdf/ticket-monster/commit/ > f2e982763b172470a1af52913ec547f6bac27f2a on the 2.0.x branch. > > I took a look at the product version. What is the last time this was rebased > on upstream? The histories look quite divergent :-( As you remember we rolled back to the wfk2-prod-branch from wfk22-prod-branch due JDG feature dropping. And the history is with all product fixes after 2.0.1.Final. And yes the rebase was not done on it, because Marius was late with fixing at final phase and we did it in product branch first, upstream fixes were done later by Marius. (In reply to comment #3) > There are other various problems with the script. Please hold and I will > supply a newer version in the upstream repo. Do not proceed with the patch > linked. Pete, we already has got staged CR2, your change can't be included if there is not blocking issue. But I checked after commit http://git.app.eng.bos.redhat.com/?p=wfk/ticket-monster.git;a=commitdiff;h=41db846148ed8a1978b1ece41f29a57cf38ae26c that script works with forge 1.2.2 and deployed TiMo administration basically works. If you don't have a strong argument to respin TiMo I will let this on QE of WFK 2.2.0.CR2. Pete, what are other problem with the script?
I the snippet:
cp src/main/webapp/index.xhtml src/main/webapp/admin/index.xhtml;
rm --force src/main/webapp/index.xhtml;
causing "other problems". Tomas, did you hit any such issues?
This issue should be only about turning on forge 1.2.x for JBDS and TiMo usage. Pete's back port patch is not like that as Karel is asking for explanation. CR2 is already staged and Pete, you were late with the comment https://bugzilla.redhat.com/show_bug.cgi?id=927946#c3. Now if there is no blocker for using JBDS 6.0.1 and bundled Forge 1.2.2, this issue should be ON_QA for WFK 2.2.0.CR2. This is holding my WFK 2.2.0.CR2 announcement. How on earth was I "late"? I made the comment 5h after the other fix was posted. This may be due to the divergence between upstream and product branch, but upstream was not working properly with the patches, so I had to redo the patches. The ones we were using there would not apply. So I don't believe this issue is fixed. I will double check again in JBDS and post back. Let's follow up on the ML re divergent branches. Ok, I can't see this problem in the WFK branch, so I guess the patch to fix this never got moved upstream. I have checked the original problem - it is solved and I did not find any other. - The project could be built and deployed with the admin pages. Closed as CURRENTRELEASE, part of WFK 2.2.0 distributables. |
Description of problem: Ticket Monster example contains Forge script admin_layer.fsh that is designed to be executed by Forge 1.0.x and 1.1.x versions. But the Forge 1.2.2.Final is shipped with latest JBDS 6.0.1. Version-Release number of selected component (if applicable): JBDS 6.0.1.GA WFK 2.2.0.CR1 Ticket Monster 2.0.7.Final-redhat-1 How reproducible: Always. Steps to Reproduce: 1. unzip Ticket Monster example 2. navigate into ticket-monster/demo directory 3. run forge 1.2.2.Final 4. execute `run admin_layer.fsh` Actual results: The output is: `The version 1.2.2.Final is not supported yet` Expected results: It should be possible to apply the patches. Additional info: I modify the script to accept 1.2.x version too (just added `|| v.startsWith("1.2.")` into appropriate two if conditions) and it worked.