Bug 928418 - Review Request: perl-Devel-GlobalDestruction-XS - Faster implementation of the Devel::GlobalDestruction API
Summary: Review Request: perl-Devel-GlobalDestruction-XS - Faster implementation of th...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-27 15:33 UTC by Paul Howarth
Modified: 2013-04-27 08:16 UTC (History)
3 users (show)

Fixed In Version: perl-Devel-GlobalDestruction-XS-0.01-3.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-27 08:16:30 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2013-03-27 15:33:06 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Devel-GlobalDestruction-XS/branches/fedora/perl-Devel-GlobalDestruction-XS.spec

SRPM URL: http://www.city-fan.org/~paul/extras/perl-Devel-GlobalDestruction-XS/perl-Devel-GlobalDestruction-XS-0.01-2.fc20.src.rpm

Description:
This is an XS backend for Devel::GlobalDestruction and should be used through
that module.

Fedora Account System Username: pghmcfc

Comment 1 Paul Howarth 2013-03-27 15:35:56 UTC
I should add that this package is primarily for EPEL 5 and 6, since Devel::GlobalDestruction does not use the XS backend on perl > 5.13.7, at least not at the moment.

Comment 2 Petr Šabata 2013-04-09 15:38:14 UTC
I'm not sure about old Fedoras and EPELs but current rpmbuild detects "require"d modules just fine if there's no whitespace in front of them.  Maybe you could drop that explicit runtime dependency.

None of the missing deps dual-lives at the moment so I guess I can approve this now ;)

Comment 3 Paul Howarth 2013-04-09 17:59:38 UTC
(In reply to comment #2)
> I'm not sure about old Fedoras and EPELs but current rpmbuild detects
> "require"d modules just fine if there's no whitespace in front of them. 
> Maybe you could drop that explicit runtime dependency.

Hmm, curious. Somewhat contrary to my expectations, even builds back to FC-3 find that perl(XSLoader) dependency, so yes, I'll remove it.

I was a little confused when I noticed that all my builds had two instances of this dependency, except for F-19 and Rawhide which only had the one; having removed the explicit dependency, these latter builds still have the one so I guess the latest rpm does some removal of duplicates.

> None of the missing deps dual-lives at the moment so I guess I can approve
> this now ;)

Thanks for the review Petr.

Comment 4 Paul Howarth 2013-04-09 18:03:54 UTC
New Package SCM Request
=======================
Package Name: perl-Devel-GlobalDestruction-XS
Short Description: Faster implementation of the Devel::GlobalDestruction API
Owners: pghmcfc
Branches: el5 el6 f17 f18 f19
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-04-09 18:11:12 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-04-09 19:44:34 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Devel-GlobalDestruction-XS-0.01-3.fc19

Comment 7 Fedora Update System 2013-04-09 19:44:51 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Devel-GlobalDestruction-XS-0.01-3.el6

Comment 8 Fedora Update System 2013-04-09 19:45:05 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-Devel-GlobalDestruction-XS-0.01-3.fc17

Comment 9 Fedora Update System 2013-04-09 19:45:16 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Devel-GlobalDestruction-XS-0.01-3.el5

Comment 10 Fedora Update System 2013-04-09 19:45:28 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-Devel-GlobalDestruction-XS-0.01-3.fc18

Comment 11 Petr Šabata 2013-04-10 09:16:51 UTC
(In reply to comment #3)
> having removed the explicit dependency, these latter builds still have the
> one so I guess the latest rpm does some removal of duplicates.

Yes, that's a rather recent change.

Comment 12 Fedora Update System 2013-04-19 04:47:41 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.fc17 has been pushed to the Fedora 17 stable repository.

Comment 13 Fedora Update System 2013-04-19 04:51:09 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.fc18 has been pushed to the Fedora 18 stable repository.

Comment 14 Fedora Update System 2013-04-20 20:16:35 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.fc19 has been pushed to the Fedora 19 stable repository.

Comment 15 Fedora Update System 2013-04-27 02:05:42 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 16 Fedora Update System 2013-04-27 02:06:17 UTC
perl-Devel-GlobalDestruction-XS-0.01-3.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.