RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 929045 - The error message should be improved while forbidding to define secret in readonly mode
Summary: The error message should be improved while forbidding to define secret in rea...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Ján Tomko
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-29 06:23 UTC by Xuesong Zhang
Modified: 2014-06-18 00:46 UTC (History)
6 users (show)

Fixed In Version: libvirt-1.0.4-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 11:01:29 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Xuesong Zhang 2013-03-29 06:23:47 UTC 
Description of problem:
The error message should be improved while forbidding to define secret in readonly mode.
This issue didn't occurred in rhel6, only in rhel7.

Version-Release number of selected component (if applicable):
libvirt-1.0.3-1.el7.x86_64
qemu-kvm-1.4.0-1.el7.x86_64
kernel-3.7.0-0.36.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. prepare the following secret xml.
<secret ephemeral='no' private='yes'>
 <description>LUKS passphrase for the main hard drive of our mail server</description>
  <usage type='volume'>
   <volume>/var/lib/libvirt/images/rhel7.img</volume>
  </usage>
</secret>
2. switch to readonly mode, and define the secret
#virsh -r
Welcome to virsh, the virtualization interactive terminal.

Type:  'help' for help with commands
       'quit' to quit

virsh > secret-define secret.xml 
error: Failed to set attributes from secret.xml
error: Invalid secret: virSecretFree

Actual results:
as steps

Expected results:
The error message should be improved, such as the following error message is rhel6.
virsh > secret-define secret.xml 
error: Failed to set attributes from secret.xml
error: operation virSecretDefineXML forbidden for read only access

Additional info:
Comment 2 Ján Tomko 2013-03-29 12:13:07 UTC 
Fixed upstream by:
commit bfb4b822579ce1afcbc396fe4bc3b57fb3ebc150
Author:     Ján Tomko <jtomko>
AuthorDate: 2013-03-29 12:55:38 +0100
Commit:     Ján Tomko <jtomko>
CommitDate: 2013-03-29 13:00:49 +0100

    virsh: don't call virSecretFree on NULL
    
    Since the refactoring in fbe2d49 we call virSecretFree even if
    virSecretDefineXML fails, which leads to overwriting the error
    message with:
    error: Invalid secret: virSecretFree
Comment 3 zhenfeng wang 2013-04-10 07:49:55 UTC 
Verify this bug with :
libvirt-1.0.4-1.el7

1. prepare the following secret xml.
<secret ephemeral='no' private='yes'>
 <description>LUKS passphrase for the main hard drive of our mail server</description>
  <usage type='volume'>
   <volume>/var/lib/libvirt/images/rhel7.img</volume>
  </usage>
</secret>
2. switch to readonly mode, and define the secret
#virsh -r
Welcome to virsh, the virtualization interactive terminal.

Type:  'help' for help with commands
       'quit' to quit

virsh > secret-define secret.xml 
error: Failed to set attributes from secret.xml
error: operation virSecretDefineXML forbidden for read only access

Since it works well on libvirt-1.0.4.1 and I can reproduce it on libvirt-1.0.3.1, so make this bug verified
Comment 4 Ludek Smid 2014-06-13 11:01:29 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.
Note You need to log in before you can comment on or make changes to this bug.