Bug 929084

(In reply to comment #0)
> Description of problem:
> boot a win8.64 guest,and hotplug a scsi-hd,info block can see the correct
> information,but guest can not detect it automatically,after I "rescan disks"
> in Disk Management,the hotpluged scsi-hd can be seen.And after I hotunplug
> the scsi-hd,guest still can see it(but can not do operation on it),then
> after "rescan disks" guest can not see it.
> scsi-disk,scsi-cd hit the same problem. 
> 
Could you help to check whether rhel guest can hit this issue ? Maybe the virtio-win driver issue. Thanks.

jinli ,pls retest this bug on RHEL guest

(In reply to comment #5)
> jinli ,pls retest this bug on RHEL guest

After retest on rhel guest,guest did not hit the issue:
with fdisk -l command,hotpluged device can be seen

Reproduced on win2012 and win2008 guest when hotplug a scsi disk. 

With option hotplug=on/off, win2012 and win2008 guest always need to rescan disks.

(In reply to Yumei Huang from comment #12)
> Reproduced on win2012 and win2008 guest when hotplug a scsi disk. 
> 
> With option hotplug=on/off, win2012 and win2008 guest always need to rescan
> disks.

Could you please give a try to virtio-scsi driver from  build 112 https://brewweb.devel.redhat.com//buildinfo?buildID=470418 ?

Thanks,
Vadim.

(In reply to Vadim Rozenfeld from comment #13)
> (In reply to Yumei Huang from comment #12)
> > Reproduced on win2012 and win2008 guest when hotplug a scsi disk. 
> > 
> > With option hotplug=on/off, win2012 and win2008 guest always need to rescan
> > disks.
> 
> Could you please give a try to virtio-scsi driver from  build 112
> https://brewweb.devel.redhat.com//buildinfo?buildID=470418 ?
> 
build 112 still hit the same issue

(In reply to lijin from comment #14)
> (In reply to Vadim Rozenfeld from comment #13)
> > (In reply to Yumei Huang from comment #12)
> > > Reproduced on win2012 and win2008 guest when hotplug a scsi disk. 
> > > 
> > > With option hotplug=on/off, win2012 and win2008 guest always need to rescan
> > > disks.
> > 
> > Could you please give a try to virtio-scsi driver from  build 112
> > https://brewweb.devel.redhat.com//buildinfo?buildID=470418 ?
> > 
> build 112 still hit the same issue

,
Could you please provide the exact steps how to reproduce the problem?

Thanks,
Vadim.

1.boot a win2012 guest:
/usr/libexec/qemu-kvm -M pc -cpu SandyBridge -M pc -enable-kvm -m 2G -smp 2 -nodefconfig -nodefaults -rtc base=localtime,driftfix=slew -boot order=cd,menu=on -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 -drive file=win2012-pre.qcow2,if=none,id=drive-ide0-0-0,format=qcow2,serial=mike_cao,cache=none -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=isa_serial0 -device usb-tablet,id=input0 -vnc 0.0.0.0:0 -vga cirrus -qmp tcp:0:4444,server,nowait -monitor stdio

2.check in disk management there's no extra disk

3.hot-plug scsi controller
(qemu) device_add virtio-scsi-pci,id=scsi0

4.install scsi driver in guest

5.hot-plug a formatted scsi-hd disk:
(qemu) __com.redhat_drive_add file=test.raw,id=drive1
(qemu) device_add scsi-hd,bus=scsi0.0,drive=drive1,id=scsi1

6.check in disk management and "Computer" ---> the hot-plugged disk is NOT displayed,there is no new disk in "Computer"

7.right click disk management,then click "Rescan disks"---> the hot-plugged disk can be displayed,there is a new disk "New Volume(F:)" in "Computer"

8.hot-unplug the disk
(qemu) device_del scsi1

9.check in disk management and and "Computer"  ---> the disk became "unknow" status and the disk "New Volume(F:)" still can be seen in "Computer"

10.right click disk management,then click "Rescan disks"--->the disk disappear in disk management and the "New Volume(F:)" disappear in "Computer"

from step6 and step9,guest can NOT detect the disk add/delete automatically;
from step7 and step10,guest CAN detect the disk add/delete only if we do "Rescan" in disk management.


QE report this bug due to:
1.rhel guest does NOT hit this issue;
2.blk device does NOT hit this issue,disk can be detect automatically after the hotplug/hot-unplug.

(In reply to lijin from comment #16)
> 1.boot a win2012 guest:
> /usr/libexec/qemu-kvm -M pc -cpu SandyBridge -M pc -enable-kvm -m 2G -smp 2
> -nodefconfig -nodefaults -rtc base=localtime,driftfix=slew -boot
> order=cd,menu=on -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 -drive
> file=win2012-pre.qcow2,if=none,id=drive-ide0-0-0,format=qcow2,
> serial=mike_cao,cache=none -device
> ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -chardev
> pty,id=charserial0 -device isa-serial,chardev=charserial0,id=isa_serial0
> -device usb-tablet,id=input0 -vnc 0.0.0.0:0 -vga cirrus -qmp
> tcp:0:4444,server,nowait -monitor stdio
> 
> 2.check in disk management there's no extra disk
> 
> 3.hot-plug scsi controller
> (qemu) device_add virtio-scsi-pci,id=scsi0

How does it work if you explicitly specify "hotplugability"? Something like

device_add virtio-scsi-pci,id=scsi0,hotplug=on

I was referencing the following document https://polarion.engineering.redhat.com/polarion/#/project/RHEL6/workitem?id=RHEL6-5687 when tried to reproduce the problem.

Thanks.
Vadim.
 
> 
> 4.install scsi driver in guest
> 
> 5.hot-plug a formatted scsi-hd disk:
> (qemu) __com.redhat_drive_add file=test.raw,id=drive1
> (qemu) device_add scsi-hd,bus=scsi0.0,drive=drive1,id=scsi1
> 
> 6.check in disk management and "Computer" ---> the hot-plugged disk is NOT
> displayed,there is no new disk in "Computer"
> 
> 7.right click disk management,then click "Rescan disks"---> the hot-plugged
> disk can be displayed,there is a new disk "New Volume(F:)" in "Computer"
> 
> 8.hot-unplug the disk
> (qemu) device_del scsi1
> 
> 9.check in disk management and and "Computer"  ---> the disk became "unknow"
> status and the disk "New Volume(F:)" still can be seen in "Computer"
> 
> 10.right click disk management,then click "Rescan disks"--->the disk
> disappear in disk management and the "New Volume(F:)" disappear in "Computer"
> 
> from step6 and step9,guest can NOT detect the disk add/delete automatically;
> from step7 and step10,guest CAN detect the disk add/delete only if we do
> "Rescan" in disk management.
> 
> 
> QE report this bug due to:
> 1.rhel guest does NOT hit this issue;
> 2.blk device does NOT hit this issue,disk can be detect automatically after
> the hotplug/hot-unplug.

(In reply to Vadim Rozenfeld from comment #17)
> (In reply to lijin from comment #16)
> > 1.boot a win2012 guest:
> > /usr/libexec/qemu-kvm -M pc -cpu SandyBridge -M pc -enable-kvm -m 2G -smp 2
> > -nodefconfig -nodefaults -rtc base=localtime,driftfix=slew -boot
> > order=cd,menu=on -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 -drive
> > file=win2012-pre.qcow2,if=none,id=drive-ide0-0-0,format=qcow2,
> > serial=mike_cao,cache=none -device
> > ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -chardev
> > pty,id=charserial0 -device isa-serial,chardev=charserial0,id=isa_serial0
> > -device usb-tablet,id=input0 -vnc 0.0.0.0:0 -vga cirrus -qmp
> > tcp:0:4444,server,nowait -monitor stdio
> > 
> > 2.check in disk management there's no extra disk
> > 
> > 3.hot-plug scsi controller
> > (qemu) device_add virtio-scsi-pci,id=scsi0
> 
> How does it work if you explicitly specify "hotplugability"? Something like
> 
> device_add virtio-scsi-pci,id=scsi0,hotplug=on
> 
> I was referencing the following document
> https://polarion.engineering.redhat.com/polarion/#/project/RHEL6/
> workitem?id=RHEL6-5687 when tried to reproduce the problem.

I also tried add "hotplug=on",the result is same

Reproduced this bug on win2016 guest with virtio-win-1.6.3-3.el6.noarch.

Verified this bug on win2016 guest with virtio-win-prewhql-156, no need do "Rescan disk", the new hot-pluged disk can be found automatically, And hot-unpluged disk also disappeared automatically.

Steps as comment#0.

According to upper result, this bug has been fixed.

Can we have QA, PM and Release flags for this, please?

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3413