Bug 947155 - Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Summary: Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-01 18:58 UTC by Paweł Forysiuk
Modified: 2013-04-20 20:19 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-04-20 20:19:53 UTC
Type: ---
Embargoed:
kalevlember: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Paweł Forysiuk 2013-04-01 18:58:54 UTC
Spec URL: https://dl.dropbox.com/u/2448780/mingw-gstreamer1-1.0.6.spec
SRPM URL: https://dl.dropbox.com/u/2448780/mingw-gstreamer1-1.0.6-1.fc18.src.rpm
Description: MinGW Windows Streaming-Media Framework Runtime
Fedora Account System Username: pfor

Comment 1 Kalev Lember 2013-04-01 19:44:39 UTC
Taking for review.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5195682

Comment 2 Kalev Lember 2013-04-01 19:51:45 UTC
The spec file renames the gst-plugin-scanner.exe that's in libexec/ to gst-plugin-scanner-1.0.exe; why?

I'm no gstreamer expert, but it seems to be an internal helper executable invoked by libgstreamer-1.0-0.dll. How does the library know what the new name is?

Comment 3 Paweł Forysiuk 2013-04-01 20:29:18 UTC
This was clearly a mistake, thanks for pointing it out. Updated files below.

Spec URL: https://dl.dropbox.com/u/2448780/mingw-gstreamer1-1.0.6.spec
SRPM URL: https://dl.dropbox.com/u/2448780/mingw-gstreamer1-1.0.6-1.fc18.src.rpm

Comment 4 Kalev Lember 2013-04-01 20:49:45 UTC
Fedora review of mingw-gstreamer1-1.0.6-1.fc18.src.rpm 2013-04-01

+ OK
! needs attention

rpmlint output:

$ rpmlint mingw-gstreamer1-1.0.6-1.fc19.src.rpm \
          mingw32-gstreamer1-1.0.6-1.fc19.noarch.rpm \
          mingw64-gstreamer1-1.0.6-1.fc19.noarch.rpm \
          mingw32-gstreamer1-debuginfo-1.0.6-1.fc19.noarch.rpm \
          mingw64-gstreamer1-debuginfo-1.0.6-1.fc19.noarch.rpm
mingw-gstreamer1.src: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer
mingw-gstreamer1.src: E: changelog-time-in-future 2013-04-02
mingw-gstreamer1.src: E: specfile-error warning: bogus date in %changelog: Mon Apr 02 2013 Paweł Forysiuk <tuxator> - 1.0.6-1
mingw32-gstreamer1.noarch: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer
mingw32-gstreamer1.noarch: E: changelog-time-in-future 2013-04-02
mingw32-gstreamer1.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-gstreamer1-1.0.6/COPYING
mingw64-gstreamer1.noarch: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer
mingw64-gstreamer1.noarch: E: changelog-time-in-future 2013-04-02
mingw64-gstreamer1.noarch: E: incorrect-fsf-address /usr/share/doc/mingw64-gstreamer1-1.0.6/COPYING
mingw32-gstreamer1-debuginfo.noarch: E: changelog-time-in-future 2013-04-02
mingw32-gstreamer1-debuginfo.noarch: E: debuginfo-without-sources
mingw64-gstreamer1-debuginfo.noarch: E: changelog-time-in-future 2013-04-02
mingw64-gstreamer1-debuginfo.noarch: E: debuginfo-without-sources
5 packages and 0 specfiles checked; 10 errors, 3 warnings.

+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
  native Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  d0797e51a420fca0beb973b9dcda586f  gstreamer-1.0.6.tar.xz
  d0797e51a420fca0beb973b9dcda586f  Download/gstreamer-1.0.6.tar.xz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ locale handling
n/a ldconfig in %post and %postun
+ Package doesn't bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8

Just a small issue that rpmlint caught above: it should be 'Mon Apr 01', not
'Mon Apr 02' in the changelog.
Otherwise looks good, but please fix this before importing.

APPROVED

Comment 5 Paweł Forysiuk 2013-04-02 08:23:35 UTC
New Package SCM Request
=======================
Package Name: mingw-gstreamer1
Short Description: MinGW compilation of GStreamer1
Owners: pfor
Branches: f18 f19

Comment 6 Gwyn Ciesla 2013-04-02 12:53:37 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-04-07 21:17:12 UTC
mingw-gstreamer1-1.0.6-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/mingw-gstreamer1-1.0.6-1.fc19

Comment 8 Fedora Update System 2013-04-08 16:05:06 UTC
mingw-gstreamer1-1.0.6-1.fc19 has been pushed to the Fedora 19 testing repository.

Comment 9 Fedora Update System 2013-04-20 20:19:54 UTC
mingw-gstreamer1-1.0.6-1.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.