Spec URL: http://vakwetu.fedorapeople.org/jboss_servlet_2.5/jboss-servlet-2.5-api.spec SRPM URL: http://vakwetu.fedorapeople.org/jboss_servlet_2.5/jboss-servlet-2.5-api-1.0.1-1.fc17.src.rpm Description: This package provides an implementaton of servlet api 2.5. It is analogous (and comes from the same source tree as jboss-servlet-3.0-api). This package is needed to unblock the build for resteasy in F19 alpha. This in turn will unblock the builds of dogtag, ipa, jbossas etc. So getting this in as a high priority. In discussion with sochotni, mgoldmann and akurtakov, it was discussed that this package should NOT include the provides for javax.servlet, because it is not the latest version. We also discussed the idea of versioning the jars. The spec file and SRPM above are the non-versioned versions. If the Provides is not included, then versioning becomes unneccesary. If the reviewers decide otherwise though, here are some links to a versioned SPEC and SRPM file. SRPM: http://vakwetu.fedorapeople.org/jboss_servlet_2.5/versioned/jboss-servlet-2.5-api-1.0.1-1.fc17.src.rpm SPEC: http://vakwetu.fedorapeople.org/jboss_servlet_2.5/versioned/jboss-servlet-2.5-api.spec Thanks!
I'm going to review this.
Issues: 1. Licensing, should be "ASL 2.0 and W3C" Otherwise the package looks good for me. Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. ASL 2.0 and W3C [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [-]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jboss- servlet-2.5-api-javadoc [x]: Package complies to the Packaging Guidelines [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/goldmann/fedora/review/review- jboss-servlet-2.5-api/licensecheck.txt The license of this implementation should be set to "ASL 2.0 and W3C" [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Fully versioned dependency in subpackages, if present. [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Dist tag is present. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [x]: Package has BuildArch: noarch (if possible) [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jboss-servlet-2.5-api-1.0.1-1.fc18.noarch.rpm jboss-servlet-2.5-api-javadoc-1.0.1-1.fc18.noarch.rpm jboss-servlet-2.5-api.noarch: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden jboss-servlet-2.5-api-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados jboss-servlet-2.5-api-javadoc.noarch: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint jboss-servlet-2.5-api-javadoc jboss-servlet-2.5-api jboss-servlet-2.5-api-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados jboss-servlet-2.5-api-javadoc.noarch: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden jboss-servlet-2.5-api.noarch: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- jboss-servlet-2.5-api-javadoc (rpmlib, GLIBC filtered): jpackage-utils jboss-servlet-2.5-api (rpmlib, GLIBC filtered): java jpackage-utils Provides -------- jboss-servlet-2.5-api-javadoc: jboss-servlet-2.5-api-javadoc jboss-servlet-2.5-api: jboss-servlet-2.5-api mvn(javax.servlet:servlet-api) mvn(org.jboss.spec.javax.servlet:jboss-servlet-api_2.5_spec) osgi(org.jboss.spec.javax.servlet.jboss-servlet-api_2.5_spec) Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-18-x86_64 Command line :/usr/bin/fedora-review -v -n jboss-servlet-2.5-api
Fixed licensing and posted to same location: Spec URL: http://vakwetu.fedorapeople.org/jboss_servlet_2.5/jboss-servlet-2.5-api.spec SRPM URL: http://vakwetu.fedorapeople.org/jboss_servlet_2.5/jboss-servlet-2.5-api-1.0.1-2.fc17.src.rpm
Looks good now. ================ *** APPROVED *** ================
New Package SCM Request ======================= Package Name: jboss-servlet-2.5-api Short Description: The Java Servlet 2.5 API classes. Owners: vakwetu Branches: f19 InitialCC: mgoldman
New Package SCM Request ======================= Package Name: jboss-servlet-2.5-api Short Description: The Java Servlet 2.5 API classes Owners: vakwetu Branches: f19 InitialCC:
Git done (by process-git-requests).