Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 947824

Summary: process is getting crashed during dict_unserialize
Product: [Community] GlusterFS Reporter: vsomyaju
Component: coreAssignee: vsomyaju
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: pre-releaseCC: gluster-bugs, jdarcy, nsathyan, pkarampu
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.4.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 955466 (view as bug list) Environment:
Last Closed: 2013-07-24 17:09:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 918917, 955466    

Description vsomyaju 2013-04-03 11:28:45 UTC
Description of problem:
In dict_unserialize, if [(buf + vallen) > (orig_buf + size)],
process crash is taking place as the memdup is getting failed
                           

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:

Function should handle this case and process should not crash
Additional info:

Comment 1 Anand Avati 2013-04-12 07:21:13 UTC
COMMIT: http://review.gluster.org/4771 committed in release-3.4 by Anand Avati (avati) 
------
commit 432ce7e60fb58d3cbb019ab3159b7d393afaaed6
Author: Niels de Vos <ndevos>
Date:   Wed Apr 10 17:51:37 2013 +0200

    build: really disable fusermount if you say so
    
    There is no logic in configure.ac that provides a $disable_fusermount
    variable. So, use the $enable_fusermount variable instead.
    
    Follow-up-for: http://review.gluster.org/4773
    Change-Id: I81cdbd0045409d0036438d542ca6dc1934f784e4
    BUG: 948205
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/4803
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Sachidananda Urs <sacchi>
    Tested-by: Gluster Build System <jenkins.com>

Comment 2 Anand Avati 2013-04-12 07:22:08 UTC
COMMIT: http://review.gluster.org/4770 committed in release-3.3 by Anand Avati (avati) 
------
commit 2fbae10cc026c3a0dab82fdb47497f42f5683934
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Wed Apr 10 15:08:51 2013 -0400

    build: add BuildRequires librdmacm-devel
    
    See http://review.gluster.org/149
    
    Installed librdmacm-devel RPM on the build server.
    
    Change-Id: Iafb30e9cf1b15272b80329cc6141c7e92b43daee
    BUG: 950083
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/4804
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 3 Anand Avati 2013-07-04 06:03:02 UTC
REVIEW: http://review.gluster.org/4769 (dict: Put "goto out" in dict_unserialize to avoid process crash) posted (#2) for review on release-3.2 by venkatesh somyajulu (vsomyaju)

Comment 4 Anand Avati 2013-07-04 07:10:44 UTC
REVIEW: http://review.gluster.org/4769 (dict: Put "goto out" in dict_unserialize to avoid process crash) posted (#3) for review on release-3.2 by venkatesh somyajulu (vsomyaju)