Bug 947936 – Corosync doesn't detect non-existing user in uidgid config section

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 947936 - Corosync doesn't detect non-existing user in uidgid config section

Summary:	Corosync doesn't detect non-existing user in uidgid config section

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	corosync (Show other bugs)
Sub Component:
Version:	6.4
Hardware:	Unspecified Unspecified

Priority	low Severity low
Target Milestone:	rc
Target Release:	---
Assigned To:	Jan Friesse
QA Contact:	Cluster QE
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2013-04-03 11:04 EDT by Jan Friesse
Modified:	2013-11-20 23:33 EST (History)
CC List:	4 users (show)

See Also:
Fixed In Version:	corosync-1.4.1-16.el6
Doc Type:	Bug Fix
Doc Text:	Cause: Corosync configuration of uidgid section contains non-existing user or group. Consequence: Corosync doesn't display any error Fix: Properly check return value of getpwnam_r Result: Corosync display error message and exits with error code
Story Points:	---
Clone Of:
Environment:
Last Closed:	2013-11-20 23:33:50 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Proposed patch (4.17 KB, patch) 2013-04-03 11:04 EDT, Jan Friesse	no flags	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2013:1531	normal	SHIPPED_LIVE	corosync bug fix and enhancement update	2013-11-20 19:40:57 EST

Groups: None (edit)

Description Jan Friesse 2013-04-03 11:04:17 EDT

Created attachment 731215 [details]
Proposed patch

Description of problem:
corosync.conf:

...
uidgid {
    uid: nonexistinguser
}

No error is shown (even according to code it should)

Version-Release number of selected component (if applicable):
Flatiron

How reproducible:
100%
 
"Unit test":
https://github.com/jfriesse/csts/blob/master/tests/uidgid-parse.sh

Actual results:
Fail ($? != 0)

Expected results:
Success ($? == 0)

Additional info:

Comment 7 Jaroslav Kortus 2013-09-11 12:13:19 EDT

Verified with uidgid-parse.sh:

FAIL on corosync-1.4.1-15.el6.x86_64 (RHEL6.4)
PASS on corosync-1.4.1-17.el6.x86_64 (RHEL6.5)
Sep 11 18:10:06 virt-014 corosync[5211]:   [corosy] The 'nonexistinguid' user is not found in /etc/passwd, please read the documentation.
Sep 11 18:10:06 virt-014 corosync[5211]:   [MAIN  ] Corosync Cluster Engine exiting with status 1 at mainconfig.c:622.

Just a question: does it really check only /etc/passwd or is it also friendly to other system user entries (like ldap users) and the message is slightly misleading?

Comment 8 Jan Friesse 2013-09-12 04:15:58 EDT

It calls getpwnam_r, so second option is true.

Comment 10 errata-xmlrpc 2013-11-20 23:33:50 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1531.html

Note You need to log in before you can comment on or make changes to this bug.