Bug 948262 - Failed to enable irq remapping. You are vulnerable to irq-injection attacks intel_enable_irq_remapping+0x295/0x2a4()
Summary: Failed to enable irq remapping. You are vulnerable to irq-injection attacks ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 954068 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-04 12:41 UTC by Mads Kiilerich
Modified: 2013-07-03 23:50 UTC (History)
9 users (show)

Fixed In Version: kernel-3.9.4-300.fc19
Clone Of:
Environment:
Last Closed: 2013-05-26 02:57:42 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
dmesg (153.39 KB, application/octet-stream)
2013-04-04 12:41 UTC, Mads Kiilerich
no flags Details
dmesg MacBookPro9,2 (114.10 KB, text/plain)
2013-07-03 23:50 UTC, Chris Murphy
no flags Details

Description Mads Kiilerich 2013-04-04 12:41:47 UTC
Created attachment 731580 [details]
dmesg

[    0.258803] ftrace: allocating 24620 entries in 97 pages
[    0.271466] dmar: Host address width 36
[    0.271472] dmar: DRHD base: 0x000000fed90000 flags: 0x0
[    0.271516] dmar: IOMMU 0: reg_base_addr fed90000 ver 1:0 cap c0000020e60262 ecap f0101a
[    0.271522] dmar: DRHD base: 0x000000fed91000 flags: 0x1
[    0.271563] dmar: IOMMU 1: reg_base_addr fed91000 ver 1:0 cap c9008020660262 ecap f0105a
[    0.271569] dmar: RMRR base: 0x0000008b800000 end: 0x0000008f9fffff
[    0.271658] IOAPIC id 0 under DRHD base  0xfed91000 IOMMU 1
[    0.271661] HPET id 0 under DRHD base 0xfed91000
[    0.271665] [Firmware Bug]: ioapic 2 has no mapping iommu, interrupt remapping will be disabled
[    0.271669] Not enable interrupt remapping
[    0.271672] ------------[ cut here ]------------
[    0.271679] WARNING: at drivers/iommu/intel_irq_remapping.c:658 intel_enable_irq_remapping+0x295/0x2a4()
[    0.271684] Hardware name: MacBookPro10,1
[    0.271687] Failed to enable irq remapping.  You are vulnerable to irq-injection attacks.
[    0.271691] Modules linked in:
[    0.271696] Pid: 1, comm: swapper/0 Not tainted 3.9.0-0.rc4.git0.1.fc19.x86_64 #1
[    0.271700] Call Trace:
[    0.271707]  [<ffffffff81068df0>] warn_slowpath_common+0x70/0xa0
[    0.271713]  [<ffffffff81068e6c>] warn_slowpath_fmt+0x4c/0x50
[    0.271718]  [<ffffffff81f65a74>] intel_enable_irq_remapping+0x295/0x2a4
[    0.271724]  [<ffffffff81f65bcd>] irq_remapping_enable+0x1b/0x7b
[    0.271729]  [<ffffffff81f31e1c>] enable_IR+0x59/0x60
[    0.271733]  [<ffffffff81f32027>] enable_IR_x2apic+0x92/0x163
[    0.271738]  [<ffffffff81f33ed5>] default_setup_apic_routing+0x11/0x69
[    0.271743]  [<ffffffff81f2fd18>] nati
ve_smp_prepare_cpus+0x2b1/0x3b8
[    0.271750]  [<ffffffff81f20fd9>] kernel_init_freeable+0xbf/0x202
[    0.271756]  [<ffffffff816fd0d0>] ? rest_init+0x150/0x150
[    0.271761]  [<ffffffff816fd0de>] kernel_init+0xe/0x190
[    0.271765]  [<ffffffff8172726c>] ret_from_fork+0x7c/0xb0
[    0.271770]  [<ffffffff816fd0d0>] ? rest_init+0x150/0x150
[    0.271779] ---[ end trace b832e941e58917d2 ]---
[    0.272582] ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
[    0.282583] smpboot: CPU0: Intel(R) Core(TM) i7-3615QM CPU @ 2.30GHz (fam: 06, model: 3a, stepping: 09)

f19 kernel on f18

Comment 1 Josh Boyer 2013-05-08 19:13:08 UTC
*** Bug 954068 has been marked as a duplicate of this bug. ***

Comment 2 Neil Horman 2013-05-08 19:28:08 UTC
This is a BIOS bug.  See The error above:
[Firmware Bug]: ioapic 2 has no mapping iommu, interrupt remapping will be disabled

This systems ACPI tables (The SRAT Table specifically I think) didn't indicate which iommu serviced ioapic number 2 in this system.  Without an iommu, interrupt remapping can't work, and so it is being disabled.  Update your bios to fix this issue.

Comment 3 Mads Kiilerich 2013-05-09 12:07:23 UTC
This was a fully updated freedom-hating but quite common machine. Previous experience has set the expectations high, so I would expect Fedora to run on the machine without such error messages.

Yes, the kernel shows 3 lines of message that seems to say exactly the same ... but if it was the same thing then it would be a bug that it repeated it, so the obvious conclusion must be that it must be different messages.

But still:
After saying "Not enable interrupt remapping" it ends up in irq_remapping_enable. That looks like a bug to me.

I would expect failures with traces to be reserved for cases where the kernel detects what might look like a kernel bug. In this case it knows what is coming and should not show a trace.

Are you really sure this should be closed?

Comment 4 Neil Horman 2013-05-09 13:55:22 UTC
yes, I'm sure it should be closed.  You're misreading the stack trace.
this line:

[Firmware Bug]: ioapic 2 has no mapping iommu, interrupt remapping will be disabled

is printed from parse_ioapics_under_ir, which is called from intel_enable_irq_remapping 

This line:
WARNING: at drivers/iommu/intel_irq_remapping.c:658 intel_enable_irq_remapping+0x295/0x2a4()

Is printed from exactly where the line says it is printed, and is printed because the parse_ioapics_under_ir call failed.

The stack trace is printed at the end of intel_enable_irq_remapping, because we failed to enable irq remapping on a system that otherwise indicates support for the feature.

So, 3 error messages, 1 root cause, you have a bios that doesn't assign an iommu to an ioapic.  Contact your system vendor for a bios update, nothing we can do here

Comment 5 Josh Boyer 2013-05-09 14:06:07 UTC
(In reply to comment #4)
> So, 3 error messages, 1 root cause, you have a bios that doesn't assign an
> iommu to an ioapic.  Contact your system vendor for a bios update, nothing
> we can do here

FWIW, this is seen mostly on Apply Mac machines.  Contacting Apple isn't going to result in a fix for their EFI firmware.

Essentially, this is something people will have to live with.

Comment 6 Mads Kiilerich 2013-05-09 23:12:26 UTC
Well, ok. I guess someone at some point will implement a solution/workaround somehow - but that must go through upstream, then ;-)

Comment 7 Neil Horman 2013-05-10 13:50:32 UTC
The workaround is what your seeing your system do right now.  Because the system firmware can't determine which iommu belongs to one of the ioapics, the OS is disabling irq remapping, thats the workaround.  The fix is for apple to correct their in-firmware ACPI tables so that the mapping is known.

Comment 8 Mads Kiilerich 2013-05-13 09:27:04 UTC
Abrt offers to report this as a bug ... but it shouldn't if you don't care about it - see bug 962356.

Comment 9 Josh Boyer 2013-05-24 17:01:41 UTC
Upstream wound up sending a patch to change this from a WARN to a pr_warn so we don't get the oops backtrace.  I've added that patch to all branches.

Comment 10 Fedora Update System 2013-05-25 04:53:41 UTC
kernel-3.9.4-200.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/kernel-3.9.4-200.fc18

Comment 11 Fedora Update System 2013-05-25 12:08:28 UTC
kernel-3.9.4-300.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/kernel-3.9.4-300.fc19

Comment 12 Fedora Update System 2013-05-25 19:04:41 UTC
Package kernel-3.9.4-300.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing kernel-3.9.4-300.fc19'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-9214/kernel-3.9.4-300.fc19
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2013-05-26 02:57:42 UTC
kernel-3.9.4-200.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2013-05-27 03:22:16 UTC
kernel-3.9.4-300.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Chris Murphy 2013-07-03 23:50:38 UTC
Created attachment 768524 [details]
dmesg MacBookPro9,2

Also occurs with MacBookPro9,2.


Note You need to log in before you can comment on or make changes to this bug.