Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 949260 - resource_limits.template should be replaced as resource_limits.conf and mark it as config file in rpm spec file.
resource_limits.template should be replaced as resource_limits.conf and mark ...
Status: CLOSED ERRATA
Product: OpenShift Container Platform
Classification: Red Hat
Component: Containers (Show other bugs)
1.0.0
Unspecified Unspecified
medium Severity medium
: ---
: ---
Assigned To: Luke Meyer
libra bugs
:
Depends On: 949543
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-07 06:06 EDT by Johnny Liu
Modified: 2017-03-08 12 EST (History)
4 users (show)

See Also:
Fixed In Version: rubygem-openshift-origin-node-1.0.14-1
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 949543 (view as bug list)
Environment:
Last Closed: 2013-07-09 14:59:23 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2013:1032 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 1.2 Node Release Advisory 2013-07-09 18:57:19 EDT

  None (edit)
Description Johnny Liu 2013-04-07 06:06:48 EDT
Description of problem:
According to rubygem-openshift-origin-node.spec,
<--snip-->
# copy this file only if it doesn't already exist
if ! [ -f /etc/openshift/resource_limits.conf ]; then
  cp -f /etc/openshift/resource_limits.template /etc/openshift/resource_limits.conf
fi
<--snip-->

Refer to BZ#949072, once resource_limits.template is updated in latest package, yum update will not update resource_limits.conf itself. 
And resource_limits.template is not necessary to exist, maybe this file could be renamed to resource_limits.conf, and mark this file as a config file in spec file, so when yum update and run oo-diagnostic, could notice user some conf file has been updated.

Version-Release number of selected component (if applicable):
rubygem-openshift-origin-node-1.0.13-1.el6op.noarch

How reproducible:
Always

Steps to Reproduce:
1.Install a old rubygem-openshift-origin-node on a fresh system, resource_limits.conf is copied there.
2.Update a new rubygem-openshift-origin-node package, e.g: some values in resource_limits.template are updated.
3. 
  
Actual results:
resource_limits.conf is not updated, user can not notice some update already happened.

Expected results:
No resource_limits.template is installed, only resource_limits.conf is installed, once update happened, either of two choice could be met:
1. new conf file is applied, old conf file is saved to .rpmsave
2. old conf file is still used, new conf file is saved to .rpmnew
Then run oo-dignostic will warn user resource_limits config file is changed, need user to check update and merge them.

Additional info:
Comment 2 Luke Meyer 2013-04-11 08:35:39 EDT
Fixed with commit e8dd0794fcbb1e6b3e4fbe470bee7f69655c7d38
Built in rubygem-openshift-origin-node-1.0.14-1
Comment 3 Johnny Liu 2013-04-12 05:35:28 EDT
Verified this bug with rubygem-openshift-origin-node-1.0.14-1, and PASS.

# yum update rubygem-openshift-origin-node-1.0.14-1.el6op.noarch.rpm

# ll /etc/openshift/
total 184
drwxr-xr-x. 2 root root   4096 Mar 24 22:44 cartridges
-rw-r--r--. 1 root root   2564 Jan 14 21:44 node.conf
-rw-r--r--. 1 root root   1986 Mar 27 04:39 port-proxy.cfg
-rw-r--r--. 1 root root   2551 Apr 11 08:36 resource_limits.conf

# rpm -qf /etc/openshift/resource_limits.conf
rubygem-openshift-origin-node-1.0.14-1.el6op.noarch

# rpm -qc rubygem-openshift-origin-node-1.0.14-1.el6op
/etc/httpd/conf.d/000001_openshift_origin_node.conf
/etc/httpd/conf.d/000001_openshift_origin_node_servername.conf
/etc/openshift/node.conf
/etc/openshift/resource_limits.conf
Comment 5 errata-xmlrpc 2013-07-09 14:59:23 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2013-1032.html

Note You need to log in before you can comment on or make changes to this bug.