Bug 949484 - Underscores in tag names break tags
Summary: Underscores in tag names break tags
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: unspecified
Hardware: All
OS: All
urgent
medium
Target Milestone: ---
: 3.3.0
Assignee: Eli Mesika
QA Contact: Jiri Belka
URL:
Whiteboard: infra
Depends On:
Blocks: 988048
TreeView+ depends on / blocked
 
Reported: 2013-04-08 09:26 UTC by Daniele
Modified: 2018-12-03 18:36 UTC (History)
16 users (show)

Fixed In Version: is10
Doc Type: Bug Fix
Doc Text:
--no tech note required
Clone Of:
: 988048 (view as bug list)
Environment:
Last Closed: 2014-01-21 17:17:08 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
tag b_c associated with VMs vm1 & vm2 (32.95 KB, image/png)
2013-04-22 14:57 UTC, Eli Mesika
no flags Details
Tags screenshot (175.11 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2013-05-08 10:39 UTC, Richard Davis
no flags Details
requested sql query (11.62 KB, text/plain)
2013-06-28 14:50 UTC, Jiri Belka
no flags Details
postgresql-Mon.log.gz (83.24 KB, application/x-gzip)
2013-08-05 13:11 UTC, Jiri Belka
no flags Details
postgresql-Mon.log.gz from 3.3 (2.04 KB, application/x-gzip)
2013-08-05 13:24 UTC, Jiri Belka
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2014:0038 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Virtualization Manager 3.3.0 update 2014-01-21 22:03:06 UTC
oVirt gerrit 15594 0 None None None Never
oVirt gerrit 17266 0 None None None Never
oVirt gerrit 17819 0 None None None Never
oVirt gerrit 18390 0 None None None Never

Description Daniele 2013-04-08 09:26:00 UTC
Description of problem:
A Tab name which includes an underscore "_" (for instance "test_rhel") causes the items associated with that tab not to be displayed.
Removing the underscore allows them to be displayed.
It seems that underscores are not supported in Tab names but still allows them to be used.

Version-Release number of selected component (if applicable):
RHEVM 3.1.0-50

How reproducible:
Always.


Steps to Reproduce:
1. Create a Tag with a name that contains an underscore (_). Assign a few VM's to that Tag.
2. Click on the pin for the Tag and you will see that the VM's do not appear under that Tag 
3. Remove the _ from the name, the VM's will appear.
  
Actual results:
A Tab name which includes an underscore "_" (for instance "test_rhel") causes the items associated with that tab not to be displayed.

Expected results:
_ should not affect tab's ability to display VM's or it should not be allowed in the name

Additional info:
No screenshot. We'll replicate in-house.

Comment 1 Tim Hildred 2013-04-09 01:12:55 UTC
Hey Daniele,

I'm not sure why this is a docs bug. I'm going to move this to the webadmin, and see if it can be fixed in the software.

Comment 5 Eli Mesika 2013-04-22 14:57:52 UTC
Created attachment 738562 [details]
tag b_c associated with VMs vm1 & vm2

Was unable to reproduce 
Had created a b_c tag that was associated to VMs vm1 & vm2 

There is no problem also to run the query from the Search 
Vms:tag-b_c

and when clicking on the tag name vm1 & vm2 shows up correctly

Comment 6 Richard Davis 2013-05-08 10:38:15 UTC
Hi everyone.

I posted the original support case than generated this BZ.

I can provide a screenshot which show exactly the opposite of that experienced by Eli.  Not saying you are wrong, Eli. Only that I'm not seeing the same.

Comment 7 Richard Davis 2013-05-08 10:39:46 UTC
Created attachment 745199 [details]
Tags screenshot

Comment 9 Richard Davis 2013-05-21 10:03:36 UTC
Hi - any movement on this one ?

Comment 11 Sander Hoentjen 2013-05-27 17:07:16 UTC
I see the same with RHEV 3.1
This is on an upgraded system from RHEV 3.0, and with 3.0 it worked just fine.
I am on rhevm-3.1.0-53.el6ev.noarch

Comment 12 Sander Hoentjen 2013-05-27 17:08:23 UTC
Oh and by the way in the api this is also broken in 3.1

Comment 20 Jiri Belka 2013-06-28 14:50:08 UTC
Created attachment 766594 [details]
requested sql query

Comment 22 Jiri Belka 2013-07-01 09:07:44 UTC
I was able to reproduce as described in comment #0. The flow:

* tag 'tag_underscore'
* assing 'tag_underscore' to couple of VMs
* pinned => no vms visible (Search has: Vms: tag=tag_underscore)
* change the tag to 'tagunderscore'
* pinned => the VMs which have tag assigned are visible

3.3.0-0.5.master.el6ev (is3), thus the issue still exists in latest 3.3 build. Putting back to ASSIGNED.

Comment 25 Eli Mesika 2013-07-25 07:26:11 UTC
fixed in commit: b3a810d

Comment 29 Jiri Belka 2013-08-05 13:11:59 UTC
Created attachment 782836 [details]
postgresql-Mon.log.gz

requested query

Comment 30 Jiri Belka 2013-08-05 13:24:20 UTC
Created attachment 782838 [details]
postgresql-Mon.log.gz from 3.3

and now from 3.3 :)

Comment 33 Eli Mesika 2013-08-12 20:50:51 UTC
fixed in commit: 3aeef15

Comment 34 Jiri Belka 2013-08-16 13:38:00 UTC
ok, is10.

Comment 35 Charlie 2013-11-28 00:10:57 UTC
This bug is currently attached to errata RHEA-2013:15231. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag.

Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information:

* Cause: What actions or circumstances cause this bug to present.
* Consequence: What happens when the bug presents.
* Fix: What was done to fix the bug.
* Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore')

Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug.

For further details on the Cause, Consequence, Fix, Result format please refer to:

https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes 

Thanks in advance.

Comment 36 errata-xmlrpc 2014-01-21 17:17:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2014-0038.html


Note You need to log in before you can comment on or make changes to this bug.