RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 949969 - libvirt does not generate UUIDs compliant with RFC4122
Summary: libvirt does not generate UUIDs compliant with RFC4122
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Jiri Denemark
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-09 11:44 UTC by Milos Vyletel
Modified: 2014-04-04 20:58 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 963161 (view as bug list)
Environment:
Last Closed: 2014-04-04 20:58:05 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
upstream patch (1.57 KB, patch)
2013-04-09 11:44 UTC, Milos Vyletel
no flags Details | Diff

Description Milos Vyletel 2013-04-09 11:44:50 UTC
Created attachment 733169 [details]
upstream patch

Description of problem:
Libvirt mentions in documentation that UUIDs for guests must be RFC 4122 compliant but it does not follow this requirement itself. I have posted patch upstream that ensures that each UUID generated by libvirt during guest creation is RFC 4122 version 4 (pseudo)randomly generated.

Version-Release number of selected component (if applicable):
libvirt-0.10.2-18.el6_4.2.x86_64

How reproducible:
always

Steps to Reproduce:
1. create guest (virt-manager, virt-install...)
2. grep "<uuid>" /etc/libvirt/qemu/g1.xml
  
Actual results:
  <uuid>449bd261-614a-bdf8-a7b2-5ca5b6719512</uuid>

Expected results:

xxxxxxxx-xxxx-Axxx-Bxxx-xxxxxxxxxxxx

where
A is version defined in 4.1.3 of RFC
Msb0  Msb1  Msb2  Msb3   Version  Description
0     1     0     0        4     The randomly or pseudo-
                                 randomly generated version
                                 specified in this document.

B is variant defined in 4.1.1 of RFC
Msb0  Msb1  Msb2  Description
1     0     x    The variant specified in this document.


Additional info:
Upstream patch modified for RHEL 6.4 libvirt attached.

Comment 1 Jiri Denemark 2013-04-09 15:59:29 UTC
This is now fixed upstream by v1.0.4-97-g396c4d3:

commit 396c4d34f8875df0322d15151c2fb07121f5590e
Author: Milos Vyletel <milos.vyletel>
Date:   Mon Apr 8 14:10:54 2013 -0400

    Generate RFC4122 compliant UUIDs
    
    Even though http://libvirt.org/formatdomain.html#elementsMetadata
    states that it requires RFC4122 compliance UUIDs that are generated
    by virUUIDGenerate() are not. Following patch modifies generated
    UUIDs to conform to rules described in RFC.
    
    Signed-off-by: Milos Vyletel <milos.vyletel>

Comment 2 Jiri Denemark 2013-06-11 10:05:50 UTC
We decided not to rebase libvirt in RHEL 6.5 to avoid stability issues
we faced in 6.4. This bug has already been trivially fixed upstream but
it is not considered important enough to be backported to RHEL 6.5.

Thus I'm pushing this bug to RHEL 6.6 (and setting Upstream keyword to
indicate we have patches upstream) for now. If you don't agree with
this resolution, please, give us reasons which you think are strong
enough for us to reevaluate the decision not to backport patches for
this bug.

Comment 3 Milos Vyletel 2013-06-11 12:19:11 UTC
Fine with me. Thanks for looking at it.

Comment 6 RHEL Program Management 2014-04-04 20:58:05 UTC
Development Management has reviewed and declined this request.
You may appeal this decision by reopening this request.


Note You need to log in before you can comment on or make changes to this bug.