Bug 950639 - Review Request: c-ares19 - A library that performs asynchronous DNS operations
Summary: Review Request: c-ares19 - A library that performs asynchronous DNS operations
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jakub Hrozek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-10 14:34 UTC by Stephen Gallagher
Modified: 2013-05-01 19:23 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-01 19:23:36 UTC
Type: ---
Embargoed:
jhrozek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Stephen Gallagher 2013-04-10 14:34:51 UTC
Spec URL: http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19.spec
SRPM URL: http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19-1.9.1-4.fc18.1.src.rpm
Description:
c-ares is a C library that performs DNS requests and name resolves
asynchronously. c-ares is a fork of the library named 'ares', written
by Greg Hudson at MIT

Fedora Account System Username: sgallagh

Extra notes: This package is intended for EPEL 6 only. It will immediately be dead.packaged in Rawhide.

Comment 1 Jakub Hrozek 2013-04-10 15:32:49 UTC
koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5238142

rpmlint output:
c-ares19-debuginfo.x86_64: E: debuginfo-without-sources
c-ares19-devel.x86_64: W: no-documentation

the debuginfo-without-sources sounds wrong to me, on my F-18 the debuginfo contains the sources correctly..

Comment 2 Stephen Gallagher 2013-04-10 16:49:01 UTC
SPEC: http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19.spec
SRPM: http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19-1.9.1-4.fc18.1.src.rpm
KOJI: http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19-1.9.1-4.fc18.1.src.rpm

So the reason for the debuginfo issue was that when I added autoreconf -if (to process my changes to Makefile.am), it was overwriting the changes made by the original patch c-ares-1.7.5-optflags.patch (which were written directly into the configure script instead of configure.ac or its dependencies).

I added a patch that makes an equivalent modification to the m4/cares-compilers.m4 and now it's producing appropriate debuginfo output (as well as building with all the correct flags).

Jakub, you may want to convert to this approach in your Fedora package as well, so you can run autoreconf in it.

Comment 3 Jakub Hrozek 2013-04-11 15:22:40 UTC
Thank you for the autoconf patch, I'll start using it in Fedora c-ares package.

Here is the correct link to the new package:
http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19-1.9.1-4.fc18.2.src.rpm

Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5242026

rpmlint output:
c-ares19.ppc64: E: changelog-time-in-future 2013-04-12
c-ares19-debuginfo.ppc64: E: changelog-time-in-future 2013-04-12
c-ares19-devel.ppc64: E: changelog-time-in-future 2013-04-12
c-ares19-devel.ppc64: W: no-documentation
3 packages and 0 specfiles checked; 3 errors, 1 warnings.

The changelog in future is a simple specfile change that would be nice to get done.
The no-documentation warning is OK, the man pages are removed on purpse.

* The package is named correctly given it's the 1.9 version
* Builds on all supported architectures (see the koji link)
* Smoke testing (a simple C program linked against c-ares19) worked fine
* Devel files are in the -devel package, file ownership seems sane
* Source tarballs' MD5 sums match:
  ** RPM      - 389db4917a3b58c4ce4ebfe961fd84c4
  ** upstream - 389db4917a3b58c4ce4ebfe961fd84c4

Fix the date in the changelog and I'll approve :-)

Comment 5 Jakub Hrozek 2013-04-11 15:46:58 UTC
rpmlint output:
c-ares19-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

My only comment was fixed, so this package is APPROVED.

Comment 6 Stephen Gallagher 2013-04-11 15:49:06 UTC
New Package SCM Request
=======================
Package Name: c-ares19
Short Description: A library that performs asysnchronous DNS operations
Owners: sgallagh
Branches: el6
InitialCC:

Comment 7 Gwyn Ciesla 2013-04-11 16:18:36 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2013-04-11 18:12:50 UTC
nodejs-0.10.3-2.el6.1,libuv-0.10.3-2.el6,http-parser-2.0-4.20121128gitcd01361.el6,c-ares19-1.9.1-4.el6.3 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/nodejs-0.10.3-2.el6.1,libuv-0.10.3-2.el6,http-parser-2.0-4.20121128gitcd01361.el6,c-ares19-1.9.1-4.el6.3

Comment 9 Fedora Update System 2013-04-13 00:13:41 UTC
nodejs-0.10.3-2.el6.1, libuv-0.10.3-2.el6, http-parser-2.0-4.20121128gitcd01361.el6, c-ares19-1.9.1-4.el6.3 has been pushed to the Fedora EPEL 6 testing repository.

Comment 10 Fedora Update System 2013-04-16 16:39:03 UTC
libuv-0.10.4-1.el6, nodejs-0.10.4-1.el6, http-parser-2.0-4.20121128gitcd01361.el6, c-ares19-1.9.1-4.el6.3 has been pushed to the Fedora EPEL 6 testing repository.

Comment 11 Fedora Update System 2013-05-01 19:23:38 UTC
libuv-0.10.4-1.el6, nodejs-0.10.4-1.el6, http-parser-2.0-4.20121128gitcd01361.el6, c-ares19-1.9.1-4.el6.3 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.