951070 – [NetKVM] Fix debug printouts line endings

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 951070 - [NetKVM] Fix debug printouts line endings

Summary: [NetKVM] Fix debug printouts line endings

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	virtio-win
Sub Component:
Version:	6.5
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	rc
Target Release:	---
Assignee:	Yvugenfi@redhat.com
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2013-04-11 12:09 UTC by Yvugenfi@redhat.com
Modified:	2013-12-06 07:45 UTC (History)
CC List:	10 users (show)
Fixed In Version:	virtio-win-prewhql-0.1-59
Doc Type:	Bug Fix
Doc Text:	Cause: Some of the debug prints where printed out without line end. Consequence: Cumbersome debug logs from the guest. Fix: Add line end to debug prints. Result: Clean debug logs from the driver.
Clone Of:
Environment:
Last Closed:	2013-11-22 00:08:23 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2013:1729	0	normal	SHIPPED_LIVE	virtio-win bug fix and enhancement update	2013-11-21 00:39:25 UTC

Description Yvugenfi@redhat.com 2013-04-11 12:09:13 UTC

Description of problem:

In some cases debug printout is "glued" because of lack of EOL.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Yvugenfi@redhat.com 2013-04-11 12:21:26 UTC

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=3a177b1430607d6f66c26f2462b8bd0e7da51797

Comment 2 Yvugenfi@redhat.com 2013-04-11 12:59:13 UTC

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=a265fcf63f8e418cd8fc2ea8ea84324d59fa267d/

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=004d39904ead81de467414b53b3522aceb0cfe4b

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=502735f972fd5b28a22879c7b9f091d37633fd73

Comment 3 Mike Cao 2013-04-12 02:49:12 UTC

Pls provide how QE to test it ,

Thanks,
Mike

Comment 4 Mike Cao 2013-04-18 06:28:54 UTC

I think QE can use debug view to test this issue 
1.Start VM in the guest ,open debug view ,enable kernel debug
2.change netkvm macaddress in the guest (use a wrong macaddress)
3.check the output of debug view

Comment 5 Yvugenfi@redhat.com 2013-04-18 07:46:07 UTC

Hello Mike,

The case you described is good enough.

Another test case:

Disable\enable the device.

Check that the output in DbgView is not "glued" to huge lines.

Best regards,
Yan.

Comment 6 lijin 2013-05-06 10:29:29 UTC

Reproduced this issue on virtio-win-prewhql-0.1-58
Verified this issue on virtio-win-prewhql-0.1-59

Steps:
1.boot a win7-32 guest with virtio-net-pci
2.open debug view in guest and enable kernel debug
3.Disable\enable the virtio-net-pci in Device Manager.

Actual Results:
on virtio-win-prewhql-0.1-58, printout of DbgView is "glued";
on virtio-win-prewhql-0.1-59 verion ,printout of DbgView is not "glued".

Based on above ,this issue has been fixed already .

Comment 7 Yvugenfi@redhat.com 2013-05-06 10:38:58 UTC

Please move to verified according to comment #6.

Comment 8 Mike Cao 2013-05-06 10:53:09 UTC

Move status to VERIFIED according to comment #6

Comment 9 lijin 2013-05-07 02:17:22 UTC

(In reply to comment #6)
> Reproduced this issue on virtio-win-prewhql-0.1-58
> Verified this issue on virtio-win-prewhql-0.1-59
> 
> Steps:
> 1.boot a win7-32 guest with virtio-net-pci
> 2.open debug view in guest and enable kernel debug
> 3.Disable\enable the virtio-net-pci in Device Manager.
> 
> Actual Results:
> on virtio-win-prewhql-0.1-58, printout of DbgView is "glued";
  One detail example:during disable/enable,one of the debug information display as following:
00000498	2:08:22.281 AM	[ConfigureMSIXVectors] Using message 1 for TX queue[ConfigureMSIXVectors] Using message 2 for controls[ApplyOffloadConfiguration] Requested: V4:IPCS=TxRx,TCPCS=TxRx,UDPCS=TxRx V6:TCPCS=TxRx,UDPCS=TxRx[SetOffloadField] IN TxIPChecksum TX: current=1 Supported TxRx Requested TxRx[SetOffloadField] OUT TxIPChecksum TX: new=1 (accepted)[SetOffloadField] IN TxTCPChecksum TX: current=1 Supported TxRx Requested TxRx[SetOffloadField] OUT TxTCPChecksum TX: new=1 (accepted)[SetOffloadField] IN TxUDPChecksum TX: current=1 Supported TxRx Requested TxRx[SetOffloadField] OUT TxUDPChecksum TX: new=1 (accepted)[SetOffloadField] IN RxIPChecksum RX: current=1 Supported TxRx Requested TxRx[SetOffloadField] OUT RxIPChecksum RX: new=1 (accepted)[SetOffloadField] IN RxTCPChecksum RX: current=1 Supported TxRx Requested TxRx[SetOffloadField] OUT RxTCPChecksum RX: new=1 (accepted)[SetOffloadField] IN RxUDPChecksum RX: current=1 Supported TxRx Requested TxRx
 
> on virtio-win-prewhql-0.1-59 verion ,printout of DbgView is not "glued".
  printout is seperated,the message displays as following:
00000181	2:11:20.500 AM	[ConfigureMSIXVectors] Using MSIX interrupts (3 messages, irql 10)	
00000182	2:11:20.500 AM	[ConfigureMSIXVectors] MSIX message0=000049B0=>FEE0300C	
00000183	2:11:20.500 AM	[ConfigureMSIXVectors] MSIX message1=000049A0=>FEE0300C	
00000184	2:11:20.500 AM	[ConfigureMSIXVectors] MSIX message2=00004990=>FEE0300C	
00000185	2:11:20.500 AM	[ConfigureMSIXVectors] Using message 0 for RX queue	
00000186	2:11:20.500 AM	[ConfigureMSIXVectors] Using message 1 for TX queue	
00000187	2:11:20.500 AM	[ConfigureMSIXVectors] Using message 2 for controls	
00000188	2:11:20.500 AM	[ApplyOffloadConfiguration] Requested: V4:IPCS=TxRx,TCPCS=TxRx,UDPCS=TxRx V6:TCPCS=TxRx,UDPCS=TxRx	
00000189	2:11:20.500 AM	[SetOffloadField] IN TxIPChecksum TX: current=-1 Supported TxRx Requested TxRx	
00000190	2:11:20.500 AM	[SetOffloadField] OUT TxIPChecksum TX: new=1 (accepted)	
00000191	2:11:20.500 AM	[SetOffloadField] IN TxTCPChecksum TX: current=-1 Supported TxRx Requested TxRx	
00000192	2:11:20.500 AM	[SetOffloadField] OUT TxTCPChecksum TX: new=1 (accepted)	
00000193	2:11:20.500 AM	[SetOffloadField] IN TxUDPChecksum TX: current=-1 Supported TxRx Requested TxRx	
00000194	2:11:20.500 AM	[SetOffloadField] OUT TxUDPChecksum TX: new=1 (accepted)	
00000195	2:11:20.500 AM	[SetOffloadField] IN RxIPChecksum RX: current=-1 Supported TxRx Requested TxRx	
00000196	2:11:20.500 AM	[SetOffloadField] OUT RxIPChecksum RX: new=1 (accepted)	
00000197	2:11:20.500 AM	[SetOffloadField] IN RxTCPChecksum RX: current=-1 Supported TxRx Requested TxRx	
00000198	2:11:20.500 AM	[SetOffloadField] OUT RxTCPChecksum RX: new=1 (accepted)	
00000199	2:11:20.500 AM	[SetOffloadField] IN RxUDPChecksum RX: current=-1 Supported TxRx Requested TxRx	
00000200	2:11:20.500 AM	[SetOffloadField] OUT RxUDPChecksum RX: new=1 (accepted)	
00000201	2:11:20.500 AM	[SetOffloadField] IN TxTCPv6Checksum TX: current=-1 Supported TxRx Requested TxRx	
00000202	2:11:20.500 AM	[SetOffloadField] OUT TxTCPv6Checksum TX: new=1 (accepted)	
00000203	2:11:20.500 AM	[SetOffloadField] IN TxUDPv6Checksum TX: current=-1 Supported TxRx Requested TxRx	
00000204	2:11:20.500 AM	[SetOffloadField] OUT TxUDPv6Checksum TX: new=1 (accepted)	
00000205	2:11:20.500 AM	[SetOffloadField] IN RxTCPv6Checksum RX: current=-1 Supported TxRx Requested TxRx	
00000206	2:11:20.500 AM	[SetOffloadField] OUT RxTCPv6Checksum RX: new=1 (accepted)	
00000207	2:11:20.500 AM	[SetOffloadField] IN RxUDPv6Checksum RX: current=-1 Supported TxRx Requested TxRx


> Based on above ,this issue has been fixed already .

Comment 15 errata-xmlrpc 2013-11-22 00:08:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1729.html

Note You need to log in before you can comment on or make changes to this bug.