Bug 951456 - mate-keyring-1.5.1-1 breaks keyring authorization in MATE
Summary: mate-keyring-1.5.1-1 breaks keyring authorization in MATE
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mate-keyring
Version: 18
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-12 09:32 UTC by Wolfgang Ulbrich
Modified: 2013-04-24 01:31 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-04-20 19:27:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Wolfgang Ulbrich 2013-04-12 09:32:23 UTC
Description of problem:
With mate-keyring-1.5.1-1 the keyring framwork doesn't read any user login informations which are stored in ~/.config/mate/keyrings after login.
In result you're everytime to be forced to enter a password if you use a ssh keyring for example.
The reason for this issue is your wrong spec file.

%configure \
   --disable-static                    \
   --with-gtk=2.0                      \
   --disable-schemas-compile           \
   --enable-gcov                       \
   --libexecdir=/usr/libexec           \
   --with-pam-dir=%{_sysconfdir}/pam.d \
   --with-root-certs=%{_sysconfdir}/pki/tls/certs

Why do you thing that %{_sysconfdir}/pam.d is the right directory for pam_mate_keyring.so?
You're are the only one who installed a lib in this dierectory.
The right place is /usr/lib64/security or /lib64/security.
If you you don't know what you doing let the spec file in state like it was from Leigh Scott, take a look at gnome-keyring spec file or use fedora packager guidelines.
https://fedoraproject.org/wiki/Packaging:Guidelines#Filesystem_Layout

Comment 1 Stefano Karapetsas 2013-04-12 09:54:28 UTC
Wolfgang,
we all are here to improve MATE, I hope.
Please be more respectful on bug reports.

Comment 2 Wolfgang Ulbrich 2013-04-12 10:06:03 UTC
Stefano,
installing a lib in %{_sysconfdir}/pam.d is nothing what deserves respect.

Comment 3 Rex Dieter 2013-04-12 12:13:58 UTC
Wolfgang, there's an old saying "If you can't say anything nice, don't say anything at all".

Reporting this bug and it's consequences is OK and encouraged, of course...  But, questioning someone's motives or competency (that's my impression, even if it may not be your intention), is certainly *not* OK.  Please be mindful of the sometimes subtle difference.

I'll take care of fixing this bug.

Comment 4 Rex Dieter 2013-04-12 12:19:38 UTC
Breakage occurred in commit 709ecf467c0938797eeb86010e360b3a8c94bd07

"Add patch to build for f19 which include various bugfix
 commits from upstream, minor specfile tweaks"

Again, please be mindful to make commits smaller and more self contained.  this was so big, it was difficult to follow all the changes and notice.


Dan, I see 1.6.0 already in master/ branch, is your intention to push that down to f18 too soon, or should I backport this fix separately to 1.5.1 in f18 branch? (answer here, or poke me on irc)

Comment 5 Rex Dieter 2013-04-12 13:27:49 UTC
In that spirit, I failed to follow my own advice, and lumped a whole bunch of stuff into a single commit,

%changelog
* Fri Apr 12 2013 Rex Dieter <rdieter> - 1.6.0-2
- %%build: revert back to --with-pam-dir=/%%{_lib}/security/ (#951456)
- %%build: drop --enable-gcov (developer-only option, not needed here)
- %%files: track abi (lib sonames) closer
- drop unused patches
- -pam: drop extra %%doc stuff (included already in Required base pkg)
- -devel: drop explicit Requires: libmatekeyring-devel
- use %%caps(cap_ipc_lock=ep) .../mate-keyring-daemon (see also #668831)

Comment 6 Wolfgang Ulbrich 2013-04-12 13:41:47 UTC
Rex,
I am glad to have caught your attention ;)
Could you pls also fix https://bugzilla.redhat.com/show_bug.cgi?id=896130 ,
to get the whole mate keyring framework working with lightdm?

Comment 7 Fedora Update System 2013-04-13 21:05:51 UTC
mate-keyring-1.6.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/mate-keyring-1.6.0-2.fc19

Comment 8 Fedora Update System 2013-04-13 21:16:04 UTC
mate-keyring-1.5.1-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mate-keyring-1.5.1-2.fc18

Comment 9 Fedora Update System 2013-04-13 21:16:51 UTC
mate-keyring-1.5.1-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-keyring-1.5.1-2.fc17

Comment 10 Fedora Update System 2013-04-14 19:15:54 UTC
Package mate-keyring-1.6.0-2.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing mate-keyring-1.6.0-2.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-5650/mate-keyring-1.6.0-2.fc19
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2013-04-20 19:27:06 UTC
mate-keyring-1.6.0-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2013-04-24 01:29:51 UTC
mate-keyring-1.5.1-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2013-04-24 01:31:24 UTC
mate-keyring-1.5.1-2.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.