Bug 951557 - exo installs generic icons to hicolor/*/apps
Summary: exo installs generic icons to hicolor/*/apps
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: exo
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-12 13:17 UTC by Rex Dieter
Modified: 2016-07-20 11:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-19 10:09:17 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
KDE Software Compilation 317138 0 None None None Never
Xfce 9992 0 None None None Never

Description Rex Dieter 2013-04-12 13:17:58 UTC
We'd noticed exo's applications-other.png showing up recently in kde's application menu, thought it was a kde bug,
https://bugs.kde.org/show_bug.cgi?id=317138

turns out we only started seeing it due to a bugfix so kde more closely follows the icon spec.

To quote Aaron in the upstream bug:

-------------------------------

The problem is that someone installed an icon in apps/ and then expected it to be overridden. See:

   http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

On the Applications context in apps/:

"Icons that describe what an application is, for use in the Programs menu, window decorations, and the task list. These may or may not be generic depending on the application and its purpose. Applications which are to be considered part of the base desktop, such as the calculator or terminal, should use the generic icons specified in this specification, while more advanced applications such as web browsers and office applications should use branded icons which still give the user an idea of what function the application provides."

And from the documentation on resolving via fallbacks:

"The “Applications” context should not use this method of falling back to more generic icons. An application must either use a generic application icon name provided by this specification, or install an icon named the same as the executable for running the application. A generic desktop application included with the desktop suite, such as the calculator or terminal application, should use the generic names provided by this specification, as described above in the “Applications” context description."

I'm not a huge fan of that specification and think it could have been done a lot better, but that's an academic discussion since this is what is in use.

When an icon is requested by kdelibs, it only knows the name of the icon being requested. It has not other information to go by; in theory we could require than any time an icon is being requested that will be used to represent an application that some different call is made (e.g. by adding some Context enum somewhere). That would also be fragile as it would require patching every use in any place that uses such icons .. meh.

Anyways, fix the installation and don't pollute the apps/ directory. :)

------------------------------------------

Comment 1 Rex Dieter 2013-04-12 13:19:46 UTC
In particular, 

$ rpm -q exo
exo-0.10.2-1.fc18.x86_64

$ rpm -ql exo | grep hicolor
/usr/share/icons/hicolor/24x24/apps/internet-mail.png
/usr/share/icons/hicolor/24x24/apps/preferences-desktop-default-applications.png
/usr/share/icons/hicolor/48x48/apps/applications-internet.png
/usr/share/icons/hicolor/48x48/apps/applications-other.png
/usr/share/icons/hicolor/48x48/apps/internet-mail.png
/usr/share/icons/hicolor/48x48/apps/preferences-desktop-default-applications.png

Comment 2 Diego 2013-04-12 14:45:37 UTC
Upstream bug:
https://bugzilla.xfce.org/show_bug.cgi?id=9992

Comment 3 Fedora End Of Life 2013-12-21 12:47:33 UTC
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Rex Dieter 2013-12-21 12:49:32 UTC
pretty sure still valid for f19+, rebasing

Comment 5 Fedora End Of Life 2015-01-09 17:53:05 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Diego 2015-01-12 09:51:16 UTC
Still applies to newer Fedoras.

Comment 7 Jaroslav Reznik 2015-03-03 14:54:47 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 8 Fedora End Of Life 2016-07-19 10:09:17 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 9 Diego 2016-07-20 08:16:47 UTC
Still applies, please reopen.

Comment 10 Rex Dieter 2016-07-20 11:13:46 UTC
Not sure if it's worth keeping the bug open downstream, there's an upstream one already tracking the issue:
https://bugzilla.xfce.org/show_bug.cgi?id=9992


Note You need to log in before you can comment on or make changes to this bug.