Red Hat Bugzilla – Bug 951576
prepareForShutdown is not called when connection to libvirt is broken with event: libvirtError: internal error client socket is closed
Last modified: 2014-01-01 03:10:38 EST
The fix did not work we have to make a new one.
*** Bug 951571 has been marked as a duplicate of this bug. ***
Merged u/s to master branch as: http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=commit;h=1817e6fe2a1ec873755d871296c2fb61fdf5d888
Checked on RHEVM-3.1 - SI28: rhevm-3.1.0-52.el6ev.noarch vdsm-4.10.2-1.10.el6ev.x86_64 libvirt-0.10.2-18.el6_4.4.x86_64 sanlock-2.6-2.el6.x86_64 qemu-kvm-rhev-0.12.1.2-2.355.el6_4.2.x86_64 prepareForShutdown is called when connection to libvirt is broken after restart to libvirtd. Thread-354::ERROR::2013-04-22 14:46:28,767::libvirtconnection::102::vds::(wrapper) connection to libvirt broken. taking vdsm down. ecode: 1 edom: 7 Thread-354::INFO::2013-04-22 14:46:29,691::vmChannels::187::vds::(stop) VM channels listener was stopped. Thread-354::DEBUG::2013-04-22 14:46:29,692::task::568::TaskManager.Task::(_updateState) Task=`c1716d92-c0c0-40ec-9f6c-c999d80c8975`::moving from state init -> state preparing Thread-354::INFO::2013-04-22 14:46:29,692::logUtils::37::dispatcher::(wrapper) Run and protect: prepareForShutdown(options=None)
*** Bug 955432 has been marked as a duplicate of this bug. ***
I was manage to reproduce this bug. It is only reproduces with no running vms on the setup. moving back to ASSIGN.
Created attachment 741873 [details] logs vdsm.log and libvirtd.log attached.
this particular one is happening because netinfo.py is not using libvirtconnection wrapper. In reality this should not be a big deal as if there is a more persistent issue/libvirt takes time to restart it will eventually trigger the shutdown elsewhere - most likely in statistics thread when there are existing VMs.
Was there any impact? If not I'd close it anyway. I see the libvirt connection is directly used only in network-related functions. Dan, should we be using the wrapper instead or is this ok?
Since the main scenario of this bug does not reproduce, I'm moving it back to VERIFIED. I'll open a new BZ for the secondary scenario (killing libvird with SIGABRT without any running VMs)
opened BZ# 958367 for the secondary scenario (killing libvird with SIGABRT without any running VMs)
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0774.html