Spec URL: http://labs.linuxnetz.de/bugzilla/perl-DBD-Firebird.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/perl-DBD-Firebird-1.11-1.src.rpm Description: DBD::Firebird is a Perl module that works with the DBI module to provide access to Firebird databases. This package will be imported to EPEL 6 and of course to all active Fedora branches. EPEL 5 is not possible as firebird in EPEL 5 is too old.
Taking the review.
Missing buildtime deps: perl(base), ./inc/FirebirdMaker.pm:6, ./t/TestFirebird.pm:22, ./TestFirebirdEmbedded.pm:17 perl(Carp), ./Makefile.PL:63, ./Firebird.pm:13, ./Firebird.pm:163, ./t/TestFirebirdEmbedded.pm:8, perl(constant), ./t/TestFirebird.pm:31-33, ./t/TestFirebirdEmbedded.pm:27-28, ./t/dbi-table_info.t:17,42 perl(Data::Dumper), ./t/91-txinfo.t:7 perl(DBI::DBD), ./Makefile.PL:184 perl(Encode), ./t/75-utf8.t:17 perl(Exporter), ./inc/FirebirdMaker.pm:6, ./Firebird.pm:17, ./lib/DBD/Firebird/TypeInfo.pm:13, ./t/TestFirebird.pm:22, ./t/TestFirebirdEmbedded.pm:17 perl(File::Temp), ./t/TestFirebird.pm:18, ./t/TestFirebirdEmbedded.pm:13 perl(Getopt::Long), ./Makefile.PL:66 perl(lib), most tests (+ Config, DynaLoader, File::Basename, File::Spec, Math::BigFloat, POSIX, strict, utf8, vars, warnings; see the same comment in DBD::InterBase) Perl v5.10.1 is required (./Firebird.pm:9), therefore your perl >= 5.8.1 BR is incorrect. This is another reason why this can't go to EPEL5. I also think specifying the version here is not necessary. %defattr is not required, could be dropped. The same for line 35. You could add the 'eg' directory to %doc. Since this isn't going to EPEL5, drop the Buildroot-related stuff. It's not needed. (lines 17, 31, 42, and 43)
Thank you for taking the review. I have applied all suggested changes, except the 'eg' directory - because building of DBD::FirebirdEmbed doesn't work from my point of view (and it is IMHO not needed anyway). Spec URL: http://labs.linuxnetz.de/bugzilla/perl-DBD-Firebird.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/perl-DBD-Firebird-1.11-2.src.rpm
Ok, everything's fixed. Approving.
Thank you very much for the package review! New Package SCM Request ======================= Package Name: perl-DBD-Firebird Short Description: A Firebird interface for perl Owners: robert Branches: el6 f17 f18 f19 InitialCC:
Git done (by process-git-requests).
perl-DBD-Firebird-1.11-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-DBD-Firebird-1.11-2.fc19
perl-DBD-Firebird-1.11-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-DBD-Firebird-1.11-2.fc18
perl-DBD-Firebird-1.11-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-DBD-Firebird-1.11-2.fc17
perl-DBD-Firebird-1.11-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-DBD-Firebird-1.11-2.el6
perl-DBD-Firebird-1.11-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
perl-DBD-Firebird-1.11-2.fc19 has been pushed to the Fedora 19 stable repository.
perl-DBD-Firebird-1.11-2.fc17 has been pushed to the Fedora 17 stable repository.
perl-DBD-Firebird-1.11-2.fc18 has been pushed to the Fedora 18 stable repository.
perl-DBD-Firebird-1.11-2.el6 has been pushed to the Fedora EPEL 6 stable repository.