Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 952122

Summary:	rpms contains useless provides for xlator .so files and private libraries
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	build	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	mainline	CC:	gluster-bugs, kkeithle, morten
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.4.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-24 17:39:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Niels de Vos 2013-04-15 09:01:57 UTC

Description of problem:
The generated rpms contain incorrect provides information:

# rpm -q --provides glusterfs
addr.so.0()(64bit)  
afr.so.0()(64bit)  
client.so.0()(64bit)  
...
dht.so.0()(64bit)  
error-gen.so.0()(64bit)  
...
index.so.0()(64bit)  
io-cache.so.0()(64bit)  
io-stats.so.0()(64bit)  
io-threads.so.0()(64bit)  
... 
locks.so.0()(64bit)  
login.so.0()(64bit)  
mac-compat.so.0()(64bit)  
marker.so.0()(64bit)  
md-cache.so.0()(64bit)  
nufa.so.0()(64bit)  
posix-acl.so.0()(64bit)  
pump.so.0()(64bit)  
quick-read.so.0()(64bit)  
quiesce.so.0()(64bit)  
quota.so.0()(64bit)  
read-ahead.so.0()(64bit)  
read-only.so.0()(64bit)  
rot-13.so.0()(64bit)  
socket.so.0()(64bit)  
stripe.so.0()(64bit)  
switch.so.0()(64bit)  
symlink-cache.so.0()(64bit)  
trace.so.0()(64bit)  
worm.so.0()(64bit)  
write-behind.so.0()(64bit)  
...

The other rpms are affected in the same way.

These provides are caused by the xlator .so files. The xlators and private
libraries should be skipped while scanning for provides:
- https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

Comment 1 Anand Avati 2013-04-15 09:07:11 UTC

REVIEW: http://review.gluster.org/4823 (rpm: remove useless provides for xlator .so files and private libraries) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2013-04-15 15:56:57 UTC

REVIEW: http://review.gluster.org/4823 (rpm: remove useless provides for xlator .so files and private libraries) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 3 Anand Avati 2013-04-16 03:50:45 UTC

COMMIT: http://review.gluster.org/4823 committed in master by Anand Avati (avati) 
------
commit 9eb8fc771b32c0601969537ad7135edd89e49cf9
Author: Niels de Vos <ndevos>
Date:   Mon Apr 15 11:02:19 2013 +0200

    rpm: remove useless provides for xlator .so files and private libraries
    
    xlator .so files and private libraries should be skipped while scanning
    for provides:
    - https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
    
    This prevents automatic generated provides like these in the glusterfs,
    glustrefs-fuse and glusterfs-server packages:
    - addr.so.0()(64bit)
    - afr.so.0()(64bit)
    - client.so.0()(64bit)
    - dht.so.0()(64bit)
    - ...
    
    BUG: 952122
    Change-Id: Icd08925eb1826f3593129e7c19de83528f7b6301
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/4823
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 4 Morten Johansen 2013-04-17 12:26:12 UTC

Tried updating to glusterfs-3.3.1-12.el6.x86_64.rpm from http://repos.fedorapeople.org/repos/kkeithle/glusterfs/epel-6/x86_64/ today.

Getting dependency errors on update (and install):

Error: Package: glusterfs-3.3.1-12.el6.x86_64 (epel-glusterfs)
           Requires: addr.so.0()(64bit)
           Removing: glusterfs-3.3.1-1.el6.x86_64 (@glusterfs-epel)
               addr.so.0()(64bit)
           Updated By: glusterfs-3.3.1-12.el6.x86_64 (epel-glusterfs)
               Not found
           Available: glusterfs-3.2.7-1.el6.x86_64 (epel)
               addr.so.0()(64bit)

One per xlator .so file it seems.

This bugfix is the only thing I could find that might cause this. Can do additional testing if requested.

Comment 5 Niels de Vos 2013-04-17 13:17:00 UTC

(In reply to comment #4)
> Tried updating to glusterfs-3.3.1-12.el6.x86_64.rpm from
> http://repos.fedorapeople.org/repos/kkeithle/glusterfs/epel-6/x86_64/ today.
> 
> Getting dependency errors on update (and install):

Ah, there was a short overlap in including the fix in upstream and the fedora
package. I have now started a scratch-build (files will be removed automatically)
that includes the latest change:
- koji.fedoraproject.org/koji/taskinfo?taskID=5265235

Could you test those packages and let us know if that works for you?

Comment 6 Morten Johansen 2013-04-17 13:32:26 UTC

(In reply to comment #5)
> Ah, there was a short overlap in including the fix in upstream and the fedora
> package. I have now started a scratch-build (files will be removed
> automatically)
> that includes the latest change:
> - koji.fedoraproject.org/koji/taskinfo?taskID=5265235
> 
> Could you test those packages and let us know if that works for you?

The newly build RPM packages glusterfs and glusterfs-fuse work fine.
I am assuming the other packages do as well - I have no good way to test that right now.

Cheers!

Comment 7 Niels de Vos 2013-05-06 10:30:11 UTC

http://repos.fedorapeople.org/repos/kkeithle/glusterfs contains updated packages too now.