Bug 952141 - Review Request: python-mccabe - McCabe complexity checker
Summary: Review Request: python-mccabe - McCabe complexity checker
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pierre-YvesChibon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 839056
TreeView+ depends on / blocked
 
Reported: 2013-04-15 09:44 UTC by Matěj Cepl
Modified: 2018-04-11 07:12 UTC (History)
4 users (show)

Fixed In Version: python-mccabe-0.2.1-3.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-30 11:42:27 UTC
Type: ---
Embargoed:
pingou: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Matěj Cepl 2013-04-15 09:44:51 UTC
Spec URL: http://mcepl.fedorapeople.org/rpms/python-mccabe.spec
SRPM URL: http://mcepl.fedorapeople.org/rpms/python-mccabe-0.2.1-1.el7.src.rpm
Description: Ned's script to check McCabe complexity.
This module provides a plugin for ``flake8``, the Python code checker.
Fedora Account System Username: mcepl

Comment 1 Matěj Cepl 2013-04-15 15:41:10 UTC
Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=5253450

Comment 2 Pierre-YvesChibon 2013-04-15 18:03:04 UTC
* package meets naming guidelines
* package meets packaging guidelines
* spec is clean
* license MIT is fine
* source matches upstream:
5a3f3fa6a4bad126c88aaaa7dab682f5
* no missing BR
* no unnecessary BR
* no locales
* not relocatable
* owns all directories that it creates
* no duplicate files
* permissions ok
* macro use consistent
* code, not content
* no need for -docs
* nothing in %doc affects runtime
* no need for .desktop file 

Please fix the changelog.

I still have to test it and I'll approve it.

Comment 3 Matěj Cepl 2013-04-15 21:20:07 UTC
%changelog updated.

http://mcepl.fedorapeople.org/rpms/python-mccabe-0.2.1-2.el7.src.rpm

Comment 4 Pierre-YvesChibon 2013-04-16 07:06:27 UTC
Seems to run fine on python 2.7.3 and python 3.3.0 (F18).

This package is APPROVED

Comment 5 Pierre-YvesChibon 2013-04-16 07:08:47 UTC
Btw, you might want to ask upstream to include a copy of the license with the sources and include that in the RPM %doc.

It's just a matter of adding the appropriate MANIFEST.in to the sources.

Comment 6 Matěj Cepl 2013-04-16 08:00:33 UTC
New Package SCM Request
=======================
Package Name: python-mccabe
Short Description: Ned's script to check McCabe complexity.
Owners: mcepl
Branches: f17 f18 f19
InitialCC:

Comment 7 Gwyn Ciesla 2013-04-16 13:26:37 UTC
Git done (by process-git-requests).

Comment 8 Pierre-YvesChibon 2013-04-30 08:47:54 UTC
ping ?

Comment 10 Fedora Update System 2013-04-30 17:54:54 UTC
python-mccabe-0.2.1-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-mccabe-0.2.1-2.fc17

Comment 11 Fedora Update System 2013-04-30 17:55:33 UTC
python-mccabe-0.2.1-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-mccabe-0.2.1-2.fc18

Comment 12 Fedora Update System 2013-04-30 19:23:36 UTC
python-mccabe-0.2.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-mccabe-0.2.1-2.fc19

Comment 13 Fedora Update System 2013-05-24 20:50:03 UTC
python-mccabe-0.2.1-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2013-05-25 11:58:11 UTC
python-mccabe-0.2.1-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 15 Fedora Update System 2013-05-25 12:12:53 UTC
python-mccabe-0.2.1-2.fc18 has been pushed to the Fedora 18 stable repository.

Comment 16 Fedora Update System 2014-01-21 17:33:13 UTC
python-mccabe-0.2.1-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-mccabe-0.2.1-3.el6

Comment 17 Fedora Update System 2014-04-09 05:26:09 UTC
python-mccabe-0.2.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.