Description of problem: Trying to review xpra (bug #928609), I'm getting false positive about update-desktop-database from fedora-review. Version-Release number of selected component (if applicable): fedora-review-0.4.0-4.fc18.noarch How reproducible: always Steps to Reproduce: 1. fedora-review -b 928609 Actual results: Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in xpra See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Expected results: (no issues) if "update-desktop-database" is referred, the proper guidelines link is http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database Additional info: the srpm in question reads: %post /usr/bin/update-desktop-database &> /dev/null || : /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun /usr/bin/update-desktop-database &> /dev/null || : if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi which seems 100% okay according to the guidelines ...?
Indeed, here are multiple bugs. The bogus error message is triggered by the xpra spec using desktop-file-validate in %check instead of the more common use in %install. The %check use is perfectly OK, but not handled by f-r.
fedora-review-0.5.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.5.0-1.el6
fedora-review-0.5.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fedora-review-0.5.0-1.fc19
Fixed in new 0.5.0 release. Thanks for reporting!
fedora-review-0.5.0-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.5.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.