Bug 953248 - checksum-type not honored on unit copy
Summary: checksum-type not honored on unit copy
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: rpm-support
Version: 2.1 Beta
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 2.3.0
Assignee: Barnaby Court
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-17 18:28 UTC by Ryan Bowlby
Modified: 2013-12-09 14:30 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-09 14:30:53 UTC
Embargoed:


Attachments (Terms of Use)

Description Ryan Bowlby 2013-04-17 18:28:51 UTC
Description of problem:

I'm attempting to swap our production pulpV1 with 2.1. We have a
mirror of external repos and then a clone of that local daily mirror.
When setting up the clone in 2.1 the metadata generated is sha256,
even though both repos are set to sha.


The local mirror:

Id:                  daily-centos-5-extras-x86_64
Display Name:        daily-centos-5-extras-x86_64
Description:         None
Content Unit Counts:
  Package Category: 1
  Package Group:    7
  Rpm:              270
Notes:
Importers:
  Config:
    Feed URL: http://mirror.centos.org/centos/5/extras/x86_64
  Id:               yum_importer
  Importer Type Id: yum_importer
  Last Sync:        2013-04-16T19:21:48Z
  Repo Id:          daily-centos-5-extras-x86_64
  Scheduled Syncs:  516769a3ee95995ff4023162
Distributors:
  Auto Publish:        True
  Config:
    Checksum Type: sha
    Http:          True
    Https:         True
    Relative URL:  daily/centos/5/extras/x86_64
  Distributor Type Id: yum_distributor
  Id:                  yum_distributor
  Last Publish:        2013-04-16T06:43:48Z
  Repo Id:             daily-centos-5-extras-x86_64
  Scheduled Publishes:


pulp-admin rpm repo create --repo-id=stable-centos-5-extras-x86_64 --relative-url=stable/centos/5/extras/x86_64 --serve-http=true --serve-https=true --checksum-type sha

pulp-admin rpm repo copy rpm --from-repo-id=daily-centos-5-extras-x86_64 --to-repo-id=stable-centos-5-extras-x86_64
pulp-admin rpm repo publish run --repo-id=stable-centos-5-extras-x86_64


# grep sha /var/lib/pulp/published/http/repos/stable/centos/5/extras/x86_64/repodata/repomd.xml
  <checksum type="sha256">1075a7ef67740a7f076d4d114d6751de9a4655bb961f0cfca86515f28224a350</checksum>
  <open-checksum
type="sha256">54f93f445e243b31b66c021f35393caa10f8c9b2e353b9053790e08c7306cf1c</open-checksum>
  <checksum type="sha256">e7c7c6964f06c3adad37d28a14f355d8ad7655b05ddd35b88c2b732585574788</checksum>
  <open-checksum




Version-Release number of selected component (if applicable):


Pulp 2.1

How reproducible:


Steps to Reproduce:
1. create local repo of any RH5 repo with checksum set to sha
2. create new local repo with checksum set to sha
3. perform "copy" action from local to new_local
4. publish
  
Actual results:

metadata checksums are sha256

Expected results:

metadata checksums are sha

Additional info:


Temp fix for me was to modify:

/usr/lib/python2.6/site-packages/pulp_rpm/yum_plugin/metadata.py

Changing the DEFAULT_CHECKSUM to sha and restarting apache.

Comment 1 cristi falcas 2013-07-08 12:50:00 UTC
The same happens to the nodes/parent configuration: all child servers have checksum set to sha256, even if the parent is md5. Also I updated the information manually for each repo, but the result is the same: checksums are sha256.

Comment 2 Frank Ederveen 2013-07-29 13:34:41 UTC
Hi,

I just wanted to put in a 'this happens for me too'.

# curl --silent --user ... --insecure https://localhost/pulp/api/v2/repositories/rhel-x86_64-server-5/distributors/yum_distributor/ |json2yaml.rb
..
config:
  http: true
  relative_url: rhel-x86_64-server-5
  https: true
  checksum_type: sha


And on the clone:

curl --silent --user ... --insecure https://localhost/pulp/api/v2/repositories/rhel-x86_64-server-5-20130729_01/distributors/ |json2yaml.rb
..
config:
  relative_url: rhel-x86_64-server-5-20130729_01
  https: true
  http: true

It would be nice if this could be fixed..

Thanks,
Frank

Comment 3 Barnaby Court 2013-09-12 20:29:37 UTC
Pull Request: https://github.com/pulp/pulp_rpm/pull/335

Comment 4 Jeff Ortel 2013-09-18 23:58:57 UTC
build: 2.3.0-0.14.alpha

Comment 5 Preethi Thomas 2013-09-20 14:06:16 UTC
verified
[root@pulp-v2-server ~]# rpm -q pulp-server
pulp-server-2.3.0-0.14.alpha.el6.noarch
[root@pulp-v2-server ~]# 


[root@pulp-v2-server ~]# pulp-admin rpm repo sync run --repo-id daily-centos-5-extras-x86_64 
+----------------------------------------------------------------------+
        Synchronizing Repository [daily-centos-5-extras-x86_64]
+----------------------------------------------------------------------+

This command may be exited by pressing ctrl+c without affecting the actual
operation on the server.

Downloading metadata...
[-]
... completed

Downloading repository content...
[==================================================] 100%
RPMs:       270/270 items
Delta RPMs: 0/0 items

... completed

Downloading distribution files...
[==================================================] 100%
Distributions: 0/0 items
... completed

Importing errata...
[-]
... completed

Importing package groups/categories...
[\]
... completed

Publishing packages...
[==================================================] 100%
Packages: 270/270 items
... completed

Publishing distributions...
[==================================================] 100%
Distributions: 0/0 items
... completed

Generating metadata
[/]
... completed

Publishing repository over HTTPS
[-]
... completed

[root@pulp-v2-server ~]# pulp-admin rpm repo create --repo-id=stable-centos-5-extras-x86_64 --relative-url=stable/centos/5/extras/x86_64 --serve-http=true --serve-https=true --checksum-type sha
Successfully created repository [stable-centos-5-extras-x86_64]

[root@pulp-v2-server ~]# pulp-admin rpm repo copy rpm --from-repo-id=daily-centos-5-extras-x86_64 --to-repo-id=stable-centos-5-extras-x86_64
This command may be exited via ctrl+c without affecting the request.

[-]
Waiting to begin...

[-]
Running...

Summary:
  rpm: 270

[root@pulp-v2-server ~]# pulp-admin rpm repo publish run --repo-id=stable-centos-5-extras-x86_64
+----------------------------------------------------------------------+
         Publishing Repository [stable-centos-5-extras-x86_64]
+----------------------------------------------------------------------+

This command may be exited by pressing ctrl+c without affecting the actual
operation on the server.

Publishing packages...
[==================================================] 100%
Packages: 270/270 items
... completed

Publishing distributions...
[==================================================] 100%
Distributions: 0/0 items
... completed

Generating metadata
[|]
... completed

Publishing repository over HTTPS
[-]
... completed

Publishing repository over HTTP
[-]
... completed

[root@pulp-v2-server ~]#  grep sha
^C
[root@pulp-v2-server ~]# ls -l /var/lib/pulp/published/http/repos/stable/centos/
5/       listing  
[root@pulp-v2-server ~]# grep sha /var/lib/pulp/published/http/repos/stable/centos/5/extras/x86_64/repodata/repomd.xml 
  <checksum type="sha">7525805f8b9c8369811f462666114651beacf846</checksum>
  <open-checksum type="sha">aac46c3490eabab6911f2c26d27b96557e95e471</open-checksum>
  <checksum type="sha">fa43255431f7a01c486516e69e3ea71dcf22fac9</checksum>
  <open-checksum type="sha">1aba73ae23293484038b78f085dda023ab81aa40</open-checksum>
  <checksum type="sha">a2acf10cc9ee3361424e7d2282e568cf792510ba</checksum>
  <open-checksum type="sha">52e8b10e429cdbd0127fbeff44ff67965e87edcb</open-checksum>
  <checksum type="sha">206e85bf3f0987d871a782a3e2f277ff4dfe10b1</checksum>
  <open-checksum type="sha">973ac083104525de5bf03c910ba08f57ee50b915</open-checksum>
  <checksum type="sha">cf93363687559a4da609d60caa75e7777735fc2e</checksum>
  <open-checksum type="sha">e2a711bd1d07c6da61141c6befde60223eca380b</open-checksum>
  <checksum type="sha">88835f893c652a3aac5f819c41ae4b29cbdfcae1</checksum>
  <open-checksum type="sha">56f959b6faa86612a79cdf55a8e3323849fec4cd</open-checksum>
[root@pulp-v2-server ~]#

Comment 6 Preethi Thomas 2013-12-09 14:30:53 UTC
Pulp 2.3 released.


Note You need to log in before you can comment on or make changes to this bug.