Bug 953663 - Content View Definition -> Content -> +Add button should be disabled until a Product is selected
Summary: Content View Definition -> Content -> +Add button should be disabled until a ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: Nightly
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: Walden Raines
QA Contact: Og Maciel
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-18 20:36 UTC by sthirugn@redhat.com
Modified: 2019-09-26 15:50 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-24 17:09:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Traceback error (12.06 KB, application/octet-stream)
2013-04-18 20:36 UTC, sthirugn@redhat.com
no flags Details

Description sthirugn@redhat.com 2013-04-18 20:36:25 UTC
Created attachment 737412 [details]
Traceback error

Description of problem:
Content View Definition -> Content -> +Add button should be disbaled until a Product is selected

Version-Release number of selected component (if applicable):
* candlepin-0.8.3-1.el6.noarch
* candlepin-selinux-0.8.3-1.el6.noarch
* candlepin-tomcat6-0.8.3-1.el6.noarch
* elasticsearch-0.19.9-7.el6.noarch
* katello-1.4.1-1.git.122.0cefe14.el6.noarch
* katello-all-1.4.1-1.git.122.0cefe14.el6.noarch
* katello-candlepin-cert-key-pair-1.0-1.noarch
* katello-certs-tools-1.4.1-1.el6.noarch
* katello-cli-1.4.1-1.git.21.1e2ff04.el6.noarch
* katello-cli-common-1.4.1-1.git.21.1e2ff04.el6.noarch
* katello-common-1.4.1-1.git.122.0cefe14.el6.noarch
* katello-configure-1.4.1-1.git.111.f7f9fea.el6.noarch
* katello-glue-candlepin-1.4.1-1.git.122.0cefe14.el6.noarch
* katello-glue-elasticsearch-1.4.1-1.git.122.0cefe14.el6.noarch
* katello-glue-pulp-1.4.1-1.git.122.0cefe14.el6.noarch
* Katello-Katello-Installation-ConfigureRepos-1.7-3.noarch
* Katello-Katello-Installation-KatelloNightly-1.0-10.noarch
* Katello-Katello-Installation-RegisterRHNClassic-1.1-3.noarch
* Katello-Katello-Sanity-ImportKeys-1.2-1.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-qpid-client-key-pair-1.0-1.noarch
* katello-repos-1.4.1-1.el6.noarch
* katello-selinux-1.4.1-1.el6.noarch
* pulp-rpm-plugins-2.1.1-0.6.beta.el6.noarch
* pulp-selinux-2.1.1-0.1.beta.el6.noarch
* pulp-server-2.1.1-0.1.beta.el6.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create a Content View Definition
2. Navigate to this newly Content View Definition -> Content Tab
3. Under the section, without choosing a Product, Click +Add
  
Actual results:
1. Nothing happens in UI
2. Firebug shows following error:
TypeError: n is null
https://hp-dl320g6-01.rhts.eng.bos.redhat.com/katello/assets/content_view_definitions-fddc9152f74b2420506aacfa0aa944b4.js
3. Traceback error attached

Expected results:
+Add button should be disabled to avoid the issues listed

Additional info:
Similar behavior with +Add button is observed for filter rules as well.
Scenario:
1. Navigate to Content View Definition -> Filters Tab -> Click New Filter
2. Enter filter name and click Create. It takes you to the rules page.
3. Click Add New Rule. Select Packages. Click Create
4. Now click on +Add without entering the package name.
5. Observe that there is no change in UI

Comment 3 Walden Raines 2013-09-23 15:27:24 UTC
PR opened:  https://github.com/Katello/katello/pull/3019

Comment 4 Walden Raines 2013-09-24 14:26:07 UTC
commit 33e435e0fb9187545f5f9003f067255be788ca9f
Merge: 87a618a 0a1fc66
Author: Walden Raines <walden>
Date:   Tue Sep 24 07:23:56 2013 -0700

    Merge pull request #3019 from waldenraines/bug-953663
    
    Bug #953663 - only show 'add' button if there are products to add.

commit 0a1fc6679579f98860e181584fefab33ac0745c9
Author: Walden Raines <walden>
Date:   Mon Sep 23 11:25:09 2013 -0400

    Bug #953663 - only show 'add' button if there are products to add.

Comment 7 Og Maciel 2013-10-05 15:53:51 UTC
* Add button for products are only displayed if there is a content available. The UI no longer allows you to add "nothing".
* There is a visible +Add button for packages but it works as expected: if content is added to the text box, it gets added; otherwise nothing happens.

Comment 8 Og Maciel 2013-10-05 15:54:56 UTC
Verified:

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.8.25-1.el6sam.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.8.25-1.el6sam.noarch
* candlepin-tomcat6-0.8.25-1.el6sam.noarch
* elasticsearch-0.19.9-8.el6sat.noarch
* foreman-1.3.0-13.el6sat.noarch
* foreman-compute-1.3.0-13.el6sat.noarch
* foreman-libvirt-1.3.0-13.el6sat.noarch
* foreman-postgresql-1.3.0-13.el6sat.noarch
* foreman-proxy-1.3.0-2.el6sat.noarch
* katello-1.4.6-19.el6sat.noarch
* katello-all-1.4.6-19.el6sat.noarch
* katello-candlepin-cert-key-pair-1.0-1.noarch
* katello-certs-tools-1.4.4-1.el6sat.noarch
* katello-cli-1.4.3-17.el6sat.noarch
* katello-cli-common-1.4.3-17.el6sat.noarch
* katello-common-1.4.6-19.el6sat.noarch
* katello-configure-1.4.5-9.el6sat.noarch
* katello-configure-foreman-1.4.5-9.el6sat.noarch
* katello-configure-foreman-proxy-1.4.5-9.el6sat.noarch
* katello-foreman-all-1.4.6-19.el6sat.noarch
* katello-glue-candlepin-1.4.6-19.el6sat.noarch
* katello-glue-elasticsearch-1.4.6-19.el6sat.noarch
* katello-glue-pulp-1.4.6-19.el6sat.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-qpid-client-key-pair-1.0-1.noarch
* katello-selinux-1.4.4-4.el6sat.noarch
* openldap-2.4.23-31.el6.x86_64
* pulp-katello-plugins-0.2-1.el6sat.noarch
* pulp-nodes-common-2.3.0-0.17.beta.el6sat.noarch
* pulp-nodes-parent-2.3.0-0.17.beta.el6sat.noarch
* pulp-puppet-plugins-2.3.0-0.17.beta.el6sat.noarch
* pulp-rpm-plugins-2.3.0-0.17.beta.el6sat.noarch
* pulp-selinux-2.3.0-0.17.beta.el6sat.noarch
* pulp-server-2.3.0-0.17.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-ldap_fluff-0.2.2-2.el6sat.noarch
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.0.7-1.el6sat.noarch
* signo-0.0.20-3.el6sat.noarch
* signo-katello-0.0.20-3.el6sat.noarch

Comment 9 Bryan Kearney 2014-04-24 17:09:22 UTC
This was verified and delivered with MDP2. Closing it out.

Comment 10 Bryan Kearney 2014-04-24 17:10:53 UTC
This was delivered and verified with MDP2. Closing the bug.


Note You need to log in before you can comment on or make changes to this bug.