Patch already merged upstream. Complete FQDN validation with bug #948311 and bug #928667.

+++ This bug was initially created as a clone of Bug #843623 +++

Component should be ovirt-engine-setup but it is not in the list

Description of problem:
When substituting an IP address for a fully qualified domain name in engine-setup, engine-setup reports that "<ip address here> did not resolve to an ip address. User input failed validation...". Not sure if there is a way to check for an IP address before checking for a FQDN, or if an ip address is unsupported.

Version-Release number of selected component (if applicable):
ovirt-engine 3.1.0-1.fc17
ovirt-engine-setup-3.1.0-1.fc17

How reproducible:
Always when using an IP address for a FQDN

Steps to Reproduce:
1. Install ovirt-engine
2. Run engine-setup
3. Enter the system IP address for "Host fully qualified domain name".
  
Actual results:
<ip address> did not resolve into an IP address
User input failed validation, do you still wish to use it (yes|no):

Expected results:
No lookup of an IP address as it is an IP address

Additional info:
3.0 also had this behavior, but I think it just said "user input failed validation, do you still wish to use it (yes|no)"

--- Additional comment from Cybertimber2011 on 2012-07-26 15:06:15 EDT ---

Additional comment, that line differs from others in how the options are presented. It should say ['yes'| 'no']: similar to the iptables question.

--- Additional comment from Alex Lourie on 2013-01-23 16:36:23 EST ---

Is it possible to test this with the latest master version upstream?

Basically, the behaviour of 3.1/3.2 should be the same as 3.0 in this regard.

--- Additional comment from Cybertimber2011 on 2013-01-24 12:23:20 EST ---

Do you mean re-test with 3.2?

--- Additional comment from Alex Lourie on 2013-01-24 12:55:46 EST ---

(In reply to comment #3)
> Do you mean re-test with 3.2?

Yes, please :-)

--- Additional comment from Sandro Bonazzola on 2013-02-01 08:07:55 EST ---

Tested with 
ovirt-engine-setup-3.3.0-0.1.20130131130858.20130131.git6c8007c.fc18.noarch

still present as in comment #0 and comment #1

--- Additional comment from Sandro Bonazzola on 2013-02-01 08:15:48 EST ---

Additionally, it is present if the device with the given IP address is under NetworkManager and also if the device is confiugred with NM_CONTROLLED=no.

--- Additional comment from Sandro Bonazzola on 2013-02-01 09:35:39 EST ---

Patch sent upstream for comment #0. About comment #1, it requires a change in askYesNo function in common_utils, shared with other scripts and I'm not sure if it has to be changed or not.

--- Additional comment from Cybertimber2011 on 2013-02-03 15:12:30 EST ---

Re: Comment #1 change, are the other questions not asked with the askYesNo function in common_utils?

I will finally have my 3.2 test system up shortly to do some testing. Sorry it's taken me a bit to respond, but thanks Sandro for testing and patching this.

--- Additional comment from Cybertimber2011 on 2013-02-04 12:16:42 EST ---

Yes, I can confirm this is still present as well.
Tested with ovirt-engine-setup-3.2.0-2.fc18.noarch

--- Additional comment from Sandro Bonazzola on 2013-02-05 07:37:30 EST ---

It seems that a symbolic domain name is required for the engine to be able to generate certificates correctly. engine-setup will warn the user with a better message than <ip address here> did not resolve to an ip address. User input failed validation...

(In reply to comment #8)
> Re: Comment #1 change, are the other questions not asked with the askYesNo
> function in common_utils?

No, they're asked through _getInputFromUser with yes or no as options.

--- Additional comment from Sandro Bonazzola on 2013-02-07 02:39:38 EST ---

patch merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=dca66499e55dfa421a732567ade00ed1c696c363