SPEC URL : http://pravins.fedorapeople.org/google-noto-fonts.spec SRPM URL : http://pravins.fedorapeople.org/google-noto-fonts-20130411-1.fc18.src.rpm
will post Review/initial comments by Monday.
sorry for being late. Review:- + Koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=5297420 + rpmlint gave google-noto-sans-armenian-fonts.noarch: W: no-documentation google-noto-sans-devanagari-fonts.noarch: W: no-documentation google-noto-sans-devanagari-ui-fonts.noarch: W: no-documentation google-noto-sans-ethiopic-fonts.noarch: W: no-documentation google-noto-sans-fonts.noarch: W: no-documentation google-noto-sans-georgian-fonts.noarch: W: spelling-error Summary(en_US) seirf -> serif, serf google-noto-sans-georgian-fonts.noarch: W: no-documentation google-noto-sans-hebrew-fonts.noarch: W: no-documentation google-noto-sans-khmer-fonts.noarch: W: no-documentation google-noto-sans-khmer-ui-fonts.noarch: W: no-documentation google-noto-sans-lao-fonts.noarch: W: no-documentation google-noto-sans-lao-ui-fonts.noarch: W: no-documentation google-noto-sans-tamil-fonts.noarch: W: no-documentation google-noto-sans-tamil-ui-fonts.noarch: W: no-documentation google-noto-sans-thai-fonts.noarch: W: no-documentation google-noto-sans-thai-ui-fonts.noarch: W: no-documentation google-noto-sans-ui-fonts.noarch: W: no-documentation google-noto-serif-armenian-fonts.noarch: W: no-documentation google-noto-serif-fonts.noarch: W: no-documentation google-noto-serif-georgian-fonts.noarch: W: no-documentation google-noto-serif-lao-fonts.noarch: W: no-documentation google-noto-serif-thai-fonts.noarch: W: no-documentation 23 packages and 0 specfiles checked; 0 errors, 22 warnings. + Source verified with upstream as http://noto.googlecode.com/svn/trunk/packages/NotoFonts-hinted-2013-04-11.tgz : CHECKSUM(SHA256) this package : aa7fc867b4d7bf1f07f288d1515bd47d7f2b573877f0fbdf702b3aeac5eeed20 CHECKSUM(SHA256) upstream package : aa7fc867b4d7bf1f07f288d1515bd47d7f2b573877f0fbdf702b3aeac5eeed20 Suggestions: 1) -common contains only single file COPYING. Maybe you can drop it and add to all other subpackages Requires: fontpackages-filesystem 2) Add dot to end of all summary sentences of all subpackages. 3) Fix the spelling serif in google-noto-sans-georgian-fonts.noarch: W: spelling-error Summary(en_US) seirf -> serif, serf rest looks good.
Please note in the suggestion 2, I was actually trying to suggest to add dot for %description text not for summary.
Updated spec file and srpm as per suggestions. SPEC URL : http://pravins.fedorapeople.org/google-noto-fonts.spec SRPM URL : http://pravins.fedorapeople.org/google-noto-fonts-20130411-2.fc18.src.rpm
Scratch build-> http://koji.fedoraproject.org/koji/taskinfo?taskID=5327085 Still missing from all the subpackages following Requires: fontpackages-filesystem Please add it before you import. APPROVED.
Thanks Parag for review. Updated as per your comments. SPEC URL : http://pravins.fedorapeople.org/google-noto-fonts.spec SRPM URL : http://pravins.fedorapeople.org/google-noto-fonts-20130411-2.fc18.src.rpm
New Package SCM Request ======================= Package Name: google-noto-fonts Short Description: Hinted Open Type fonts for Unicode scripts Owners: pravins Branches: f19 InitialCC: i18n-team
Git done (by process-git-requests).
google-noto-fonts-20130411-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/google-noto-fonts-20130411-3.fc19
Thanks you Jon for git process. Build it for Master and F19
google-noto-fonts-20130411-3.fc19 has been pushed to the Fedora 19 testing repository.
google-noto-fonts-20130411-3.fc19 has been pushed to the Fedora 19 stable repository.
Package Change Request ====================== Package Name: google-noto-fonts Branches: f19 f20 devel InitialCC: fonts-sig I'd like the Fonts SIG to be notified of changes to this package in all active branches.
Complete.