Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-7.3-1.fc18.src.rpm Description: jedi-vim is a VIM binding to the awesome auto completion library Jedi. Fedora Account System Username: phracek rpmlint was run as on spec file as on SRPM: phracek@localhost: ~/work/jedi-vim (master *%)$ rpmlint /home/phracek/rpmbuild/SRPMS/vim-jedi-7.3-1.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. phracek@localhost: ~/work/jedi-vim (master *%)$ rpmlint vim-jedi.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. phracek@localhost: ~/work/jedi-vim (master *%)$
- According [1] you should avoid using Epoch - You are missing BuildArch [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Use_of_Epochs
New SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-7.3-2.fc18.src.rpm New SPEC URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec
Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-2.fc18.src.rpm Correction: - Files are stored in vimfiles directory - Requires: vim-common - post and postun sections - Corrected version which is the same as on git. phracek@kiasportyw: ~/work/jedi-vim (master %)$ rpmlint /home/phracek/rpmbuild/SRPMS/vim-jedi-0.5.0-2.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. phracek@kiasportyw: ~/work/jedi-vim (master %)$
Few things to improve - I found out better SourceURL [1], 0.5.0 is better than master IMO - You are missing upstream docs (README.rst, LICENSE.txt, AUTHORS.txt) in files section - Post and postun section are not needed since there are no txt file to generate tags from for vim-jedi - IMO you should delete Buildroot, Clean and rm -rf $RPM_BUILD_ROOT if you are not packaging for EPEL they are not needed in Fedora (more info [2]) - There is unused command pwd in install section [1] https://github.com/davidhalter/jedi-vim/tarball/0.5.0 [2] https://fedoraproject.org/wiki/How_to_create_an_RPM_package
Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-3.fc18.src.rpm Correction were corrected and changelog were updated as well. phracek@kiasportyw: ~/work/jedi-vim (master %)$ rpmlint vim-jedi.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. phracek@kiasportyw: ~/work/jedi-vim (master %)$ rpmlint /home/phracek/rpmbuild/SRPMS/vim-jedi-0.5.0-3.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. phracek@kiasportyw: ~/work/jedi-vim (master %)$
Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-4.fc18.src.rpm Corrected License field.
- you forgot to delete BuildRoot: - also please unify macro using, in install section use %{buildroot}%{vimfiles_root} instead of $RPM_BUILD_ROOT/%{vimfiles_root}
Macro's are unify. BuildRoot field is deleted Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-5.fc18.src.rpm
Looks good now. Approving.
New Package SCM Request ======================= Package Name: vim-jedi Short Description: Python autocompletion plugin for VIM Owners: phracek Branches: f19
Git done (by process-git-requests).
scm-commit (http://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130506/1016210.html) -> MODIFIED
vim-jedi-0.5.0-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/vim-jedi-0.5.0-5.fc19
Clearing flag.
vim-jedi-0.5.0-5.fc19 has been pushed to the Fedora 19 testing repository.
vim-jedi-0.5.0-5.fc19 has been pushed to the Fedora 19 stable repository.