Bug 953952 - grilo-plugins: please use SQLite prepared statements properly
Summary: grilo-plugins: please use SQLite prepared statements properly
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: grilo-plugins
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Bastien Nocera
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 953946 1045389
TreeView+ depends on / blocked
 
Reported: 2013-04-19 15:46 UTC by Florian Weimer
Modified: 2015-06-29 12:40 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
: 1045389 (view as bug list)
Environment:
Last Closed: 2015-06-29 12:40:29 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Bugzilla 673912 0 None None None Never

Description Florian Weimer 2013-04-19 15:46:22 UTC
In src/podcasts/grl-podcasts.c and src/bookmarks/grl-bookmarks.c, parameter values are spliced directly into SQL statements using g_strdup_printf in some cases.  The values should be kept separate and passed to SQLite using sqlite3_bind_text.

Comment 1 Fedora End Of Life 2013-09-16 13:33:38 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 2 Fedora End Of Life 2015-05-29 09:00:08 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2015-06-29 11:53:22 UTC
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 4 Florian Weimer 2015-06-29 12:10:58 UTC
Still present in master/rawhide.

Comment 5 Bastien Nocera 2015-06-29 12:40:29 UTC
This is already upstream:
https://bugzilla.gnome.org/show_bug.cgi?id=673912

Note that the podcast plugin isn't used by any applications, and that the bookmarks is already fixed.


Note You need to log in before you can comment on or make changes to this bug.