Bug 954057 - do not do root squashing for the clients mounted in the storage pool
Summary: do not do root squashing for the clients mounted in the storage pool
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: rpc
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
Assignee: Raghavendra Bhat
QA Contact:
URL:
Whiteboard:
: 960913 (view as bug list)
Depends On:
Blocks: 960913
TreeView+ depends on / blocked
 
Reported: 2013-04-20 08:15 UTC by Raghavendra Bhat
Modified: 2014-11-11 08:23 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 960913 (view as bug list)
Environment:
Last Closed: 2014-11-11 08:23:39 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Raghavendra Bhat 2013-04-20 08:15:15 UTC
Description of problem:

If requests are coming from the clients which are mounted in the trusted storage pool, (that too using the same glusterd's ip/hostname where it is mounted), then 
disable root-squashing on for those clients.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2013-04-21 04:05:11 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#1) for review on master by Raghavendra Bhat (raghavendra)

Comment 2 Raghavendra Bhat 2013-04-23 07:38:02 UTC
http://review.gluster.org/#/c/4863/ has been submitted for review.

Comment 3 Anand Avati 2013-04-23 07:42:34 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#2) for review on master by Raghavendra Bhat (raghavendra)

Comment 4 Anand Avati 2013-04-24 10:11:52 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#3) for review on master by Raghavendra Bhat (raghavendra)

Comment 5 Anand Avati 2013-04-26 12:07:04 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#4) for review on master by Raghavendra Bhat (raghavendra)

Comment 6 Raghavendra Bhat 2013-05-08 10:31:01 UTC
*** Bug 960913 has been marked as a duplicate of this bug. ***

Comment 7 Anand Avati 2013-06-06 06:14:42 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#5) for review on master by Raghavendra Bhat (raghavendra)

Comment 8 Anand Avati 2013-07-25 07:19:08 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#6) for review on master by Raghavendra Bhat (raghavendra)

Comment 9 Anand Avati 2013-07-26 07:13:38 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#7) for review on master by Raghavendra Bhat (raghavendra)

Comment 10 Anand Avati 2013-07-26 07:20:24 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#8) for review on master by Raghavendra Bhat (raghavendra)

Comment 11 Anand Avati 2013-07-30 09:06:58 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#9) for review on master by Raghavendra Bhat (raghavendra)

Comment 12 Anand Avati 2013-08-05 13:52:33 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#10) for review on master by Raghavendra Bhat (raghavendra)

Comment 13 Anand Avati 2013-08-05 13:56:36 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#11) for review on master by Raghavendra Bhat (raghavendra)

Comment 14 Anand Avati 2013-08-22 13:01:25 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#12) for review on master by Raghavendra Bhat (raghavendra)

Comment 15 Anand Avati 2013-08-22 13:09:29 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#13) for review on master by Raghavendra Bhat (raghavendra)

Comment 16 Anand Avati 2013-08-26 13:10:27 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#14) for review on master by Raghavendra Bhat (raghavendra)

Comment 17 Anand Avati 2013-12-16 12:20:01 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#15) for review on master by Raghavendra Bhat (raghavendra)

Comment 18 Anand Avati 2013-12-19 12:05:56 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#16) for review on master by Raghavendra Bhat (raghavendra)

Comment 19 Anand Avati 2014-01-02 09:06:07 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#17) for review on master by Raghavendra Bhat (raghavendra)

Comment 20 Anand Avati 2014-01-03 07:10:59 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#18) for review on master by Raghavendra Bhat (raghavendra)

Comment 21 Anand Avati 2014-02-10 13:26:56 UTC
REVIEW: http://review.gluster.org/4863 (protocol/server: do not do root-squashing for trusted clients) posted (#19) for review on master by Raghavendra Bhat (raghavendra)

Comment 22 Anand Avati 2014-02-11 07:32:26 UTC
COMMIT: http://review.gluster.org/4863 committed in master by Vijay Bellur (vbellur) 
------
commit 28209283a67f13802cc0c1d3df07c676926810a2
Author: Raghavendra Bhat <raghavendra>
Date:   Fri Apr 19 12:27:03 2013 +0530

    protocol/server: do not do root-squashing for trusted clients
    
    * As of now clients mounting within the storage pool using that machine's
      ip/hostname are trusted clients (i.e clients local to the glusterd).
    
    * Be careful when the request itself comes in as nfsnobody (ex: posix tests).
      So move the squashing part to protocol/server when it creates a new frame
      for the request, instead of auth part of rpc layer.
    
    * For nfs servers do root-squashing without checking if it is trusted client,
      as all the nfs servers would be running within the storage pool, hence will
      be trusted clients for the bricks.
    
    * Provide one more option for mounting which actually says root-squash
      should/should not happen. This value is given priority only for the trusted
      clients. For non trusted clients, the volume option takes the priority. But
      for trusted clients if root-squash should not happen, then they have to be
      mounted with root-squash=no option. (This is done because by default
      blocking root-squashing for the trusted clients will cause problems for smb
      and UFO clients for which the requests have to be squashed if the option is
      enabled).
    
    * For geo-replication and defrag clients do not do root-squashing.
    
    * Introduce a new option in open-behind for doing read after successful open.
    
    Change-Id: I8a8359840313dffc34824f3ea80a9c48375067f0
    BUG: 954057
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/4863
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 23 Anand Avati 2014-02-11 13:41:08 UTC
REVIEW: http://review.gluster.org/6975 (mount.glusterfs: backward compatible option for root-squashing) posted (#1) for review on master by Raghavendra Bhat (raghavendra)

Comment 24 Anand Avati 2014-02-12 14:27:54 UTC
COMMIT: http://review.gluster.org/6975 committed in master by Vijay Bellur (vbellur) 
------
commit 2e093c728c856a41399ffdcf33c91d21c3a2f0f2
Author: Raghavendra Bhat <raghavendra>
Date:   Tue Feb 11 13:16:38 2014 +0530

    mount.glusterfs: backward compatible option for root-squashing
    
    Change-Id: I74fa6686cff84cfad4a2587a0061e6bb2beea081
    BUG: 954057
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/6975
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 25 Niels de Vos 2014-09-22 12:31:49 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 26 Niels de Vos 2014-11-11 08:23:39 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.