Bug 954149 - glusterfs-server RPM calls 'service glusterd condrestart' which is not a valid action
Summary: glusterfs-server RPM calls 'service glusterd condrestart' which is not a vali...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: 3.4.0-alpha
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL: http://lists.nongnu.org/archive/html/...
Whiteboard:
Depends On:
Blocks: 918917
TreeView+ depends on / blocked
 
Reported: 2013-04-21 09:20 UTC by Niels de Vos
Modified: 2014-04-17 13:12 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.4.3
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-17 13:12:32 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2013-04-21 09:20:09 UTC
On Sun, Apr 21, 2013 at 08:26:02AM +0100, Nux! wrote:
> On 17.04.2013 17:10, jenkins.org wrote:
> >RPM: http://bits.gluster.org/pub/gluster/glusterfs/3.4.0alpha3/
> >
> >SRC:
> >http://bits.gluster.org/pub/gluster/glusterfs/src/glusterfs-3.4.0alpha3.tar.gz
> >
> >This release is made off jenkins-release-31
> 
> And rpm upgrade killed glusterd (3.4 git) and output this:
> 
> [root@2216 3.4.0alpha3]# rpm -Uvh
> glusterfs-3.4.0alpha3-1.el6.x86_64.rpm
> glusterfs-fuse-3.4.0alpha3-1.el6.x86_64.rpm
> glusterfs-server-3.4.0alpha3-1.el6.x86_64.rpm
...
> error: %preun(glusterfs-server-3.4git-1.el6.nux.x86_64) scriptlet
> failed, exit status 1
> 
> Let me know if/what logs are needed to make sense of things.

Looks like you updated glusterfs-3.4git-1.el6.nux to  
glusterfs-3.4.0alpha3-1.el6. The pre-uninstall script from 
glusterfs-server-3.4git-1.el6.nux.x86_64 exited with an error. It seems 
that you have build that version yourself, so you will need to verify 
the scriptlet of that RPM. You can print the scriptlet if you still have 
the rpm itself with a command like this:

  $ rpm -q --qf '%{PREUN}\n' -p glusterfs-server-3.4git-1.el6.nux.x86_64.rpm

From a package that I build from git, I would suspect that the following 
command fails:

   /sbin/service glusterd condrestart

The extras/init.d/glusterd-Redhat(.in) does not accept the condrestart 
action. The Fedora package seems to carry its own init-script which does 
include support for condrestart. The .spec from Fedora has been merged 
into the glusterfs project, but obviously some dependencies (like 
changes to the init-script) have been missed.

Comment 1 Anand Avati 2013-04-21 09:21:10 UTC
REVIEW: http://review.gluster.org/4864 (extras: include Fedora changes in init.d/glusterd) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2013-04-21 09:25:07 UTC
REVIEW: http://review.gluster.org/4865 (extras: include Fedora changes in init.d/glusterd) posted (#1) for review on release-3.4 by Niels de Vos (ndevos)

Comment 3 Anand Avati 2013-04-30 00:07:56 UTC
COMMIT: http://review.gluster.org/4864 committed in master by Anand Avati (avati) 
------
commit ee9984882e3b28e76fb3af5491a8d2bf22e432a3
Author: Niels de Vos <ndevos>
Date:   Sun Apr 21 11:10:06 2013 +0200

    extras: include Fedora changes in init.d/glusterd
    
    The changes in the .spec file from Fedora have largely been merged into
    the glusterfs.spec.in. It seems that some dependencies have been missed,
    most importantly some additions to the init-script that are called while
    (un)installing or updating RPMs.
    
    These changes come from the downstream Fedora package that carries its
    own glusterd.init script. In future, Fedora/EPEL should be able to drop
    that file and use the Gluster project version.
    
    Change-Id: Iac25854b0c559b93fa1dd452a04663bd95ea3378
    BUG: 954149
    URL: http://lists.nongnu.org/archive/html/gluster-devel/2013-04/msg00077.html
    CC: Fedora GlusterFS Packagers <glusterfs-owner>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/4864
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Anand Avati <avati>

Comment 4 Anand Avati 2013-04-30 00:08:24 UTC
COMMIT: http://review.gluster.org/4865 committed in release-3.4 by Anand Avati (avati) 
------
commit 6b67229526d41d1158f0617cbb41297b12be727d
Author: Niels de Vos <ndevos>
Date:   Sun Apr 21 11:10:06 2013 +0200

    extras: include Fedora changes in init.d/glusterd
    
    The changes in the .spec file from Fedora have largely been merged into
    the glusterfs.spec.in. It seems that some dependencies have been missed,
    most importantly some additions to the init-script that are called while
    (un)installing or updating RPMs.
    
    These changes come from the downstream Fedora package that carries its
    own glusterd.init script. In future, Fedora/EPEL should be able to drop
    that file and use the Gluster project version.
    
    BUG: 954149
    Change-Id: I7d25622ffa52228451e742b539f1f092eac57b6b
    URL: http://lists.nongnu.org/archive/html/gluster-devel/2013-04/msg00077.html
    CC: Fedora GlusterFS Packagers <glusterfs-owner>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/4865
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Anand Avati <avati>

Comment 5 Niels de Vos 2014-04-17 13:12:32 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.4.3, please reopen this bug report.

glusterfs-3.4.3 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should already be or become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

The fix for this bug likely to be included in all future GlusterFS releases i.e. release > 3.4.3. In the same line the recent release i.e. glusterfs-3.5.0 [3] likely to have the fix. You can verify this by reading the comments in this bug report and checking for comments mentioning "committed in release-3.5".

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/5978
[2] http://news.gmane.org/gmane.comp.file-systems.gluster.user
[3] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137


Note You need to log in before you can comment on or make changes to this bug.