Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 954256

Summary:	Tracking bug for all op-version related tasks remaining for gluster-3.4
Product:	[Community] GlusterFS	Reporter:	Kaushal <kaushal>
Component:	glusterd	Assignee:	Kaushal <kaushal>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	high
Version:	mainline	CC:	gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.4.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-24 17:51:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	907311
Bug Blocks:	918917

Description Kaushal 2013-04-22 05:48:00 UTC

The following tasks remain,

1. Selectively enable open-behind based on cluster-op-version
2. Detection of a fresh gluster install based on uuid
3. Update volume-op-versions calculations to take account of automatically enabled options
4. Update op-version calculations to take account of boolean options when calculating op-version

Comment 1 Anand Avati 2013-04-22 05:57:21 UTC

REVIEW: http://review.gluster.org/4866 (glusterd-volgen: Enable perf xlators based on op-version) posted (#1) for review on master by Kaushal M (kaushal)

Comment 2 Anand Avati 2013-04-22 07:08:17 UTC

REVIEW: http://review.gluster.org/4867 (glusterd: Set op-version on startup based on install status) posted (#1) for review on master by Kaushal M (kaushal)

Comment 3 Anand Avati 2013-04-24 09:34:44 UTC

REVIEW: http://review.gluster.org/4867 (glusterd: Set op-version on startup based on install status) posted (#2) for review on master by Kaushal M (kaushal)

Comment 4 Anand Avati 2013-04-24 10:17:51 UTC

REVIEW: http://review.gluster.org/4866 (glusterd-volgen: Enable open-behind based on op-version) posted (#2) for review on master by Kaushal M (kaushal)

Comment 5 Anand Avati 2013-05-06 10:33:43 UTC

REVIEW: http://review.gluster.org/4952 (glusterd-volgen: Improve volume op-version calculation) posted (#1) for review on master by Kaushal M (kaushal)

Comment 6 Anand Avati 2013-05-06 11:32:07 UTC

REVIEW: http://review.gluster.org/4866 (glusterd-volgen: Enable open-behind based on op-version) posted (#3) for review on master by Kaushal M (kaushal)

Comment 7 Anand Avati 2013-05-06 11:32:26 UTC

REVIEW: http://review.gluster.org/4952 (glusterd-volgen: Improve volume op-versions calculation) posted (#2) for review on master by Kaushal M (kaushal)

Comment 8 Anand Avati 2013-05-13 06:28:01 UTC

COMMIT: http://review.gluster.org/4867 committed in master by Vijay Bellur (vbellur) 
------
commit fa227c08341224ac95e45a710f7dbfbb3835a8fe
Author: Kaushal M <kaushal>
Date:   Mon Apr 22 12:17:59 2013 +0530

    glusterd: Set op-version on startup based on install status
    
    If the current installation of glusterfs doesn't have a stored
    op-version and is,
    a. a fresh install, then set op-version to maximum
    b. an upgrade from release which didn't have op-version support, set it
    to minimum.
    
    The install status is detected using the peer-uuid.
    If both peer-uuid and op-version are not present in the store, the
    installation is fresh.
    If peer-uuid is present, but op-version is absent in the store, the
    installation has been upgraded from a version which didn't support
    op-versions.
    
    By setting the initial op-version as above, we can ensure that
    a. features are not enabled accidentally during upgrades
    b. a fresh install starts with all possible features enabled.
    
    Change-Id: I52aed9ebeb5d3823c81e65f739a78a924ecf7e12
    BUG: 954256
    Signed-off-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/4867
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 9 Anand Avati 2013-05-14 06:44:03 UTC

REVIEW: http://review.gluster.org/5001 (glusterd: Set op-version on startup based on install status) posted (#1) for review on release-3.4 by Kaushal M (kaushal)

Comment 10 Anand Avati 2013-05-22 03:42:04 UTC

REVIEW: http://review.gluster.org/5001 (glusterd: Set op-version on startup based on install status) posted (#2) for review on release-3.4 by Kaushal M (kaushal)

Comment 11 Anand Avati 2013-05-22 06:02:46 UTC

REVIEW: http://review.gluster.org/4952 (glusterd-volgen: Improve volume op-versions calculation) posted (#3) for review on master by Kaushal M (kaushal)

Comment 12 Anand Avati 2013-05-22 06:20:21 UTC

REVIEW: http://review.gluster.org/4866 (glusterd-volgen: Enable open-behind based on op-version) posted (#4) for review on master by Kaushal M (kaushal)

Comment 13 Anand Avati 2013-05-23 09:56:11 UTC

REVIEW: http://review.gluster.org/4952 (glusterd-volgen: Improve volume op-versions calculation) posted (#4) for review on master by Kaushal M (kaushal)

Comment 14 Anand Avati 2013-05-23 11:39:19 UTC

REVIEW: http://review.gluster.org/4952 (glusterd-volgen: Improve volume op-versions calculation) posted (#5) for review on master by Kaushal M (kaushal)

Comment 15 Anand Avati 2013-05-27 07:22:45 UTC

REVIEW: http://review.gluster.org/5001 (glusterd: Set op-version on startup based on install status) posted (#3) for review on release-3.4 by Kaushal M (kaushal)

Comment 16 Anand Avati 2013-05-27 07:23:53 UTC

REVIEW: http://review.gluster.org/5094 (glusterd-volgen: Improve volume op-versions calculation) posted (#1) for review on release-3.4 by Kaushal M (kaushal)

Comment 17 Anand Avati 2013-05-27 07:24:14 UTC

REVIEW: http://review.gluster.org/5095 (glusterd-volgen: Enable open-behind based on op-version) posted (#1) for review on release-3.4 by Kaushal M (kaushal)

Comment 18 Anand Avati 2013-05-28 06:25:29 UTC

REVIEW: http://review.gluster.org/4952 (glusterd-volgen: Improve volume op-versions calculation) posted (#6) for review on master by Kaushal M (kaushal)

Comment 19 Anand Avati 2013-05-28 08:50:06 UTC

REVIEW: http://review.gluster.org/5001 (glusterd: Set op-version on startup based on install status) posted (#4) for review on release-3.4 by Kaushal M (kaushal)

Comment 20 Anand Avati 2013-05-28 08:50:30 UTC

REVIEW: http://review.gluster.org/5094 (glusterd-volgen: Improve volume op-versions calculation) posted (#2) for review on release-3.4 by Kaushal M (kaushal)

Comment 21 Anand Avati 2013-05-28 08:51:15 UTC

REVIEW: http://review.gluster.org/5095 (glusterd-volgen: Enable open-behind based on op-version) posted (#2) for review on release-3.4 by Kaushal M (kaushal)

Comment 22 Anand Avati 2013-05-29 05:02:16 UTC

COMMIT: http://review.gluster.org/4866 committed in master by Vijay Bellur (vbellur) 
------
commit 7d0cf52a344e476963fe97e71f86488d5bb17b1c
Author: Kaushal M <kaushal>
Date:   Fri Apr 19 15:16:56 2013 +0530

    glusterd-volgen: Enable open-behind based on op-version
    
    This patch enables the open-behind by default only when the op-version
    allows it. Also the volume op-version calculations take account of this
    enablement.
    
    Change-Id: Idf7a3c274ec4828aafc815cdd1df829ecb853354
    BUG: 954256
    Signed-off-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/4866
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 23 Anand Avati 2013-05-29 10:12:09 UTC

REVIEW: http://review.gluster.org/4952 (glusterd-volgen: Improve volume op-versions calculation) posted (#7) for review on master by Kaushal M (kaushal)

Comment 24 Anand Avati 2013-05-30 06:20:11 UTC

REVIEW: http://review.gluster.org/4952 (glusterd-volgen: Improve volume op-versions calculation) posted (#8) for review on master by Kaushal M (kaushal)

Comment 25 Anand Avati 2013-05-30 06:26:31 UTC

REVIEW: http://review.gluster.org/5001 (glusterd: Set op-version on startup based on install status) posted (#5) for review on release-3.4 by Kaushal M (kaushal)

Comment 26 Anand Avati 2013-05-30 06:26:54 UTC

REVIEW: http://review.gluster.org/5094 (glusterd-volgen: Improve volume op-versions calculation) posted (#3) for review on release-3.4 by Kaushal M (kaushal)

Comment 27 Anand Avati 2013-05-30 06:27:38 UTC

REVIEW: http://review.gluster.org/5095 (glusterd-volgen: Enable open-behind based on op-version) posted (#3) for review on release-3.4 by Kaushal M (kaushal)

Comment 28 Anand Avati 2013-05-31 13:44:15 UTC

COMMIT: http://review.gluster.org/4952 committed in master by Vijay Bellur (vbellur) 
------
commit 599c6b472869cfaf0058e7b169de204450a41948
Author: Kaushal M <kaushal>
Date:   Tue Apr 30 13:03:08 2013 +0530

    glusterd-volgen: Improve volume op-versions calculation
    
    Volume op-versions calculations now take into account if an option,
     a. enables/disables an xlator, or
     b. is a boolean option.
    This prevents op-versions from being updated when a feature is disabled.
    
    Also, correctly close the dynamically loaded xlators in
    xlator_volopt_dynload() and prevent leaks.
    
    Change-Id: I895ddeeec6f6a33e509325f0ce6f01b7aad3cf5c
    BUG: 954256
    Signed-off-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/4952
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 29 Anand Avati 2013-06-05 12:26:04 UTC

COMMIT: http://review.gluster.org/5001 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 6cfc9c7f1d447451dc3d4af02a22058b861235eb
Author: Kaushal M <kaushal>
Date:   Mon Apr 22 12:17:59 2013 +0530

    glusterd: Set op-version on startup based on install status
    
    This is a backport of change
            fa227c0 glusterd: Set op-version on startup based on install status
    from master.
    
    If the current installation of glusterfs doesn't have a stored
    op-version and is,
    a. a fresh install, then set op-version to maximum
    b. an upgrade from release which didn't have op-version support, set it
    to minimum.
    
    The install status is detected using the peer-uuid.
    If both peer-uuid and op-version are not present in the store, the
    installation is fresh.
    If peer-uuid is present, but op-version is absent in the store, the
    installation has been upgraded from a version which didn't support
    op-versions.
    
    By setting the initial op-version as above, we can ensure that
    a. features are not enabled accidentally during upgrades
    b. a fresh install starts with all possible features enabled.
    
    BUG: 954256
    Change-Id: I5cdd0c63fd16ecfa2fede99684da6fd6167823a8
    Signed-off-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/5001
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 30 Anand Avati 2013-06-05 12:27:33 UTC

COMMIT: http://review.gluster.org/5095 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit e59bce74ca3f684c82d028a4166f9fb647e58881
Author: Kaushal M <kaushal>
Date:   Fri Apr 19 15:16:56 2013 +0530

    glusterd-volgen: Enable open-behind based on op-version
    
    Backport of patch on master branch, under review at
            http://review.gluster.org/4866
    
    This patch enables the open-behind by default only when the op-version
    allows it. Also the volume op-version calculations take account of this
    enablement.
    
    BUG: 954256
    Change-Id: Ie739bc23ba90ec2f009feecef28187912a37487c
    Signed-off-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/5095
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 31 Anand Avati 2013-06-05 12:28:03 UTC

COMMIT: http://review.gluster.org/5094 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit fbdbe06a1df2f983f2ec7a3103db932f40653650
Author: Kaushal M <kaushal>
Date:   Tue Apr 30 13:03:08 2013 +0530

    glusterd-volgen: Improve volume op-versions calculation
    
    Backport of patch on master branch, under review at
            http://review.gluster.org/4952
    
    Volume op-versions calculations now take into account if an option,
     a. enables/disables an xlator, or
     b. is a boolean option.
    
    This prevents op-versions from being updated when a feature is disabled.
    
    BUG: 954256
    Change-Id: Ic68032b9e55a3f0191f8fc3ecd6b5ced385ad943
    Signed-off-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/5094
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 32 Kaushal 2013-07-10 12:54:21 UTC

All the required patches have made it into both master and release-3.4 branches.