Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 954843

Summary: [RFE] webadmin: new domain dialogue crashes when we add a domain -> close the dialogue with the X -> open a new one to add a second domain
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: ovirt-engine-webadmin-portalAssignee: Daniel Erez <derez>
Status: CLOSED DUPLICATE QA Contact: Dafna Ron <dron>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.2.0CC: abaron, acathrow, amureini, derez, ecohen, hateya, iheim, jkt, Rhev-m-bugs, scohen
Target Milestone: ---Keywords: FutureFeature, Improvement
Target Release: 3.5.0Flags: scohen: Triaged+
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-12 15:49:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 954361    
Bug Blocks:    
Attachments:
Description Flags
log none

Description Dafna Ron 2013-04-22 12:51:17 UTC 
Created attachment 738513 [details]
log

Description of problem:

adding a domain -> closing the dialogue with the X -> adding a second domain.
the new domain dialogue will suddenly disappear (looks like crash)

Version-Release number of selected component (if applicable):

sf13.1

How reproducible:

100%

Steps to Reproduce:
1. create 3 iscsi luns and an iscsi cluster with two hosts
2. open the new domain dialogue and log in to all 3 luns
3. expend the first domain -> select the check box -> ok -> once the sand clock starts -> close the dialogue with X
4. open a new domain dialogue -> start creating a new domain (select the DC atc)
 
Actual results:

the new domain dialogue disappears (looks like a crash)

Expected results:

since closing the dialogue does not cancel the action we should be able to create several domains like that and the new dialogue should not crash.
either way, dialogue should never disappear the way it does.  

Additional info: engine log


2013-04-22 15:39:56,231 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.GetDeviceListVDSCommand] (ajp-/127.0.0.1:8702-3) START, GetDeviceListVDSCommand(HostName = cougar01, HostId = 42248b17-62ab-4f1f-88e0-5f24b445d00b, storageType=ISCSI), log id: 4fde853f
2013-04-22 15:39:59,159 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.GetDeviceListVDSCommand] (ajp-/127.0.0.1:8702-3) FINISH, GetDeviceListVDSCommand, return: [org.ovirt.engine.core.common.businessentities.LUNs@5e550e4b, org.ovirt.engine.core.common.businessentities.LUNs@913bc119, org.ovirt.engine.core.common.businessentities.LUNs@62b8632e], log id: 4fde853f
2013-04-22 15:40:06,257 INFO  [org.ovirt.engine.core.bll.storage.AddSANStorageDomainCommand] (ajp-/127.0.0.1:8702-2) [677de470] Running command: AddSANStorageDomainCommand internal: false. Entities affected :  ID: aaa00000-0000-0000-0000-123456789aaa Type: System
2013-04-22 15:40:06,265 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.CreateVGVDSCommand] (ajp-/127.0.0.1:8702-2) [677de470] START, CreateVGVDSCommand(HostName = cougar01, HostId = 42248b17-62ab-4f1f-88e0-5f24b445d00b, storageDomainId=62f382b7-5512-4000-a260-1ee7728484cb, deviceList=[1Dafna-021366551], force=false), log id: 292c923f
2013-04-22 15:40:07,716 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.CreateVGVDSCommand] (ajp-/127.0.0.1:8702-2) [677de470] FINISH, CreateVGVDSCommand, return: QCHwh7-sBBH-FF0I-xa0A-GtZb-C2NE-RMmXKV, log id: 292c923f
2013-04-22 15:40:07,719 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.CreateStorageDomainVDSCommand] (ajp-/127.0.0.1:8702-2) [677de470] START, CreateStorageDomainVDSCommand(HostName = cougar01, HostId = 42248b17-62ab-4f1f-88e0-5f24b445d00b, storageDomain=org.ovirt.engine.core.common.businessentities.StorageDomainStatic@945bb439, args=QCHwh7-sBBH-FF0I-xa0A-GtZb-C2NE-RMmXKV), log id: 47ba1605
2013-04-22 15:40:12,958 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.GetDeviceListVDSCommand] (ajp-/127.0.0.1:8702-9) START, GetDeviceListVDSCommand(HostName = cougar01, HostId = 42248b17-62ab-4f1f-88e0-5f24b445d00b, storageType=ISCSI), log id: 7f687e00
2013-04-22 15:40:15,539 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.CreateStorageDomainVDSCommand] (ajp-/127.0.0.1:8702-2) [677de470] FINISH, CreateStorageDomainVDSCommand, log id: 47ba1605
2013-04-22 15:40:15,543 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.GetStorageDomainStatsVDSCommand] (ajp-/127.0.0.1:8702-2) [677de470] START, GetStorageDomainStatsVDSCommand(HostName = cougar01, HostId = 42248b17-62ab-4f1f-88e0-5f24b445d00b, storageDomainId=62f382b7-5512-4000-a260-1ee7728484cb), log id: f5c3f70
2013-04-22 15:40:15,888 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.GetDeviceListVDSCommand] (ajp-/127.0.0.1:8702-9) FINISH, GetDeviceListVDSCommand, return: [org.ovirt.engine.core.common.businessentities.LUNs@5e550e4b, org.ovirt.engine.core.common.businessentities.LUNs@1f9db398, org.ovirt.engine.core.common.businessentities.LUNs@62b8632e], log id: 7f687e00
2013-04-22 15:40:15,929 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.GetStorageDomainStatsVDSCommand] (ajp-/127.0.0.1:8702-2) [677de470] FINISH, GetStorageDomainStatsVDSCommand, return: org.ovirt.engine.core.common.businessentities.storage_domains@8e306253, log id: f5c3f70
2013-04-22 15:40:15,936 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand] (ajp-/127.0.0.1:8702-2) [677de470] START, GetVGInfoVDSCommand(HostName = cougar01, HostId = 42248b17-62ab-4f1f-88e0-5f24b445d00b, VGID=QCHwh7-sBBH-FF0I-xa0A-GtZb-C2NE-RMmXKV), log id: 4691cbd8
2013-04-22 15:40:16,312 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand] (ajp-/127.0.0.1:8702-2) [677de470] FINISH, GetVGInfoVDSCommand, return: [org.ovirt.engine.core.common.businessentities.LUNs@62131bd8], log id: 4691cbd8
Comment 1 Daniel Erez 2013-07-28 09:54:42 UTC 
The underlining issue is similar to bug 954361.
I.e. the problem is that the UI handles storage domain creation as a complex action - the UI calls three actions consequentially: AddStorageServerConnection, AddNFSStorageDomain, RemoveStorageServerConnection. In order to fix such issues described in the bugs, these actions should be consolidated to a single backend command which could handle error flows.
Comment 4 Allon Mureinik 2013-11-07 13:35:37 UTC 
Daniel, is this still relevant with the recent changes you've made?
Comment 5 Daniel Erez 2013-11-07 13:45:23 UTC 
Yes, we still haven't replaced the 'UI transactions' as described in comment 1.
Comment 6 Ayal Baron 2014-01-09 20:26:41 UTC 
Daniel, why is this not a duplicate of bug 954361?
Comment 7 Daniel Erez 2014-01-09 20:49:18 UTC 
(In reply to Ayal Baron from comment #6)
> Daniel, why is this not a duplicate of bug 954361?

The scenarios and impact are different though both requires the same fix (as described in comment #1). So we can leave this bug as 'Depends On' the RFE or close as duplicate.
Comment 8 Daniel Erez 2014-01-12 15:49:05 UTC 
After discussing with Ayal, will be tested along with bug 954361.

*** This bug has been marked as a duplicate of bug 954361 ***