Bug 955265 - smstools package should be built with PIE flags
Summary: smstools package should be built with PIE flags
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: smstools
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Patrick C. F. Ernzer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-22 16:56 UTC by Dhiru Kholia
Modified: 2014-03-25 03:44 UTC (History)
3 users (show)

Fixed In Version: smstools-3.1.15-6.fc18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-01 04:22:01 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
this should enable PIE (8.42 KB, text/x-rpm-spec)
2013-05-06 05:41 UTC, Dhiru Kholia
no flags Details

Description Dhiru Kholia 2013-04-22 16:56:51 UTC
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently smstools is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

smstools-3.1.15-4.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py smstools-3.1.15-4.fc19.x86_64.rpm
smstools,smstools-3.1.15-4.fc19.x86_64.rpm,/usr/sbin/smsd,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip

Comment 1 Fedora Update System 2013-04-25 10:06:40 UTC
smstools-3.1.15-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/smstools-3.1.15-5.fc19

Comment 2 Fedora Update System 2013-04-25 16:46:48 UTC
Package smstools-3.1.15-5.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing smstools-3.1.15-5.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-6614/smstools-3.1.15-5.fc19
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2013-05-01 04:22:02 UTC
smstools-3.1.15-5.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 4 Dhiru Kholia 2013-05-06 05:41:05 UTC
$ scanner.py smstools-3.1.15-5.fc18.x86_64.rpm
smstools,smstools-3.1.15-5.fc18.x86_64.rpm,/usr/sbin/smsd,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip

So the build is still "buggy".

Comment 5 Dhiru Kholia 2013-05-06 05:41:46 UTC
Created attachment 743968 [details]
this should enable PIE

Comment 6 Dhiru Kholia 2013-05-06 05:42:34 UTC
Please see attachment for a fix.

Comment 7 Fedora Update System 2013-05-23 14:15:23 UTC
smstools-3.1.15-6.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/smstools-3.1.15-6.fc19

Comment 8 Fedora Update System 2013-05-23 14:33:30 UTC
smstools-3.1.15-6.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/smstools-3.1.15-6.fc18

Comment 9 Fedora Update System 2013-06-07 23:52:06 UTC
smstools-3.1.15-6.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2013-06-08 03:32:46 UTC
smstools-3.1.15-6.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.