Bug 955283 - glusterfs package should be built with PIE flags
Summary: glusterfs package should be built with PIE flags
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: glusterfs
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-22 17:19 UTC by Dhiru Kholia
Modified: 2014-03-25 03:44 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.3.1-15.fc18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-22 01:26:20 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dhiru Kholia 2013-04-22 17:19:07 UTC
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently glusterfs is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

glusterfs-server-3.4.0-0.1.alpha2.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py glusterfs-server-3.4.0-0.1.alpha2.fc19.x86_64.rpm
glusterfs-server,glusterfs-server-3.4.0-0.1.alpha2.fc19.x86_64.rpm,/usr/sbin/gluster,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Disabled,CATEGORY=network-ip

Comment 1 Kaleb KEITHLEY 2013-05-13 12:45:49 UTC
> However, currently glusterfs is not being built with PIE flags. This is a
> clear violation of the packaging guidelines.

It also says: 

FESCo maintains a «list of packages» [at http://fedoraproject.org/wiki/Hardened_Packages] that MUST have PIE turned on. Other packages may enable the flags at the maintainer's discretion. (The list of packages reiterates that other packages need only enable the flags at the maintainer's discretion.)

Since glusterfs is not on this list and I only need to use this at my discretion then I'd venture to say it's not a violation and at most a "nice to have."

That aside, it is a good nice to have and will be addressed very shortly in new koji builds. In the future, I think it'd be better/nicer/friendlier to skip the hyperbole. (TBH, it detracts from your message.)

And I strongly suggest that someone clean up the ambiguous language in the wiki!

Comment 2 Fedora Update System 2013-05-13 13:37:24 UTC
glusterfs-3.3.1-15.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/glusterfs-3.3.1-15.fc18

Comment 3 Fedora Update System 2013-05-14 01:26:27 UTC
Package glusterfs-3.3.1-15.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing glusterfs-3.3.1-15.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-8075/glusterfs-3.3.1-15.fc18
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2013-05-22 01:26:20 UTC
glusterfs-3.3.1-15.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.