Description of problem: http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST enable the PIE compiler flags if your package is long running ...". However, currently novacom-server is not being built with PIE flags. This is a clear violation of the packaging guidelines. This issue (in its wider scope) is being discussed at, https://fedorahosted.org/fesco/ticket/1104 https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html Version-Release number of selected component (if applicable): novacom-server-1.1.0-0.8.rc1.fc19.x86_64.rpm How reproducible: You can use following programs to check if a package is hardened: http://people.redhat.com/sgrubb/files/rpm-chksec OR https://github.com/kholia/checksec Steps to Reproduce: Get scanner.py from https://github.com/kholia/checksec $ ./scanner.py novacom-server-1.1.0-0.8.rc1.fc19.x86_64.rpm novacom-server,novacom-server-1.1.0-0.8.rc1.fc19.x86_64.rpm,/usr/bin/novacomd,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Ok, now I'm really confused. I thought I had turned on the hardened build by setting %global _hardened_build 1 in the spec, but at least according to rpm-chksec, it still doesn't have PIE enabled. I've even tried manually adding -fPIE, but it seems to be having no effect. Do you have any idea what I'm doing wrong?
Created attachment 739512 [details] this should enable PIE
Using " %{?__global_ldflags}" should be better (at least that is what I was told). Before using the attached patched .spec file, I would recommend getting it reviewed.
Jonathan, Does the attached patched .spec file works?
novacom-server-1.1.0-0.10.rc1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/novacom-server-1.1.0-0.10.rc1.fc20
novacom-server-1.1.0-0.10.rc1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/novacom-server-1.1.0-0.10.rc1.fc19
Package novacom-server-1.1.0-0.10.rc1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing novacom-server-1.1.0-0.10.rc1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-1456/novacom-server-1.1.0-0.10.rc1.fc20 then log in and leave karma (feedback).
novacom-server-1.1.0-0.10.rc1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
novacom-server-1.1.0-0.10.rc1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.