RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 955537 - help info description for vol-upload is incorrect
Summary: help info description for vol-upload is incorrect
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Ján Tomko
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 955539
TreeView+ depends on / blocked
 
Reported: 2013-04-23 09:13 UTC by Cui Lei
Modified: 2014-06-18 00:48 UTC (History)
5 users (show)

Fixed In Version: libvirt-1.0.5-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 955539 (view as bug list)
Environment:
Last Closed: 2014-06-13 10:59:14 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Cui Lei 2013-04-23 09:13:35 UTC 
Description of problem:
#virsh help vol-upload
...
DESCRIPTION
    Upload a file into a volume
...
#man virsh and check the vol-upload part
"Upload the contents of local-file to a storage volume."

Help info description for vol-upload is incorrect, should use 'contents' instead of 'file', and consistent with manual doc



'vol-download' will not wipe the volume. We can see it from 'virsh-volume.c' and 'libvirt.c'(virStorageVolDownload).
But the manpage says: vol-name-or-key-or-path is the name or key or path of the volume to wipe.
In fact, ‘vol-upload’ will wipe the volume.

Version-Release number of selected component (if applicable):
libvirt-1.0.4-1.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. #virsh help vol-upload
2. #man virsh and check the vol-upload part

Actual results:
Both of the description of virsh vol-upload are different, help info description is incorrect
Expected results:
Should use 'contents' instead of 'file', and consistent with manual doc

Additional info
Comment 2 Ján Tomko 2013-04-30 12:41:51 UTC 
man page has been fixed fixed upstream by:
commit 11e295705a4c19aee71ab6bb9334b31174adbcd1
Author:     Martin Kletzander <mkletzan>
AuthorDate: 2013-04-02 14:33:49 +0200
Commit:     Martin Kletzander <mkletzan>
CommitDate: 2013-04-02 17:06:40 +0200

    manual: Fix copy-paste errors
    
    Descriptions for vol-download and vol-upload didn't make much sense.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=923613


help description has been fixed by:
commit ce284bb56dce0c35ec3e3bf3f019bca67ae0fab8
Author:     Ján Tomko <jtomko>
AuthorDate: 2013-04-30 14:19:49 +0200
Commit:     Ján Tomko <jtomko>
CommitDate: 2013-04-30 14:19:49 +0200

    virsh: clarify vol-{down,up}load description
    
    Mention file/volume contents instead of just 'file'/'volume'.
Comment 3 Huang Wenlong 2013-05-07 02:41:12 UTC 
Verify this bug with:
libvirt-1.0.5-1.el7.x86_64

# virsh help vol-upload
  NAME
    vol-upload - upload file contents to a volume

  SYNOPSIS
    vol-upload <vol> <file> [--pool <string>] [--offset <number>] [--length <number>]

  DESCRIPTION
    Upload file contents to a volume

#man virsh
 
vol-upload [--pool pool-or-uuid] [--offset bytes] [--length bytes] vol-name-or-key-or-path local-file
           Upload the contents of local-file to a storage volume.  --pool pool-or-uuid is the name or UUID of the storage
           pool the volume is in.  vol-name-or-key-or-path is the name or key or path of the volume where the file will be
           uploaded.  --offset is the position in the storage volume at which to start writing the data. --length is an
           upper bound of the amount of data to be uploaded.  An error will occur if the local-file is greater than the
           specified length.

#man virsh 
vol-download [--pool pool-or-uuid] [--offset bytes] [--length bytes] vol-name-or-key-or-path local-file
           Download the contents of a storage volume to local-file.  --pool pool-or-uuid is the name or UUID of the storage
           pool the volume is in.  vol-name-or-key-or-path is the name or key or path of the volume to download.  --offset
           is the position in the storage volume at which to start reading the data. --length is an upper bound of the
           amount of data to be downloaded.
Comment 4 Ludek Smid 2014-06-13 10:59:14 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.
Note You need to log in before you can comment on or make changes to this bug.