Bug 956376 - Can not edit class comments
Summary: Can not edit class comments
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: squeak-vm
Version: 18
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Jaroslav Škarvada
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-24 20:41 UTC by Michal Minar
Modified: 2015-12-22 12:55 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-12-22 12:55:24 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
add explicit flush at the end of nextChunkPut: (792 bytes, patch)
2013-04-26 09:29 UTC, Pavel Krivanek
no flags Details | Diff

Description Michal Minar 2013-04-24 20:41:25 UTC
Description of problem:
  "Error: RemoteString past end of file" pops up any time, when I try
  to edit class comment of any class.


Version-Release number of selected component (if applicable):
  squeak-image-4.3-1.fc18.noarch
  squeak-vm-4.10.2.2614-7.fc18.x86_64

How reproducible:
  ALWAYS - with any image (I've tried newest stable and devel with same results)

Steps to Reproduce:
1. run inisqueak in cur. directory
2. run squeak
3. open browser
4. choose any class or make a new one
5. edit its class comment (the field under the line below class definition, or the field accessible with '?' button)
6. try to save it
  
Actual results:
  Debugger with "Error: RemoteString past end of file" pops up. And again and again until the browser window is closed.

Expected results:
  class comment saved without error

Additional info:
  I've tried the same image on windows 7, where it works like expected.

Comment 1 Pavel Krivanek 2013-04-25 08:23:58 UTC
It surely is no problem of the Fedora package but the mainstream problem because it fails with Squeak files downloaded directly from the squeak.org too. Moreover it fails on Linux even in Pharo on their own image and vm. 
This method (RemoteString>>text) seems to be copied from Pharo, if you will revert the oldest Squeak original version, it will work.

Comment 2 Michal Minar 2013-04-25 08:34:16 UTC
Thanks Pavel. I've asked some guys on freenode's #squeak channel and it seemed like they don't know about it. They run it on linux fine (Ubuntu :-)), so I presumed it is a Fedora specific problem.

Comment 3 Pavel Krivanek 2013-04-25 09:12:38 UTC
I tried the same Pharo vm and image on 32-bit Debian and it works there. What Fedora version and architecture do you use?

Comment 4 Michal Minar 2013-04-25 09:14:29 UTC
It's in the bug info: Fedora-18 x86_64 .. Haven't tried anything else except win7.

Comment 5 Pavel Krivanek 2013-04-25 09:19:38 UTC
Sorry, I discovered that a moment after. The same configuration as mine. It is very interesting because Pharo vm is derived from CogVM and is not fully 64-bit application. And is very different from the vm used in squeak-vm package.

Comment 6 Pavel Krivanek 2013-04-25 09:21:35 UTC
I've got a report that it works on 64-bit Ubuntu 12.04 (Pharo).

Comment 7 Jaroslav Škarvada 2013-04-25 14:03:46 UTC
(In reply to comment #6)
> I've got a report that it works on 64-bit Ubuntu 12.04 (Pharo).

Interesting, I checked with Pharo on F18, i.e.: get.pharo.org:
$ sh ./pharo-ui ./Pharo.image
Error: RemoteString past end of file

So it seems you were right in the comment 1. Now I am looking more deep on it, why this is Fedora specific :)

Comment 8 Jaroslav Škarvada 2013-04-25 14:41:33 UTC
(In reply to comment #7)
This does work on F17, but it doesn't work on F18, F19. Maybe glibc issue?

Comment 9 Jaroslav Škarvada 2013-04-25 16:20:01 UTC
(In reply to comment #6)
> I've got a report that it works on 64-bit Ubuntu 12.04 (Pharo).

I guess the reproducer needs glibc-2.16 and up, IMHO 12.04 has 2.15 same as F17, so I guess this would be also reproducible on Ubuntu 13.04.

Comment 10 Pavel Krivanek 2013-04-26 09:29:28 UTC
Created attachment 740314 [details]
add explicit flush at the end of nextChunkPut:

we need to add explicit flush at the end of WriteStream>>nextChunkPut: method

Comment 11 Frank Shearar 2013-04-26 10:24:25 UTC
Squeaks 4.3, 4.4 and 4.5 should now work.

Comment 12 Michal Minar 2013-04-29 12:04:27 UTC
Thanks Pavel, it works like a charm (for me).
And thank you Frank for a quick fix in trunk, although you reverted it some time later.

Comment 13 Frank Shearar 2013-04-29 12:50:29 UTC
That's correct: patching #nextChunkPut: almost certainly masks the underlying problem, and the more experience Squeakers strongly suggested I revert. I'll post updates as they happen.

Comment 14 Fedora End Of Life 2013-12-21 15:29:48 UTC
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 15 Fedora End Of Life 2014-02-05 23:08:32 UTC
Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 16 dcorking 2014-08-02 05:37:41 UTC
This bug still applies in Fedora 20. Please re-open it. Pavel's workaround has been applied upstream to Squeak 4.6, so the present bug could be closed again when the fix has been backported to squeak-image in Fedora 20.

Has the underlying glibc issue been identified and reported (either to Fedora glibc or upstream)?

Comment 17 Jan Kurik 2015-12-22 11:34:49 UTC
This bug is currently assigned to an unsupported release. If you think this bug is still valid and should remain open, please re-assign it to a supported release (F22, F23) or to rawhide.

Bugs which will be assigned to an unsupported release are going to be closed as EOL (End Of Life) on January 26th, 2016.

Comment 18 Jaroslav Škarvada 2015-12-22 12:55:24 UTC
There is squeak-image v 4.5 in f23, so I think it should work. If not please reopen against f23 or rawhide.


Note You need to log in before you can comment on or make changes to this bug.