Bug 956573

Below are the code snippets for the highlighted log messages


-----------------------
*** INFO  [org.picketlink.identity.federation] (http-executor-threads - 18) PLFED000201: Keystore is null. so setting it up

In federation/picketlink-core/src/main/java/org/picketlink/identity/federation/core/impl/KeyStoreKeyManager.java#216

initKeyStore is invoked in numerous places as a safety precaution

216     private void initKeyStore() throws GeneralSecurityException, IOException {
217         if (ks == null) {
218             logger.keyStoreSetup();   
219             this.setUpKeyStore();
220         }
221 
222         if (ks == null)
223             throw logger.keyStoreNullStore();
224     }


It's set here:

290     private void setUpKeyStore() throws GeneralSecurityException, IOException {
291         // Keystore URL/Pass can be either by configuration or on the HTTPS connector
292         if (this.keyStoreURL == null) {
293             this.keyStoreURL = SecurityActions.getProperty("javax.net.ssl.keyStore", null);
294         }
295         if (this.keyStorePass == null) {
296             this.keyStorePass = SecurityActions.getProperty("javax.net.ssl.keyStorePassword", null);
297         }
298 
299         InputStream is = this.getKeyStoreInputStream(this.keyStoreURL);
300         ks = KeyStoreUtil.getKeyStore(is, keyStorePass.toCharArray());
301     }

which only gets called from initKeyStore()

Once "ks" is set, it stays set. 

*** ERROR [org.picketlink.identity.federation] (http-executor-threads - 99) PLFED000244: Mapping Context returned is null

federation/picketlink-bindings/picketlink-jbas-common/src/main/java/org/picketlink/identity/federation/bindings/jboss/attribute/JBossAppServerAttributeManager.java#063


062             if (mc == null) {
063                 logger.mappingContextNull();
064                 return attributeMap;
065             }

   [else use the mapping context and]

091         return attributeMap;
092     }


federation/picketlink-bindings/picketlink-jbas-common/src/main/java/org/picketlink/identity/federation/bindings/jboss/auth/mapping/STSGroupMappingProvider.java#087

083     public void performMapping(Map<String, Object> contextMap, RoleGroup Group) {
084         logger.debug("performMapping with map as " + contextMap);
085 
086         if (contextMap == null) {
087             logger.mappingContextNull();
088         }

federation/picketlink-bindings/picketlink-jbas-common/src/main/java/org/picketlink/identity/federation/bindings/jboss/auth/mapping/STSPrincipalMappingProvider.java#058

identical usage.

*** ERROR [org.picketlink.identity.federation] (MSC service thread 1-2) PLFED000238: AttributeManager set to

federation/picketlink-core/src/main/java/org/picketlink/identity/federation/web/handlers/saml2/SAML2AttributeHandler.java#157

153     private void insantiateAttributeManager(String attribStr) throws ConfigurationException {
154         if (attribStr != null && !"".equals(attribStr)) {
155             try {
156                 attribManager = (AttributeManager) SecurityActions.loadClass(getClass(), attribStr).newInstance();
157                 logger.samlHandlerAttributeSetup(this.attribManager.getClass().getName());
158             } catch (Exception e) {
159                 logger.attributeProviderInstationError(e);
160                 throw logger.configurationError(e);
161             }
162         }
163     }
-----------------------

EAP 6.2.0 still has the following messages
---
2013-04-08 15:56:40,180 INFO  [org.picketlink.identity.federation] 
(http-executor-threads - 18) PLFED000201: Keystore is null. so setting it up
.. ..
2013-04-08 15:49:38,426 ERROR [org.picketlink.identity.federation] 
(http-executor-threads - 99) PLFED000244: Mapping Context returned is null
---

are there plans to change the log level of these to DEBUG?


"PLFED000238: AttributeManager set to" is now set to TRACE level in EAP 6.2.0

Verified in EAP 6.4.3.CP.CR1

Retroactively bulk-closing issues from released EAP 6.4 cummulative patches.

Retroactively bulk-closing issues from released EAP 6.4 cumulative patches.