Spec URL: http://cicku.me/erebus.spec SRPM URL: http://cicku.me/erebus-0.7-1.fc20.src.rpm Description: Erebus is an Open Source RPG (Role-Playing Game), for PCs, smartphones, tablets and handhelds. Fedora Account System Username: cicku
Koji success: http://koji.fedoraproject.org/koji/taskinfo?taskID=5316703
Hi Christopher. Just some initial comments: - I see some changes about FHS fixes. In my opinion, with a single modification into 'deployment.pri' file, you can resolve all at one time ;) - .desktop file is already in the source archive; why do you add another one as Source1 ? - %{_datadir}/%{name} directory must be owned by the package - In erebus_source.txt file, the developer says: >The source code is released under the GPL v3 or later. >Please contact me if you have suggestions, bug fixes or whatever: mark dot harman >at ntlworld dot com . I don't see any license file included, apart from docs/gpl.txt file that is not the GPLv3+ text file.
(In reply to Antonio Trande from comment #2) > Hi Christopher. > Just some initial comments: > > - I see some changes about FHS fixes. In my opinion, with a single > modification into 'deployment.pri' file, you can resolve all at one time ;) Thanks! I'm not familiar with Qt, now I remember this~ > - .desktop file is already in the source archive; why do you add another one > as Source1 ? Its bundled desktop file is invalid and doesn't match Fedora's standard, I think rewriting one is better than patching. > - %{_datadir}/%{name} directory must be owned by the package You mean I should remove the asterisk? > - In erebus_source.txt file, the developer says: > > >The source code is released under the GPL v3 or later. > >Please contact me if you have suggestions, bug fixes or whatever: mark dot harman >at ntlworld dot com . > > I don't see any license file included, apart from docs/gpl.txt file that is > not the GPLv3+ text file. Ok, I've mailed the author, hope he can fix that. Thanks!
(In reply to Christopher Meng from comment #3) > > - .desktop file is already in the source archive; why do you add another one > > as Source1 ? > > Its bundled desktop file is invalid and doesn't match Fedora's standard, I > think rewriting one is better than patching. See 'desktop-file-edit' manpage. > > > - %{_datadir}/%{name} directory must be owned by the package > > You mean I should remove the asterisk? No. http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Forgetting_to_Include_a_Toplevel_Directory > > > - In erebus_source.txt file, the developer says: > > > > >The source code is released under the GPL v3 or later. > > >Please contact me if you have suggestions, bug fixes or whatever: mark dot harman >at ntlworld dot com . > > > > I don't see any license file included, apart from docs/gpl.txt file that is > > not the GPLv3+ text file. > > Ok, I've mailed the author, hope he can fix that. > > Thanks! This is very important.
$ LANG=C wget -c http://cicku.me/erebus.spec --2014-04-25 16:50:09-- http://cicku.me/erebus.spec Resolving cicku.me (cicku.me)... 37.59.54.136 Connecting to cicku.me (cicku.me)|37.59.54.136|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2014-04-25 16:50:09 ERROR 404: Not Found.
Spec throws a 404 not found. Are you still interested in this review?
The answer is most likely no, cicku is MIA.
Well, there has been no response for a long time now so I think this can be closed as FE-DEADREVIEW. I left it open so long because I have toyed with the idea of packaging erebus myself... however I'm not sure if/when I'll get around to it, so I may as well just close the ticket now.