Bug 956669 - Review Request: erebus - 2D real-time Role-Playing Game
Review Request: erebus - 2D real-time Role-Playing Game
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
NotReady
:
Depends On:
Blocks: FE-GAMESIG
  Show dependency treegraph
 
Reported: 2013-04-25 08:14 EDT by Christopher Meng
Modified: 2016-08-06 19:11 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
anto.trande: needinfo+


Attachments (Terms of Use)

  None (edit)
Description Christopher Meng 2013-04-25 08:14:51 EDT
Spec URL: http://cicku.me/erebus.spec
SRPM URL: http://cicku.me/erebus-0.7-1.fc20.src.rpm
Description: Erebus is an Open Source RPG (Role-Playing Game), for PCs, smartphones, tablets and handhelds.
Fedora Account System Username: cicku
Comment 1 Christopher Meng 2013-04-30 02:13:35 EDT
Koji success:

http://koji.fedoraproject.org/koji/taskinfo?taskID=5316703
Comment 2 Antonio Trande 2013-05-19 18:06:33 EDT
Hi Christopher.
Just some initial comments:

- I see some changes about FHS fixes. In my opinion, with a single modification into 'deployment.pri' file, you can resolve all at one time ;)

- .desktop file is already in the source archive; why do you add another one as Source1 ?

- %{_datadir}/%{name} directory must be owned by the package

- In erebus_source.txt file, the developer says:

>The source code is released under the GPL v3 or later.
>Please contact me if you have suggestions, bug fixes or whatever: mark dot harman >at ntlworld dot com .

I don't see any license file included, apart from docs/gpl.txt file that is not the GPLv3+ text file.
Comment 3 Christopher Meng 2013-05-20 05:58:30 EDT
(In reply to Antonio Trande from comment #2)
> Hi Christopher.
> Just some initial comments:
> 
> - I see some changes about FHS fixes. In my opinion, with a single
> modification into 'deployment.pri' file, you can resolve all at one time ;)

Thanks! I'm not familiar with Qt, now I remember this~

> - .desktop file is already in the source archive; why do you add another one
> as Source1 ?

Its bundled desktop file is invalid and doesn't match Fedora's standard, I think rewriting one is better than patching.

> - %{_datadir}/%{name} directory must be owned by the package

You mean I should remove the asterisk?

> - In erebus_source.txt file, the developer says:
> 
> >The source code is released under the GPL v3 or later.
> >Please contact me if you have suggestions, bug fixes or whatever: mark dot harman >at ntlworld dot com .
> 
> I don't see any license file included, apart from docs/gpl.txt file that is
> not the GPLv3+ text file.

Ok, I've mailed the author, hope he can fix that.

Thanks!
Comment 4 Antonio Trande 2013-05-20 12:07:42 EDT
(In reply to Christopher Meng from comment #3)
> > - .desktop file is already in the source archive; why do you add another one
> > as Source1 ?
> 
> Its bundled desktop file is invalid and doesn't match Fedora's standard, I
> think rewriting one is better than patching.

See 'desktop-file-edit' manpage.

> 
> > - %{_datadir}/%{name} directory must be owned by the package
> 
> You mean I should remove the asterisk?

No.
http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Forgetting_to_Include_a_Toplevel_Directory

> 
> > - In erebus_source.txt file, the developer says:
> > 
> > >The source code is released under the GPL v3 or later.
> > >Please contact me if you have suggestions, bug fixes or whatever: mark dot harman >at ntlworld dot com .
> > 
> > I don't see any license file included, apart from docs/gpl.txt file that is
> > not the GPLv3+ text file.
> 
> Ok, I've mailed the author, hope he can fix that.
> 
> Thanks!

This is very important.
Comment 5 Pavel Alexeev 2014-04-25 08:50:26 EDT
$ LANG=C wget -c http://cicku.me/erebus.spec
--2014-04-25 16:50:09--  http://cicku.me/erebus.spec
Resolving cicku.me (cicku.me)... 37.59.54.136
Connecting to cicku.me (cicku.me)|37.59.54.136|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2014-04-25 16:50:09 ERROR 404: Not Found.

Note You need to log in before you can comment on or make changes to this bug.