Bug 956772 - gnome-desktop3: EDID parser ignores EDID length
Summary: gnome-desktop3: EDID parser ignores EDID length
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-desktop3
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 956729
TreeView+ depends on / blocked
 
Reported: 2013-04-25 15:11 UTC by Florian Weimer
Modified: 2015-09-24 10:50 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-30 00:38:29 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2013-04-25 15:11:51 UTC
The size of the EDID data should be passed into decode_edid (or a replacement API) and the parsers should verify that the length is at least 128.

The caller appears to ensure that the size is divisible by 128, so unless the X server returns a size of 0, the current code shouldn't crash in most cases.

Comment 1 Richard Hughes 2013-07-30 09:38:24 UTC
(In reply to Florian Weimer from comment #0)
> The size of the EDID data should be passed into decode_edid (or a
> replacement API) and the parsers should verify that the length is at least
> 128.

We already check for a multiple of 128 bytes in read_edid_data(), and I don't think XRRGetOutputProperty will return with the property if it has a zero size, but to be sure I've added an explicit check in this commit:

commit 80b400b717bc556fcd42f93b297410d3c4f56631
Author: Richard Hughes <richard>
Date:   Tue Jul 30 10:37:50 2013 +0100

    Ensure EDID is at least 128 bytes and a multiple of 128 bytes
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=956772

Comment 2 Fedora End Of Life 2013-09-16 16:40:05 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 3 Fedora End Of Life 2015-05-29 09:01:19 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Fedora End Of Life 2015-06-30 00:38:29 UTC
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.