RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 956968 - redundant command "nodedev-dettach" while running "virsh help nodedev"
Summary: redundant command "nodedev-dettach" while running "virsh help nodedev"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.4
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Eric Blake
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 956966
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-26 06:16 UTC by Xuesong Zhang
Modified: 2014-10-14 04:15 UTC (History)
5 users (show)

Fixed In Version: libvirt-0.10.2-34.el6
Doc Type: Bug Fix
Doc Text:
Clone Of: 956966
Environment:
Last Closed: 2014-10-14 04:15:59 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:1374 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2014-10-14 08:11:54 UTC

Description Xuesong Zhang 2013-04-26 06:16:44 UTC 
+++ This bug was initially created as a clone of Bug #956966 +++

Description of problem:
There is one redundant command "nodedev-dettach" while running "virsh help nodedev"

Version-Release number of selected component (if applicable):
libvirt-1.0.4-1.1.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. It only show one "nodedev-detach" which run command "virsh help".
# virsh help|grep nodedev
 Node Device (help keyword 'nodedev'):
    nodedev-create                 create a device defined by an XML file on the node
    nodedev-destroy                destroy (stop) a device on the node
    nodedev-detach                 detach node device from its device driver
    nodedev-dumpxml                node device details in XML
    nodedev-list                   enumerate devices on this host
    nodedev-reattach               reattach node device to its device driver
    nodedev-reset                  reset node device

2. It will show both "nodedev-detach" and "nodedev-dettach" while running command "virsh help nodedev".
# virsh help nodedev
 Node Device (help keyword 'nodedev'):
    nodedev-create                 create a device defined by an XML file on the node
    nodedev-destroy                destroy (stop) a device on the node
    nodedev-detach                 detach node device from its device driver
    nodedev-dettach                detach node device from its device driver
    nodedev-dumpxml                node device details in XML
    nodedev-list                   enumerate devices on this host
    nodedev-reattach               reattach node device to its device driver
    nodedev-reset                  reset node device

  
Actual results:
there is noe redundant command "nodedev-dettach" in step2.

Expected results:
The redundant command "nodedev-dettach" should not be remove in step2

Additional info:
This issue also occurred in rhel6.
Comment 2 Eric Blake 2013-04-26 12:01:32 UTC 
rebase will pick up:
commit 117dc4cc8a8993334e8ec512fde40e3f8916da69
Author: Eric Blake <eblake>
Date:   Fri Apr 26 04:20:29 2013 -0600

    virsh: suppress aliases in group help
    
    'virsh help | grep nodedev-det' shows only nodedev-detach, but
    'virsh help nodedev | grep nodedev-det' also shows the old alias
    nodedev-dettach that we intentionally hid in commit af3f9aab.
    
    See also commit 787f4fe and this bug report:
    https://bugzilla.redhat.com/show_bug.cgi?id=956966
    
    * tools/virsh.c (vshCmdGrpHelp): Copy suppression of vshCmdHelp.
Comment 4 Eric Blake 2013-06-05 22:39:19 UTC 
http://post-office.corp.redhat.com/archives/rhvirt-patches/2013-June/msg00027.html if backporting rather than rebasing
Comment 5 Jiri Denemark 2013-06-11 09:56:07 UTC 
We decided not to rebase libvirt in RHEL 6.5 to avoid stability issues
we faced in 6.4. This bug has already been fixed upstream but it is
considered unsuitable for backporting to RHEL 6.5 because at least one
of the following conditions is met:

- this bug requires new API(s), which we cannot introduce without
  rebasing libvirt
- the patches required to address this bug are complex or invasive
  causing the backport to be too risky
- this bug is not important enough to justify backporting non-trivial
  patches for it

Thus I'm pushing this bug to RHEL 6.6 (and setting Upstream keyword to
indicate we have patches upstream) for now. If you don't agree with
this resolution, please, give us reasons which you think are strong
enough for us to reevaluate the decision not to backport patches for
this bug.
Comment 8 Eric Blake 2014-04-28 20:47:03 UTC 
Back in POST:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2014-April/msg00596.html
Comment 10 Xuesong Zhang 2014-05-05 06:43:15 UTC 
Test with libvirt-0.10.2-34.el6.x86_64

Steps:
1. grep "nodedev" in virsh help, only one "nodedev-detach", didn't see "nodedev-dettach" as expected.
# virsh help|grep nodedev
 Node Device (help keyword 'nodedev'):
    nodedev-create                 create a device defined by an XML file on the node
    nodedev-destroy                destroy (stop) a device on the node
    nodedev-detach                 detach node device from its device driver
    nodedev-dumpxml                node device details in XML
    nodedev-list                   enumerate devices on this host
    nodedev-reattach               reattach node device to its device driver
    nodedev-reset                  reset node device


2. check the nodedev series virsh help, , only one "nodedev-detach", didn't see "nodedev-dettach" as expected.
# virsh help nodedev
 Node Device (help keyword 'nodedev'):
    nodedev-create                 create a device defined by an XML file on the node
    nodedev-destroy                destroy (stop) a device on the node
    nodedev-detach                 detach node device from its device driver
    nodedev-dumpxml                node device details in XML
    nodedev-list                   enumerate devices on this host
    nodedev-reattach               reattach node device to its device driver
    nodedev-reset                  reset node device
Comment 12 errata-xmlrpc 2014-10-14 04:15:59 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1374.html
Note You need to log in before you can comment on or make changes to this bug.