Bug 957053 - Review Request: groonga-normalizer-mysql - MySQL compatible normalizer plugin for groonga
Summary: Review Request: groonga-normalizer-mysql - MySQL compatible normalizer plugin...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-26 09:08 UTC by Kentaro Hayashi
Modified: 2013-08-23 23:55 UTC (History)
3 users (show)

Fixed In Version: groonga-normalizer-mysql-1.0.5-4.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-23 23:55:55 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Kentaro Hayashi 2013-04-26 09:08:11 UTC
Spec URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql.spec
SRPM URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql-1.0.3-1.fc18.src.rpm
Description: 
This package provides MySQL compatible normalizer plugin.
You can use NormalizerMySQLGeneralCI and NormalizerMySQLUnicodeCI as normalizer.
Fedora Account System Username: kenhys

Comment 1 Kentaro Hayashi 2013-05-29 06:31:16 UTC
(In reply to HAYASHI Kentaro from comment #0)
> Spec URL:
> http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-
> mysql.spec
> SRPM URL:
> http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-
> mysql-1.0.3-1.fc18.src.rpm
> Description: 
> This package provides MySQL compatible normalizer plugin.
> You can use NormalizerMySQLGeneralCI and NormalizerMySQLUnicodeCI as
> normalizer.
> Fedora Account System Username: kenhys

The new version of groonga-normalizer-mysql has been released.

1.0.3 ->
1.0.4

So, here is the updated spec and SRPM.

Spec URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql.spec
SRPM URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql-1.0.4-1.fc18.src.rpm
Description: 
This package provides MySQL compatible normalizer plugin.
You can use NormalizerMySQLGeneralCI, NormalizerMySQLUnicodeCI and NormalizerMySQLUnicodeCIExceptKanaCIKanaWithVoicedSoundMark as normalizer.
Fedora Account System Username: kenhys

Comment 2 Kentaro Hayashi 2013-07-04 04:48:24 UTC
(In reply to HAYASHI Kentaro from comment #1)
> (In reply to HAYASHI Kentaro from comment #0)
> > Spec URL:
> > http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-
> > mysql.spec
> > SRPM URL:
> > http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-
> > mysql-1.0.3-1.fc18.src.rpm
> > Description: 
> > This package provides MySQL compatible normalizer plugin.
> > You can use NormalizerMySQLGeneralCI and NormalizerMySQLUnicodeCI as
> > normalizer.
> > Fedora Account System Username: kenhys
> 
> The new version of groonga-normalizer-mysql has been released.
> 
> 1.0.3 ->
> 1.0.4
> 
> So, here is the updated spec and SRPM.
> 
> Spec URL:
> http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-
> mysql.spec
> SRPM URL:
> http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-
> mysql-1.0.4-1.fc18.src.rpm
> Description: 
> This package provides MySQL compatible normalizer plugin.
> You can use NormalizerMySQLGeneralCI, NormalizerMySQLUnicodeCI and
> NormalizerMySQLUnicodeCIExceptKanaCIKanaWithVoicedSoundMark as normalizer.
> Fedora Account System Username: kenhys


The new version of groonga-normalizer-mysql has been released.

1.0.4 ->
1.0.5

So, here is the updated spec and SRPM.

Spec URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql.spec
SRPM URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql-1.0.5-1.fc19.src.rpm
Description: 
This package provides MySQL compatible normalizer plugin.
You can use NormalizerMySQLGeneralCI, NormalizerMySQLUnicodeCI and NormalizerMySQLUnicodeCIExceptKanaCIKanaWithVoicedSoundMark as normalizer.
Fedora Account System Username: kenhys

Comment 3 Kentaro Hayashi 2013-07-04 06:09:20 UTC
(In reply to HAYASHI Kentaro from comment #2)
> 
> Spec URL:
> http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-
> mysql.spec
> SRPM URL:
> http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-
> mysql-1.0.5-1.fc19.src.rpm
> Description: 
> This package provides MySQL compatible normalizer plugin.
> You can use NormalizerMySQLGeneralCI, NormalizerMySQLUnicodeCI and
> NormalizerMySQLUnicodeCIExceptKanaCIKanaWithVoicedSoundMark as normalizer.
> Fedora Account System Username: kenhys

Here is the result of rpmlint:

[kenhys@fedora19-amd64 x86_64]$ rpmlint -i groonga-normalizer-mysql-*1.0.5*.rpm
groonga-normalizer-mysql-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

groonga-normalizer-mysql-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

6 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 4 Christopher Meng 2013-07-29 03:16:09 UTC
/var/tmp/rpm-tmp.zY5nBW: line 60: --disable-static: command not found

Fedora 20 rawhide reports error happened.

I'm not sure if this error is related to recent changes in RPM.

My suggestion:

Use:
%configure --disable-static

Comment 5 Kentaro Hayashi 2013-07-29 09:44:19 UTC
Thanks!

I've confirmed koji build again.

http://koji.fedoraproject.org/koji/taskinfo?taskID=5671222

I can't reproduce comment 4 error, but It is true that there is a needless continuous line.

So, here is the updated spec and SRPM.

Spec URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql.spec
SRPM URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql-1.0.5-2.fc19.src.rpm

Comment 6 Michael Schwendt 2013-07-29 10:01:05 UTC
> ExclusiveArch:	%{ix86} x86_64

Since ExlusiveArch and ExcludeArch are related:
https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures


> %package devel
> Requires:       %{name} = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %dir %{_libdir}/groonga
> %dir %{_libdir}/groonga/plugins

These dirs are owned by groonga-libs already, and this package requires groonga-libs. It doesn't need to include these dirs, too.


> %dir %{_libdir}/groonga/plugins/normalizers

Will there be other normalizers? Then this dir could/should be moved into the groonga-libs package.

Comment 7 Kentaro Hayashi 2013-07-30 09:49:33 UTC
Thanks Michael!

(In reply to Michael Schwendt from comment #6)
> > ExclusiveArch:	%{ix86} x86_64
> 
> Since ExlusiveArch and ExcludeArch are related:
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#Architecture_Build_Failures
> 

I guess that 'You shold check koji build listed in ExclusiveArch:', don't you?
If so, here is the result of koji build. It seems OK for me...

$ koji build --scratch rawhide SRPMS/groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm
Uploading srpm: SRPMS/groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm
[====================================] 100% 00:00:02 380.65 KiB 142.80 KiB/sec
Created task: 5677043
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5677043
Watching tasks (this may be safely interrupted)...
5677043 build (rawhide, groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm): open (arm02-builder22.arm.fedoraproject.org)
  5677045 buildArch (groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm, i686): open (buildvm-09.phx2.fedoraproject.org)
  5677044 buildArch (groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm, x86_64): open (buildvm-22.phx2.fedoraproject.org)
  5677044 buildArch (groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm, x86_64): open (buildvm-22.phx2.fedoraproject.org) -> closed
  0 free  2 open  1 done  0 failed
  5677045 buildArch (groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm, i686): open (buildvm-09.phx2.fedoraproject.org) -> closed
  0 free  1 open  2 done  0 failed
5677043 build (rawhide, groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm): open (arm02-builder22.arm.fedoraproject.org) -> closed
  0 free  0 open  3 done  0 failed

5677043 build (rawhide, groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm) completed successfully


> 
> > %package devel
> > Requires:       %{name} = %{version}-%{release}
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> 
> 

I've fixed!

> > %dir %{_libdir}/groonga
> > %dir %{_libdir}/groonga/plugins
> 
> These dirs are owned by groonga-libs already, and this package requires
> groonga-libs. It doesn't need to include these dirs, too.
> 
> 
> > %dir %{_libdir}/groonga/plugins/normalizers
> 
> Will there be other normalizers? Then this dir could/should be moved into
> the groonga-libs package.

As you pointed out, groonga package should own above directories.
So I've just removed it.


Spec URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql.spec
SRPM URL: http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm

Comment 8 Christopher Meng 2013-08-01 03:04:13 UTC
Pretty good.

Only 1 issue, this file is listed twice: /usr/share/doc/groonga-normalizer-mysql

From your spec,

/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/AUTHORS
/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/COPYING
/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/lgpl-2.0.txt
/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/README
/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/README.md

Since you've used %doc magic to mark 3 of them as docs, why not marking the other 2? ;)

Once you've marked files as %doc, no need to list the location again.

But if the makefile has installed docs to the /usr/share/doc/groonga-normalizer-mysql, you can remove the directory by rm and then use %doc magic to mark them again.

Comment 9 Michael Schwendt 2013-08-01 08:28:53 UTC
Alternatively and cleaner, use "install" to place the missing doc files in %{_datadir}/doc/groonga-normalizer-mysql/ and remember that files in /usr/share/doc (%docdir, %_defaultdocdir) are implicitly marked as documentation.

Currently, the packages creates _two_ docdirs because of explicitly added %doc files into the versioned dir that gets created as a result:

$ rpm -qpd groonga-normalizer-mysql-1.0.5-3.fc19.x86_64.rpm 
/usr/share/doc/groonga-normalizer-mysql-1.0.5/AUTHORS
/usr/share/doc/groonga-normalizer-mysql-1.0.5/COPYING
/usr/share/doc/groonga-normalizer-mysql-1.0.5/README
/usr/share/doc/groonga-normalizer-mysql/README.md
/usr/share/doc/groonga-normalizer-mysql/lgpl-2.0.txt

Comment 10 Michael Schwendt 2013-08-02 09:31:48 UTC
> here is the result of koji build. It seems OK for me...

Please add a comment in the spec file above the ExclusiveArch line. The "groonga" package should do that, too. Its %changelog tells:

| - add ExclusiveArch (atomic primitives implemented only for x86)

So, that's the reason why ExclusiveArch is used.

Comment 11 Kentaro Hayashi 2013-08-07 04:28:06 UTC
Thanks Christopher and Michael!!

I've just updated spec file.

1. %doc listing issue (comment 8 and comment 9)
   => fixed to install files and marked explicitly
2. ExclusiveArch (comment 10)
   => added comment in spec file

http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql.spec
http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql-1.0.5-4.fc19.src.rpm

Comment 12 Christopher Meng 2013-08-07 12:19:59 UTC
groonga-normalizer-mysql.i686: W: spurious-executable-perm /usr/share/doc/groonga-normalizer-mysql/AUTHORS
groonga-normalizer-mysql.i686: W: spurious-executable-perm /usr/share/doc/groonga-normalizer-mysql/COPYING
groonga-normalizer-mysql.i686: W: spurious-executable-perm /usr/share/doc/groonga-normalizer-mysql/README

Please fix them before SCM.

APPRVOED.

Comment 13 Kentaro Hayashi 2013-08-07 18:24:37 UTC
Thanks Christopher!

New Package SCM Request
=======================
Package Name: groonga-normalizer-mysql
Short Description: MySQL compatible normalizer plugin for groonga
Owners: kenhys
Branches: f19
InitialCC:

Comment 14 Gwyn Ciesla 2013-08-07 18:40:32 UTC
Git done (by process-git-requests).

Comment 15 Fedora Update System 2013-08-13 15:12:47 UTC
groonga-normalizer-mysql-1.0.5-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/groonga-normalizer-mysql-1.0.5-4.fc19

Comment 16 Fedora Update System 2013-08-15 02:48:59 UTC
groonga-normalizer-mysql-1.0.5-4.fc19 has been pushed to the Fedora 19 testing repository.

Comment 17 Fedora Update System 2013-08-23 23:55:55 UTC
groonga-normalizer-mysql-1.0.5-4.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.