RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 957294 - support username/password for iSCSI pools
Summary: support username/password for iSCSI pools
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: John Ferlan
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 957295 1058598
Blocks: 1059006
TreeView+ depends on / blocked
 
Reported: 2013-04-26 21:59 UTC by Paolo Bonzini
Modified: 2014-06-18 00:49 UTC (History)
6 users (show)

Fixed In Version: libvirt-1.1.1-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1059006 (view as bug list)
Environment:
Last Closed: 2014-06-13 11:56:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Paolo Bonzini 2013-04-26 21:59:16 UTC
iSCSI pools should support username/password authentication using the secret API:

      <pool type="iscsi">
        <name>virtimages</name>
        <source>
          <host name="iscsi.example.com"/>
          <device path="demo-target"/>
          <auth type='chap' login='myname'>
            <secret type='iscsi' usage='mycluster_myname'/>
          </auth>
        </source>
        <target>
          <path>/dev/disk/by-path</path>
        </target>
      </pool>

Right now, the password must be given in clear in the XML, but this is not used (AIUI based on "git grep STORAGE_POOL_AUTH") by libvirt.

Comment 2 Osier Yang 2013-05-28 07:01:46 UTC
Patches posted upstream:

https://www.redhat.com/archives/libvir-list/2013-May/msg01879.html

Comment 3 John Ferlan 2013-07-09 20:12:22 UTC
Reposted upstream with my review comments applied as well as some slight logic change to move the authentication check from the "startPool" to the "findPoolSources" within the storage_backend_iscsi.c:


https://www.redhat.com/archives/libvir-list/2013-July/msg00554.html

Comment 4 John Ferlan 2013-07-23 14:59:31 UTC
Pushed the following change:

http://libvirt.org/git/?p=libvirt.git;a=commit;h=c2257d2ef90fd919aac7557ba02ce6fce8abfcab

which is the followup to the syntax side of the change:

http://libvirt.org/git/?p=libvirt.git;a=commit;h=41ac8184830df9901188f483057b4d4d2afc14f1

Still need to support authentication for autostarted pools

Comment 5 John Ferlan 2013-07-23 17:14:12 UTC
Pushed the following change which will create a qemu connection in order to handle the need for a connection to the secret driver:

http://libvirt.org/git/?p=libvirt.git;a=commit;h=a873b496daad822ed01094f177c67c8f7fcccfd8

based on the following discussion:

https://www.redhat.com/archives/libvir-list/2013-July/msg01423.html


Moved the bug to post, although a mechanism to get a connection to the secret driver without qemu still needs to be devised.

Comment 6 John Ferlan 2013-07-26 13:58:40 UTC
Just to be complete - the following patch is also necessary in order to get the auto start ordering problem solved:

http://libvirt.org/git/?p=libvirt.git;a=commit;h=cefb97fb815c81fc882da752f45effd23bcb9b4b

It made it in time to 1.1.1

Comment 11 Ludek Smid 2014-06-13 11:56:22 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.