Spec URL: http://cicku.me/minised.spec SRPM URL: http://cicku.me/minised-1.14-1.fc20.src.rpm Description: This is a smaller, cheaper, faster SED implementation. Minix uses it. GNU used to use it, until they built their own sed around an extended (some would say over-extended) regexp package. For embedded use we searched for a tiny sed implementation especially for use with the dietlibc and found Eric S. Raymond's sed implementation quite handy. Though it suffered several bugs and was not under active maintenance anymore. After sending a bunch of fixes we agreed to continue maintaining this lovely, historic sed implementation. Fedora Account System Username: cicku
Created attachment 748904 [details] output of fedora-review and manual inspection
Created attachment 748905 [details] corrected spec-file
Hi Christopher! So this was my first review for a Fedora-pkg. On specand srpm rpmlint output was: minised.src: W: spelling-error %description -l en_US Minix -> Mi nix, Mi-nix, Min ix minised.src: W: spelling-error %description -l en_US sed -> tied, ed, seed minised.src: W: spelling-error %description -l en_US dietlibc -> dietetic minised.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9) 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Spelling errors are false positives, but mixed-use-of-\w-and-\t was correct. The Makefile from Sources0 provides a check-target. Why don't you use it in the spec-file? See: http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25check_section Please rebuild srpm with attached fixed spec-file.
(In reply to comment #3) Fixed. NEW SPEC URL: http://cicku.me/minised.spec NEW SRPM URL: http://cicku.me/minised-1.14-2.fc20.src.rpm
Allright, seems fine, now. APPROVED!
New Package SCM Request ======================= Package Name: minised Short Description: A smaller, cheaper, faster SED implementation Owners: cicku Branches: f18 f19
Git done (by process-git-requests).
minised-1.14-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/minised-1.14-2.fc18
minised-1.14-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/minised-1.14-2.fc19
minised-1.14-2.fc19 has been pushed to the Fedora 19 testing repository.
minised-1.14-2.fc18 has been pushed to the Fedora 18 stable repository.
minised-1.14-2.fc19 has been pushed to the Fedora 19 stable repository.
Package Change Request ====================== Package Name: minised New Branches: el6 epel7 Owners: cicku
minised-1.14-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/minised-1.14-4.el6
minised-1.14-4.el6 has been pushed to the Fedora EPEL 6 stable repository.