Spec URL: http://cicku.me/ssh-installkeys.spec SRPM URL: http://cicku.me/ssh-installkeys-1.8-1.fc20.src.rpm Description: This script tries to export ssh public keys to a specified site. It will walk you through generating key pairs if it doesn't find any to export. It handles all the fiddly details like making sure local and remote permissions are correct, and tells you what it's doing if it has to change anything. Fedora Account System Username: cicku
Koji success: http://koji.fedoraproject.org/koji/taskinfo?taskID=5316633
Hi Christopher, Rpmlint ------- Checking: ssh-installkeys-1.8-1.fc18.x86_64.rpm ssh-installkeys.x86_64: E: no-binary 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ssh-installkeys ssh-installkeys.x86_64: E: no-binary 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Can you please fix the above errors? If it's a python script only can be platform indenpendent. BuildArch: noarch
NEW SPEC URL: http://cicku.me/ssh-installkeys.spec NEW SRPM URL: http://cicku.me/ssh-installkeys-1.8-2.fc20.src.rpm
Reviewed manually + fedora-review version 0.4.1 b2e211f [OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review Rpmlint ------- Checking: ssh-installkeys-1.8-2.fc18.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ssh-installkeys 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [OK] MUST: The package must be named according to the Package Naming Guidelines . [OK] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [OK] MUST: The package must meet the Packaging Guidelines . [OK] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines [OK] MUST: The License field in the package spec file must match the actual license [OK] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [OK] MUST: The spec file must be written in American English. [OK] MUST: The spec file for the package MUST be legible [OK] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. CHECKSUM(SHA256) this package : 72c5f55cf3159a19476876f1c84071827be0738e4fd34801ef9252ffebc0fb98 CHECKSUM(SHA256) upstream package : 72c5f55cf3159a19476876f1c84071827be0738e4fd34801ef9252ffebc0fb98 [OK] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [OK] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [OK] MUST: Packages must NOT bundle copies of system libraries [OK] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [OK] MUST: Permissions on files must be set properly. [OK] MUST: Each package must consistently use macros. [OK] MUST: The package must contain code, or permissable content. [OK] MUST: All filenames in rpm packages must be valid UTF-8. [OK] SHOULD: Packager, Vendor, PreReq, Copyright tags should not be in spec file [OK] SHOULD: Sources can be downloaded from URI in Source: tag [OK] SHOULD: Reviewer should test that the package builds in mock. [OK] SHOULD: Buildroot is not present [OK] SHOULD: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [OK] SHOULD: Dist tag is present. [OK] SHOULD: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [OK] SHOULD: Uses parallel make. [OK] SHOULD: SourceX tarball generation or download is documented. [OK] SHOULD: SourceX is a working URL. [OK] SHOULD: Spec use %global instead of %define. Final status: APPROVED.
> > Final status: APPROVED. Oops, I did quick review, before I approve please see my comments: could you please add Buildrequires for python devel? Please check: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
> Oops, I did quick review, before I approve please see my comments: > > could you please add Buildrequires for python devel? > Please check: > http://fedoraproject.org/wiki/Packaging:Python#BuildRequires Looking twice it's not required indeed, the script is not building you are good. Final Status: APPROVED.
New Package SCM Request ======================= Package Name: ssh-installkeys Short Description: A tool for installing ssh keys on remote sites Owners: cicku Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
ssh-installkeys-1.8-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ssh-installkeys-1.8-2.fc19
ssh-installkeys-1.8-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ssh-installkeys-1.8-2.fc18
ssh-installkeys-1.8-2.fc19 has been pushed to the Fedora 19 testing repository.
ssh-installkeys-1.8-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ssh-installkeys-1.8-2.el6
ssh-installkeys-1.8-2.fc18 has been pushed to the Fedora 18 stable repository.
ssh-installkeys-1.8-2.fc19 has been pushed to the Fedora 19 stable repository.
ssh-installkeys-1.8-2.el6 has been pushed to the Fedora EPEL 6 stable repository.