Spec URL: http://fedorapeople.org/~brouhaha/ltunify/ltunify.spec SRPM URL: http://fedorapeople.org/~brouhaha/ltunify/ltunify-0.1-1.fc17.src.rpm Description: ltunify allows pairing, unpairing, and listing information about devices uses a Logitech Unifying Receiver. Fedora Account System Username: brouhaha Spec has a dependency on unifying-receiver-udev package, for which review request #957527 has been separately submitted. However, it is also possible to force installation of the ltunify package without the unifying-receiver-udev package (using the "--nodeps" option to rpm), and to run the utility as root.
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: ltunify-0.1-1.fc18.x86_64.rpm ltunify.x86_64: W: spelling-error %description -l en_US unpairing -> pairing, unsparing, uninspiring ltunify.x86_64: W: no-manual-page-for-binary read-dev-usbmon ltunify.x86_64: W: no-manual-page-for-binary usbmon.awk ltunify.x86_64: W: no-manual-page-for-binary ltunify 1 packages and 0 specfiles checked; 0 errors, 4 warnings. These are OK. Rpmlint (installed packages) ---------------------------- # rpmlint ltunify ltunify.x86_64: W: spelling-error %description -l en_US unpairing -> pairing, unsparing, uninspiring ltunify.x86_64: W: no-manual-page-for-binary read-dev-usbmon ltunify.x86_64: W: no-manual-page-for-binary usbmon.awk ltunify.x86_64: W: no-manual-page-for-binary ltunify 1 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Same here. Requires -------- ltunify (rpmlib, GLIBC filtered): /usr/bin/gawk libc.so.6()(64bit) rtld(GNU_HASH) unifying-receiver-udev Provides -------- ltunify: ltunify ltunify(x86-64) MD5-sum check ------------- https://git.lekensteyn.nl/ltunify/snapshot/ltunify-0.1.tar.gz : CHECKSUM(SHA256) this package : 4ab9d38c698b6cfcbf171a22fceb7d234b8b940ae34a1da00ee7afe6289de923 CHECKSUM(SHA256) upstream package : 4ab9d38c698b6cfcbf171a22fceb7d234b8b940ae34a1da00ee7afe6289de923 The review is hereby APPROVED.
New Package SCM Request ======================= Package Name: ltunify Short Description: Command line utility for Logitech Unifying Receiver Owners: brouhaha Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
ltunify-0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ltunify-0.1-1.fc19
ltunify-0.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ltunify-0.1-1.fc18
ltunify-0.1-1.fc19 has been pushed to the Fedora 19 testing repository.
ltunify-0.1-1.fc19 has been pushed to the Fedora 19 stable repository.
ltunify-0.1-1.fc18 has been pushed to the Fedora 18 stable repository.