Description of problem: on launching mutt, it waits for user to manually accept certificate everytime, selecting "accept always" doesn't work. Version-Release number of selected component (if applicable): 1.5.21 How reproducible: always Steps to Reproduce: 1. Launch mutt Actual results: Certificate details displayed, waits for user to accept. This is also observed when the user sends an email. Expected results: once 'accept always' is selected, it shouldn't prompt the user again, (as long as the certificate remains the same atleast) Additional info: I observed this while conencting to gmail, unsure if it's gmail specific.
I confirm this issue. It occurs with my university account, e.g. it is not gmail specific.
Note that this is happens on F19, too, but not on F18. Probably caused by this commit: http://pkgs.fedoraproject.org/cgit/mutt.git/commit/?h=f19&id=422b1495da5cba34449990520377066d46ba3742 (i.e. package revision 18).
This part of mutt-1.5.21-verpeers.patch is wrong: +- gnutls_certificate_status certstat; ++ int verify_ret; ++ unsigned int status; + +- certstat = gnutls_certificate_verify_peers (tlsstate); +- if (!certstat) +- return certstat; ++ verify_ret = gnutls_certificate_verify_peers2 (tlsstate, &status); ++ if (!verify_ret) ++ return status; + +- if (certstat == GNUTLS_E_NO_CERTIFICATE_FOUND) ++ if (status == GNUTLS_E_NO_CERTIFICATE_FOUND) + { + mutt_error (_("Unable to get certificate from peer")); + mutt_sleep (2); + return 0; + } +- if (certstat < 0) ++ if (verify_ret < 0) and so on. status should be of type enum gnutls_certificate_status_t and the checks should be for GNUTLS_CERT_INVALID in the first condition and >0 in the second, if I'm reading the code correctly.
Apparently I'm reading it wrong, disregard comment #3, please.
Thanks for reporting. It seems the issue was introduced by patch for #750929. Build mutt-1.5.21-20.fc19 should fix the issue, it will be available in couple of minutes.
mutt-1.5.21-20.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mutt-1.5.21-20.fc18
mutt-1.5.21-20.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/FEDORA-2013-8745/mutt-1.5.21-20.fc19
Package mutt-1.5.21-20.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing mutt-1.5.21-20.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-8745/mutt-1.5.21-20.fc19 then log in and leave karma (feedback).
(In reply to Honza Horak from comment #5) > Thanks for reporting. It seems the issue was introduced by patch for > #750929. Build mutt-1.5.21-20.fc19 should fix the issue, it will be > available in couple of minutes. I'm not sure what to make of it. On one hand, it stopped appending the same certificate over and over to the specified certificates file (which was another bug, unreported here), but on the other hand, the option to "accept always" simply isn't there anymore. So this update "fixes" this issue in the sense that the option isn't available anymore.
For me the update seems to solve the problem. The option 'always accept' is not missing and working correctly here.
(In reply to Dominik 'Rathann' Mierzejewski from comment #9) > I'm not sure what to make of it. On one hand, it stopped appending the same > certificate over and over to the specified certificates file (which was > another bug, unreported here), but on the other hand, the option to "accept > always" simply isn't there anymore. Hm, I don't think this is caused by that fix, since only certification comparison has been fixed. The behaviour you describe may be caused by some issues with certificate, as a comment in the code says: /* certificates with bad dates, or that are revoked, must be accepted manually each and every time */
mutt-1.5.21-20.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
mutt-1.5.21-20.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.