Spec URL: http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python.spec SRPM URL: http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python-1.2.0-0.el5.centos.src.rpm Description: Python bindings for gfal 2.0. GFAL 2.0 offers an a single, simple and portable API for the file operations in grids and cloud environments Fedora Account System Username: adev Review request for the python bindings of the gfal 2.0 library. Koji builds : Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5311762 rpmlint output : gfal2-python.x86_64: W: incoherent-version-in-changelog 1.2.0-0 ['1.2.0-0.el5.centos', '1.2.0-0.centos'] 4 packages and 0 specfiles checked; 0 errors, 1 warnings.
Koji EL5 : http://koji.fedoraproject.org/koji/taskinfo?taskID=5311920 Koji EL6 : http://koji.fedoraproject.org/koji/taskinfo?taskID=5311925 Koji f20 : http://koji.fedoraproject.org/koji/taskinfo?taskID=5311957
rpmlint output (based on the f20 koji build): $ rpmlint -i -v * gfal2-python.src: I: checking gfal2-python.src: W: spelling-error Summary(en_US) gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.src: W: spelling-error %description -l en_US gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.src: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python.src: I: checking-url http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python-1.2.0.tar.gz (timeout 10 seconds) gfal2-python.i686: I: checking gfal2-python.i686: W: spelling-error Summary(en_US) gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.i686: W: spelling-error %description -l en_US gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.i686: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python.i686: W: private-shared-object-provides /usr/lib/python2.7/site-packages/gfal2.so gfal2.so A shared object soname provides is provided by a file in a path from which other packages should not directly load shared objects from. Such shared objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator. gfal2-python.x86_64: I: checking gfal2-python.x86_64: W: spelling-error Summary(en_US) gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.x86_64: W: spelling-error %description -l en_US gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.x86_64: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/gfal2.so gfal2.so()(64bit) A shared object soname provides is provided by a file in a path from which other packages should not directly load shared objects from. Such shared objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator. gfal2-python-debuginfo.x86_64: I: checking gfal2-python-debuginfo.x86_64: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python-doc.i686: I: checking gfal2-python-doc.i686: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python-doc.x86_64: I: checking gfal2-python-doc.x86_64: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python.spec: I: checking-url http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python-1.2.0.tar.gz (timeout 10 seconds) 6 packages and 1 specfiles checked; 0 errors, 8 warnings. W: private-shared-object-provides /usr/lib/python2.7/site-packages/gfal2.so gfal2.so Don't know what it means and how this could be fixed. Any explanation is welcome. Please use python2-devel instead of python-devel: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires glib2-devel is redundant, it is needed by gfal2-devel anyway. Please drop it from BR. $ rpm -qpR gfal2-python-1.2.0-0.fc20.i686.rpm boost(x86-32) libboost_python-mt.so.1.53.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgfal2.so.2 libgfal_transfer.so.2 libglib-2.0.so.0 libgthread-2.0.so.0 libm.so.6 libpython2.7.so.1.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libstdc++.so.6(GLIBCXX_3.4.11) libstdc++.so.6(GLIBCXX_3.4.9) python(abi) = 2.7 python(x86-32) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 Obviously your explicit runtime requirements are unneeded. Both Boost and Python are picked up automatically. The -doc subpackage doesn't contain any arch specific files, please tag it as "BuildArch: noarch". Moreover, the %{?_isa} tag there is obsolete then. The %changelog section is somewhat overloaded. Put any changes there regarding the package itself, not the underlying upstream software. Once the package is ready for importing it to the Git repo, make sure you remove all the EPEL5-specific parts from the non-EPEL5 spec files (%defattr, %clean section, initial cleaning of buildroot in %install and the BuildRoot: tag).
Update : Spec URL: http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python.spec SRPM URL: http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python-1.2.0-1.el5.centos.src.rpm > Obviously your explicit runtime requirements are unneeded. Both Boost and Python are picked up automatically. --> Corrected > glib2-devel is redundant, it is needed by gfal2-devel anyway. Please drop it from BR. --> Done --> Please use python2-devel instead of python-devel: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires --> Done > W: private-shared-object-provides /usr/lib/python2.7/site-packages/gfal2.so gfal2.so Don't know what it means and how this could be fixed. Any explanation is welcome. --> Means that a shared library is outside of the standard library path /lib and /usr/lib, it's normal in the case of a python module. > The -doc subpackage doesn't contain any arch specific files, please tag it as "BuildArch: noarch". Moreover, the %{?_isa} tag there is obsolete then. --> It's technicaly impossible from what I know to have one subpackage noarch and an other arch specific inside the same SRPM. A lot of package follow the pattern of -doc arch specific package. xmltooling-doc.x86_64 : XML signing and encrytion library documentation xmltooling-docs.x86_64 : XMLTooling API Documentation xosd-devel.x86_64 : Development files for the XOSD on-screen display library xqilla-doc.x86_64 : XQilla documentation etc... -> The %changelog section is somewhat overloaded. Put any changes there regarding the package itself, not the underlying upstream software. --> Cleared -> Once the package is ready for importing it to the Git repo, make sure you remove all the EPEL5-specific parts from the non-EPEL5 spec files (%defattr, %clean section, initial cleaning of buildroot in %install and the BuildRoot: tag). I prefer keep one spec file and one SRPM for all plateform when possible, it simplify a lot the version management and the updates. Adrien
(In reply to Adrien Devresse from comment #3) > > W: private-shared-object-provides /usr/lib/python2.7/site-packages/gfal2.so gfal2.so > Don't know what it means and how this could be fixed. Any explanation is > welcome. > > --> Means that a shared library is outside of the standard library path /lib > and /usr/lib, it's normal in the case of a python module. > Of course it is normal, but you have to filter out this library from the provides: $ rpm -qp --provides gfal2-python-1.2.0-0.fc20.i686.rpm gfal2-python = 1.2.0-0.fc20 gfal2-python(x86-32) = 1.2.0-0.fc20 gfal2.so The library is private in terms of not intended to be present in a common library path. It has to become "invisible". See http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering for how to do so. > > The -doc subpackage doesn't contain any arch specific files, please tag it as "BuildArch: noarch". Moreover, the %{?_isa} tag there is obsolete then. > > --> It's technicaly impossible from what I know to have one subpackage > noarch and an other arch specific inside the same SRPM. > A lot of package follow the pattern of -doc arch specific package. > Maybe, but by adding the appropriate tag you could solve this: %package doc Summary: Documentation for %{name} Group: Applications/Internet BuildArch: noarch Requires: %{name} = %{version}-%{release} However, you get the -doc package twice after running the build. But it appears only once in the repositories.
> Maybe, but by adding the appropriate tag you could solve this: Adding this tag, at least when targeting EL5, leads to a simple package compilation failure. The BuildArch tag affect the full package and not only the doc subpackage.
(In reply to Adrien Devresse from comment #3) > I prefer keep one spec file and one SRPM for all plateform when possible, it > simplify a lot the version management and the updates. Keep in mind, different branches need different spec files in certain cases. Have a look at the guidelines where are some special parts for EPEL 5 which are not intended to be entrained through all newer branches. Times have changed ;) http://fedoraproject.org/wiki/EPEL:Packaging "As a reminder, these guidelines only apply to EPEL packages, not to Fedora packages." (In reply to Adrien Devresse from comment #5) > > Maybe, but by adding the appropriate tag you could solve this: > > Adding this tag, at least when targeting EL5, leads to a simple package > compilation failure. > The BuildArch tag affect the full package and not only the doc subpackage. This is vaild for EPEL 5, and *only* for that branch. Of course, you can leave it as is for el5. But for all newer releases, a doc package which contains no binaries should be noarch. Fix the other issues, and I will do the final review.
Thank you for your comments Mario > The library is private in terms of not intended to be present in a common library path. It has to become "invisible". See http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering for how to do so. Done > This is vaild for EPEL 5, and *only* for that branch. Of course, you can leave it as is for el5. But for all newer releases, a doc package which contains no binaries should be noarch. Fix the other issues, and I will do the final review. I resolved the issue by excluding the BuildArch: noarch with a conditional on EL5. Several packages like json-c uses the same approach. > Keep in mind, different branches need different spec files in certain cases. Have a look at the guidelines where are some special parts for EPEL 5 which are not intended to be entrained through all newer branches. Times have changed ;) Yes, but even in this case I prefer use only one spec file with conditionals statements instead of branching my spec. And I'm not preferring this just in to contradict you or because I'm lazy :) With the frequency of our updates and the number of our the grid middlewares components, it's just impossible to maintain without becoming mad if we start to branch for each plateform. Updates : SRPM: grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python-1.2.1-1.el5.centos.src.rpm SPEC : grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python-1.2.1-1.el5.centos.src.rpm
Updates bis ( link update ) SRPM: http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python-1.2.1-1.el5.centos.src.rpm SPEC : http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python.spec
koji builds : rawhide : http://koji.fedoraproject.org/koji/taskinfo?taskID=5528023 f19 : http://koji.fedoraproject.org/koji/taskinfo?taskID=5528034 EL6 : http://koji.fedoraproject.org/koji/taskinfo?taskID=5528026 EL5: http://koji.fedoraproject.org/koji/taskinfo?taskID=5528030
$ rpmlint -i -v * gfal2-python.src: I: checking gfal2-python.src: W: spelling-error Summary(en_US) gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.src: W: spelling-error %description -l en_US gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.src: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 21) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. gfal2-python.src: I: checking-url http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python-1.2.1.tar.gz (timeout 10 seconds) gfal2-python.i386: I: checking gfal2-python.i386: W: spelling-error Summary(en_US) gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.i386: W: spelling-error %description -l en_US gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.i386: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python.x86_64: I: checking gfal2-python.x86_64: W: spelling-error Summary(en_US) gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.x86_64: W: spelling-error %description -l en_US gfal -> gal, goal, fall The value of this tag appears to be misspelled. Please double-check. gfal2-python.x86_64: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python-debuginfo.i386: I: checking gfal2-python-debuginfo.i386: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python-debuginfo.x86_64: I: checking gfal2-python-debuginfo.x86_64: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python-doc.i386: I: checking gfal2-python-doc.i386: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python-doc.x86_64: I: checking gfal2-python-doc.x86_64: I: checking-url https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds) gfal2-python.spec:21: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 21) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. gfal2-python.spec: I: checking-url http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python-1.2.1.tar.gz (timeout 10 seconds) 7 packages and 1 specfiles checked; 0 errors, 8 warnings. Ignorable spelling errors, but some issues remain: The mixed-use-of-spaces-and-tabs is rather cosmetic but it is better to have the same view in all text editors. I recommend to use whitespaces only, but it is your choice. Use what you prefer, don't mix both. To uncouple the el5-specific stuff from newer versions, please make the following parts of your spec file conditional for el5 only: * The BuildRoot definition * The initial cleaning of %{buildroot} in %install * The whole %clean section * The %defattr lines in the file lists
Hi Mario, >The mixed-use-of-spaces-and-tabs is rather cosmetic but it is better to have the same view in all text editors. I recommend to use whitespaces only, but it is your choice. Use what you prefer, don't mix both. It's a false positive, this "space" is inside a comment. Anyway, I removed this upstream in order to silent the warning. > To uncouple the el5-specific stuff from newer versions, please make the following parts of your spec file conditional for el5 only: * The BuildRoot definition * The initial cleaning of %{buildroot} in %install * The whole %clean section * The %defattr lines in the file lists I don't see the point to do this to be honest : - these EPEL specific part are not "against" fedora review guidelines ( https://fedoraproject.org/wiki/Packaging:ReviewGuidelines ), they are just mark as not "required". - They are in any case, ignored by the recent fedora. - Adding useless conditional macros make the spec file unreadable. - A lot of already reviewed fedora packages contains them without any problem : -> http://pkgs.fedoraproject.org/cgit/json-c.git/tree/json-c.spec?h=f19 -> http://pkgs.fedoraproject.org/cgit/leafpad.git/tree/leafpad.spec -> http://pkgs.fedoraproject.org/cgit/libnet.git/tree/libnet.spec -> http://pkgs.fedoraproject.org/cgit/librabbitmq.git/tree/librabbitmq.spec -> ... Adrien.
I'm not really convinced yet about the el5 stuff in all the other branches, but it's your choice, and it doesn't seem to break the guidelines explicitely. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. ASL 2.0 [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum * b9378a34f1cdb4e64beadd8b25a9c32501caa384ab45bb72f66c5449733c2455 gfal2-python-1.2.1.tar.gz b9378a34f1cdb4e64beadd8b25a9c32501caa384ab45bb72f66c5449733c2455 gfal2-python-1.2.1.tar.gz.orig [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [+] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [.] MUST: Development files must be in a -devel package. [.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses Mock anyway). [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. ---------------- PACKAGE APPROVED ----------------
Thank you very much Mario, don't hesitate if you need a review swap.
New Package SCM Request ======================= Package Name: gfal2-python Short Description: Python bindings for gfal 2.0 Owners: adev Branches: f17 f18 f19 el6 el5 InitialCC:
Git done (by process-git-requests).