Bug 957981

http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#Select_messages_using_a_filter

(1) we are missing the headers names table for AMQP and JMS headers

see https://svn.apache.org/repos/asf/qpid/trunk/qpid/specs/apache-filters.xml#type-selector-filter
and http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Selector.cpp?revision=1559017&view=markup table in code itself

to let users know which headers are mapped to what literal in selectors


(2) in the colour example is used "colour" and in the text above is "color" please unite it as "color"

(3) please add some examples using other constructs like

amqp.priority IS BETWEEN 3 AND 6
amqp.durable AND amqp.redelivered
amqp.reply_to LIKE '%news%'

etc.


-> ASSIGNED

1. Added the table to this new section: http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#sect-Java_Message_Service_with_Filters

2. & 3. : http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#Select_messages_using_a_filter

1. please separate comments from the parameters names, like:
JMSCorrelationID | correlation-id field of properties section
should be
JMSCorrelationID | correlation-id | field of properties section


Please add this table to the selector section http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Selector.cpp?revision=1559017&view=markup 

to let users know what fields could be accessed by selectors and how.

2. OK
3. OK

-> ASSIGNED

1. Separated columns.


I'm not sure what's missing from that table - all the information from that table seems to me to be present for the JMS Selector mapping table in the doc.

Is there something that I am missing?

table contains almost all information, but there is 'durable' and 'delivery_mode' and they are different, please add them both.

Also please note that only 3 amqp headers are currently implemented, see Bug 1083015

also I'm not completely sure that all fields mentioned as amqp headers are really headers but only selectors aliases for JMS equivalent values.

Bug 1083015 was postponed to 3.1, please make a note that only 3 headers are implemented now.

According to https://bugzilla.redhat.com/show_bug.cgi?id=1083015#c11

correlation_id is the only one that is not implemented in 3.0, and the others *should* work.

That is not correct, for MRG 3.0 only headers in Bug 1083015 Comment 6 are implemented.

Others may be implemented in upstream 0.28 as seen in Bug 1083015 Comment 5.

OK. Not sure if I have this right... I have pared down the table to the three selectors that are implemented for MRG 3.0:

http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#sect-Java_Message_Service_with_Filters

Headers table is correct, those are headers implemented in 3.0


http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#sect-Java_Message_Service_with_Filters

[4]
Table 2. Mapping AMQP types to JMS types
there is one empty row breaking the alternating background, please fix it



http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#Select_messages_using_a_filter

[5a]
because some headers are not yet implemented and some selector issues exists, we have to change examples section:

according to this Bug 1090376
we have to change the LIKE example from
  queue_name;{link:{selector:"amqp.reply_to LIKE '%news%'"}}
to
  queue_name;{link:{selector:"amqp.reply_to LIKE '%news%'"}}

[5b]
according to implemented headers we need to change example
  queue_name;{link:{selector:"amqp.durable AND amqp.redelivered"}}
to
  queue_name;{link:{selector:"myflag AND amqp.redelivered"}}

[5c]
according to implemented headers we need to delete examples:
  queue_name;{link:{selector:"amqp.message_id = 'c'"}}
  queue_name;{link:{selector:"amqp.correlation_id = 'b'"}}

[6]
because of existing issue Bug 1090022, please add note for python:
  With python, selectors could be used by temporary syntax
  for example c++ address with selector
    queue_name;{link:{selector:"myproperty = 1"}}
  in python is temporarily used as:
    queue_name;{link:{'x-subscribe': {'arguments': {'x-apache-selector': "myproperty = 1"}}}}

[7]
because of existing issue Bug 1090024, please add note for java:
  Java temporarily does not support qpid server side selectors, only JMS selectors.

addition to a [7]
Please add to note that the JMS native selectors behaves slightly differently, and recommend to consult JMS Specification.

[4] Removed empty row:
http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#sect-Java_Message_Service_with_Filters

[5a] The two lines are the same?

[5b] Changed

[5c] Removed

[6] Added 

[7] Documented

[4]  OK
[5a] I'm sorry, that's my fault, there is correct example:
queue_name;{link:{selector:"msg_title LIKE '%news%'"}}

[5b] OK
[5c] OK
[6]  OK
[7]  OK

[8] Please make sure that the rounded rectangle with examples is fit to the content, there are 3 empty lines.

I'm looking here: http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#sect-Java_Message_Service_with_Filters

And I see no empty lines. Is this the right place?

Sorry for not providing correct source.

it's here 
http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#Select_messages_using_a_filter

⁠6.4.1. Select messages using a filter

second code block


same location for [5a]

Updated:

http://deathstar1.usersys.redhat.com:3000/builds/19948-Messaging_Programming_Reference/#Select_messages_using_a_filter

This is correct.

Verifiable, but waiting on BNF syntax Bug 961011

BNF Syntax resolved. -> VERIFIED